Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B83BBC433DB for ; Tue, 19 Jan 2021 09:28:53 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 47E58221E5 for ; Tue, 19 Jan 2021 09:28:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 47E58221E5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=containers-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id CA0A386CAC; Tue, 19 Jan 2021 09:28:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FG7ur7Op9D+t; Tue, 19 Jan 2021 09:28:52 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by hemlock.osuosl.org (Postfix) with ESMTP id 66CEB86C6D; Tue, 19 Jan 2021 09:28:52 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 41281C0FA7; Tue, 19 Jan 2021 09:28:52 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id EB0ACC013A for ; Tue, 19 Jan 2021 09:28:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id D9B1A86C66 for ; Tue, 19 Jan 2021 09:28:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fN69pxTmXNGr for ; Tue, 19 Jan 2021 09:28:50 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by hemlock.osuosl.org (Postfix) with ESMTPS id 5497F86C6D for ; Tue, 19 Jan 2021 09:28:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Cyfg7cDbWy/IPZ5awSQp2Q1kduN8Yx/DetEnfOJ3/Ps=; b=hgXOWzDXEAqTZlmh2ClzTTHRUY kNqj/YWNpIiNNZI4h7sTjieFjx9mprWMfZnRcp8t7TacpXmDaaQp4cwed1L+LImBNTC7PkR19OlFw l74TZkUfg/yb2+351DtCkqJGjGA//VMbi64D9uMwjjFg6zEbkgDUYAPoWGhYImQW9OYMYb9x33Cok z6ZNSrca6AZn9M8SO/a8rCa6k7GCEA7AJ2cCB+cWjOWTS5FoeF5pVii0a+ABJnK9EaOXngmZLovSz 1mUgRxoG8YYjkwysnzGCtHVHdcb4hxB5A6snhHSjwlWoWmZx48iwjn33REIhr4uahIzSn2loXZTeh Ub5giDlg==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l1nIL-00E79Y-KZ; Tue, 19 Jan 2021 09:27:25 +0000 Date: Tue, 19 Jan 2021 09:27:25 +0000 From: Christoph Hellwig To: Christian Brauner Subject: Re: [PATCH v5 15/42] fs: add file_user_ns() helper Message-ID: <20210119092725.GG3361757@infradead.org> References: <20210112220124.837960-1-christian.brauner@ubuntu.com> <20210112220124.837960-16-christian.brauner@ubuntu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210112220124.837960-16-christian.brauner@ubuntu.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Cc: Lennart Poettering , Mimi Zohar , David Howells , Andreas Dilger , containers@lists.linux-foundation.org, Christoph Hellwig , Tycho Andersen , Paul Moore , Jonathan Corbet , smbarber@chromium.org, Christoph Hellwig , Alban Crequy , linux-ext4@vger.kernel.org, Mrunal Patel , Kees Cook , Arnd Bergmann , selinux@vger.kernel.org, Josh Triplett , Seth Forshee , Aleksa Sarai , Alexander Viro , Andy Lutomirski , OGAWA Hirofumi , Geoffrey Thomas , James Bottomley , John Johansen , Theodore Tso , Dmitry Kasatkin , Stephen Smalley , linux-xfs@vger.kernel.org, linux-security-module@vger.kernel.org, "Eric W. Biederman" , linux-api@vger.kernel.org, Casey Schaufler , linux-fsdevel@vger.kernel.org, linux-integrity@vger.kernel.org, Linus Torvalds , Todd Kjos X-BeenThere: containers@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux Containers List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: containers-bounces@lists.linux-foundation.org Sender: "Containers" On Tue, Jan 12, 2021 at 11:00:57PM +0100, Christian Brauner wrote: > Add a simple helper to retrieve the user namespace associated with the > vfsmount of a file. Christoph correctly points out that this makes > codepaths (e.g. ioctls) way easier to follow that would otherwise > dereference via mnt_user_ns(file->f_path.mnt). > > In order to make file_user_ns() static inline we'd need to include > mount.h in either file.h or fs.h which seems undesirable so let's simply > not force file_user_ns() to be inline. I'd be tempted to just make this an inline. Otherwise this looks ok: Reviewed-by: Christoph Hellwig _______________________________________________ Containers mailing list Containers@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/containers