From: Tom Rini Date: Tue, 19 Jan 2021 14:45:41 -0500 Subject: CRASH caused by: [PATCH 06/10] setexpr: Add some tests for buffer overflow and backref In-Reply-To: References: <20201101211544.3579850-1-sjg@chromium.org> <20201101211544.3579850-7-sjg@chromium.org> Message-ID: <20210119194541.GI9782@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Jan 19, 2021 at 11:06:18AM -0700, Simon Glass wrote: > Hi Heinrich, > > On Sun, 17 Jan 2021 at 15:52, Heinrich Schuchardt wrote: > > > > On 11/1/20 10:15 PM, Simon Glass wrote: > > > Add tests to check for buffer overflow using simple replacement as well > > > as back references. At present these don't fully pass. > > > > > > Signed-off-by: Simon Glass > > > --- > > > > > > cmd/setexpr.c | 21 +++-------- > > > include/command.h | 17 +++++++++ > > > test/cmd/setexpr.c | 89 ++++++++++++++++++++++++++++++++++++++++++++++ > > > 3 files changed, 110 insertions(+), 17 deletions(-) > > Yes this is intended for sandbox. > > Do you really want to run this test on a board? If the compiler is > working, then the sandbox test should be enough. > > I can certainly update it to run on boards, but that was not the intent. I think it is good to run tests on hardware when there's no reason not to. It ends up adding to the "if we're up and doing stuff for a while, is the platform stable?" form of testing, which is harder to replicate but useful at times. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: