Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1094C433DB for ; Wed, 20 Jan 2021 18:04:21 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFE1023122 for ; Wed, 20 Jan 2021 18:04:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BFE1023122 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2BCC517BE; Wed, 20 Jan 2021 19:03:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2BCC517BE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1611165859; bh=80QPQ1tUnCI+MW0jTeGbyt3BfzbMKu1EZPYFQ/8znYo=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=UtEi1U5bXijIuJZwOqVNVTIkpqgJE2CpIzm22ik7gRuBzWA9Y962Sf3yRaAPK7xfx qSRx7Q8XH1ZnxpcFeuiQToWdA1tlmUkrv9rocS3contHUmAZCbp5+NBbT+r+Hpqf7t /EwgUhL9STY3O5jYzqzpqKvB9caIwdnvpnziyWOY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id F375CF804DF; Wed, 20 Jan 2021 19:02:05 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 16286F804E0; Wed, 20 Jan 2021 19:02:04 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BBE8DF804C2 for ; Wed, 20 Jan 2021 19:01:57 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BBE8DF804C2 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iguP1zsY" Received: by mail.kernel.org (Postfix) with ESMTPSA id A0A73223E0; Wed, 20 Jan 2021 18:01:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611165714; bh=80QPQ1tUnCI+MW0jTeGbyt3BfzbMKu1EZPYFQ/8znYo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iguP1zsYz+guPEqch2wN+Veq3R2y5uH+8bvPG3YSyGndMBy08wFATTnEuFfaZDYpw n0jSHz15FPbAxGxQeUS6f1vkoD7IuDlT/DuvuFjdoytNA70lJCohEV3ISAOYR8uFDy oRsNi2DZd3r2NiCecmRbSyYYaHWLpdNe45fRX/wyjH3RIawFAI3oirpayXq0foZ/GL OKKdIvUMR2eAQ28Wr3S7oJouj9gxlMFIH65ExIfYIzw/L0KTJgOFVlE7xdg/eMH7Kr Af2QAzZLeOX0W8xBR2M+81k6rZD+Pk+KAln+bkn90Q2g7cvu3o+QnqweKR0jn4fwRk chC/A/NkbuejQ== Date: Wed, 20 Jan 2021 18:01:16 +0000 From: Mark Brown To: shumingf@realtek.com Subject: Re: [PATCH 2/2] ASoC: rt5682: add device property to control LDO2 power Message-ID: <20210120180116.GG6794@sirena.org.uk> References: <20210120091218.10837-1-shumingf@realtek.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2hMgfIw2X+zgXrFs" Content-Disposition: inline In-Reply-To: <20210120091218.10837-1-shumingf@realtek.com> X-Cookie: Beware of Bigfoot! User-Agent: Mutt/1.10.1 (2018-07-13) Cc: oder_chiou@realtek.com, jack.yu@realtek.com, alsa-devel@alsa-project.org, lars@metafoo.de, lgirdwood@gmail.com, albertchen@realtek.com, derek.fang@realtek.com, flove@realtek.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --2hMgfIw2X+zgXrFs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 20, 2021 at 05:12:18PM +0800, shumingf@realtek.com wrote: > From: Shuming Fan >=20 > The application circuit shall provide MICVDD power. > In default, the codec driver doesn't need to enable LDO2 power. > In case, the customers use VBAT for micbias, it should enable the device = property "realtek,ldo2-pow-en". Given that this is just adding a DAPM route I think we can just skip the property and instead simply leave the LDO registered but not connected in the DAPM graph, if a board wants to use it then it can just add a route from the LDO to the relevant input like is currently hard coded in the board file. --2hMgfIw2X+zgXrFs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmAIb+sACgkQJNaLcl1U h9B9Kgf+O9gfjwVDh1s8alMiUDUiAG5F5IIeNjXvHrENnJtRRFsRgSU52eaLm2AL 9vK61g/F3eSK+1YLPhBwihX7q6Yuv59AHtWMxxUhvzt1FPYLFYKk8IwznllsXZCd hNS5c6QJ5al+LfMLyGkozbmcTlk4t3kmubXovWAEHCQ1aKc1xAAUK3iLdR8Bpj0f b4JynBWRVejTK/NfxfRpl7wpKq9oHSZ8qoEHIb4jIW/e6Vf9TH2LnVXu7pKSKfJj YlgLAmHIsCPSfqMj9qaVkpwZ0mGcuyK0dPHI/OA9ixByoA2Kf2RkfLdDm6IXM6P1 gO+rTK7jQr7K4XYS79TLUh7RxF1TSA== =+Q2S -----END PGP SIGNATURE----- --2hMgfIw2X+zgXrFs--