Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BD71C433E0 for ; Wed, 27 Jan 2021 19:49:55 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD1DB64DBE for ; Wed, 27 Jan 2021 19:49:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD1DB64DBE Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.76379.137794 (Exim 4.92) (envelope-from ) id 1l4qon-0004aL-4d; Wed, 27 Jan 2021 19:49:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 76379.137794; Wed, 27 Jan 2021 19:49:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l4qon-0004aE-1e; Wed, 27 Jan 2021 19:49:33 +0000 Received: by outflank-mailman (input) for mailman id 76379; Wed, 27 Jan 2021 19:49:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1l4qol-0004a4-CW for xen-devel@lists.xenproject.org; Wed, 27 Jan 2021 19:49:31 +0000 Received: from esa3.hc3370-68.iphmx.com (unknown [216.71.145.155]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id c0ecc852-4534-45cc-a014-3c442b1883ec; Wed, 27 Jan 2021 19:49:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c0ecc852-4534-45cc-a014-3c442b1883ec DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1611776969; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=HE6CYo1rULtA/zqqNnXd6bBpST+UgXMlh3bvVsRO67M=; b=hGkAMJvc4nxafRMDza03aZJCxzTJQURv00/FbQrGPnXD8baN4wDYBwbO SzogCXRmK4+xcvfagd1OgVX/P+bJjYSMKIghqFllTHnVr937J6h6vhBVs XWxJswnUcwwQecRjOlMU7ifzDgaO45n8TYyMkcc+zLUXBPqEtZ6GubLjP Y=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: SsovgsDCPNMSz8lYc36OPvT67G73rZPaghLLiRvDP6zU+YbLMlDy7eHdaoCax5Z1HYuPT5SbQp xlD4U8Ruj9PUMEmQP/HzOumoB9VoPRrkPthwhmcz0nDHZR0hQZJm3KWIRzyC6e00NCTRK4cUiz pnBpPoRTnYmEmOOgf1iOPYuXWX/0oPeFFNKS56Fk2jNu4I9m2021KddTducDF/GQ2SlyFZmB12 0JF1lDs/s0CrkRuZEsNXRbsSEyjXrdCvk3n89TLZZFivVkbpRXt4qNrTYGfXzAPcjSwQfIp7hQ KGw= X-SBRS: 5.2 X-MesageID: 35995632 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.79,380,1602561600"; d="scan'208";a="35995632" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Ian Jackson Subject: [PATCH for-4.15] x86/boot: Drop 'noapic' suggestion from check_timer() Date: Wed, 27 Jan 2021 19:49:04 +0000 Message-ID: <20210127194904.9922-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit In practice, there is no such thing as a real 64bit system without APICs. (PVH style virtual environments, sure, but they don't end up here). The suggestion to try and use noapic only makes a bad situation worse. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Ian Jackson I wanted to have enough time to drop all of the pre-APIC infrastructure, but that is a massive can of decades-old-worms. For 4.15, suffice just to to prevent misleading users more than necessary. --- xen/arch/x86/io_apic.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c index e66fa99ec7..e93265f379 100644 --- a/xen/arch/x86/io_apic.c +++ b/xen/arch/x86/io_apic.c @@ -1994,8 +1994,7 @@ static void __init check_timer(void) return; } printk(" failed :(.\n"); - panic("IO-APIC + timer doesn't work! Boot with apic_verbosity=debug " - "and send a report. Then try booting with the 'noapic' option\n"); + panic("IO-APIC + timer doesn't work! Boot with apic_verbosity=debug and send a report\n"); } /* -- 2.11.0