Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EAC8C433E0 for ; Thu, 28 Jan 2021 18:16:11 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB2A264DF5 for ; Thu, 28 Jan 2021 18:16:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB2A264DF5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 5BA0186D8B; Thu, 28 Jan 2021 18:16:10 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jr6+JyTHfqGR; Thu, 28 Jan 2021 18:16:08 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id E2BB486C0F; Thu, 28 Jan 2021 18:16:08 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C3AB7C0FA8; Thu, 28 Jan 2021 18:16:08 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id E5969C08A1 for ; Thu, 28 Jan 2021 18:16:07 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id C1C7B2E0F7 for ; Thu, 28 Jan 2021 18:16:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1mzIo-w+ouFv for ; Thu, 28 Jan 2021 18:16:06 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by silver.osuosl.org (Postfix) with ESMTPS id 016952E0FD for ; Thu, 28 Jan 2021 18:16:05 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id B320468B02; Thu, 28 Jan 2021 19:15:58 +0100 (CET) Date: Thu, 28 Jan 2021 19:15:57 +0100 From: Christoph Hellwig To: Robin Murphy Subject: Re: [PATCH 1/3] Adding page_offset_mask to device_dma_parameters Message-ID: <20210128181557.GA11790@lst.de> References: <20210128003829.1892018-1-jxgao@google.com> <20210128003829.1892018-2-jxgao@google.com> <2863b6d2-47f6-51fa-f60c-ba24904818e9@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2863b6d2-47f6-51fa-f60c-ba24904818e9@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) Cc: axboe@fb.com, heikki.krogerus@linux.intel.com, sagi@grimberg.me, saravanak@google.com, konrad.wilk@oracle.com, marcorr@google.com, gregkh@linuxfoundation.org, rafael.j.wysocki@intel.com, linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com, kbusch@kernel.org, bgolaszewski@baylibre.com, iommu@lists.linux-foundation.org, jroedel@suse.de, linux-nvme@lists.infradead.org, dan.j.williams@intel.com, Jianxiong Gao , hch@lst.de X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Thu, Jan 28, 2021 at 05:27:25PM +0000, Robin Murphy wrote: > On 2021-01-28 00:38, Jianxiong Gao wrote: >> Some devices rely on the address offset in a page to function >> correctly (NVMe driver as an example). These devices may use >> a different page size than the Linux kernel. The address offset >> has to be preserved upon mapping, and in order to do so, we >> need to record the page_offset_mask first. >> >> Signed-off-by: Jianxiong Gao >> --- >> include/linux/device.h | 1 + >> include/linux/dma-mapping.h | 17 +++++++++++++++++ >> 2 files changed, 18 insertions(+) >> >> diff --git a/include/linux/device.h b/include/linux/device.h >> index 1779f90eeb4c..f44e0659fc66 100644 >> --- a/include/linux/device.h >> +++ b/include/linux/device.h >> @@ -292,6 +292,7 @@ struct device_dma_parameters { >> */ >> unsigned int max_segment_size; >> unsigned long segment_boundary_mask; >> + unsigned int page_offset_mask; > > Could we call this something more like "min_align_mask" (sorry, I can't > think of a name that's actually good and descriptive right now). > Essentially I worry that having "page" in there is going to be too easy to > misinterpret as having anything to do what "page" means almost everywhere > else (even before you throw IOMMU pages into the mix). > > Also note that of all the possible ways to pack two ints and a long, this > one is the worst ;) The block layer uses virt_boundary for the related concept, but that is pretty horrible too. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu