From: Andre Przywara Date: Fri, 29 Jan 2021 00:04:39 +0000 Subject: [PATCH] ata: sunxi: fix debug messages In-Reply-To: <20210124181310.23822-1-dariobin@libero.it> References: <20210124181310.23822-1-dariobin@libero.it> Message-ID: <20210129000439.57645b5e@slackpad.fritz.box> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, 24 Jan 2021 19:13:10 +0100 Dario Binacchi wrote: > It is useless and misleading to print the ret variable that is not set > by the dev_read_addr routine. Also, move the '\n' character after the > round bracket that contains the error code. > > Signed-off-by: Dario Binacchi Good catch! Tested-by: Andre Przywara Acked-by: Andre Przywara Cheers, Andre > --- > > drivers/ata/ahci_sunxi.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/ata/ahci_sunxi.c b/drivers/ata/ahci_sunxi.c > index 58e345d998..94a3379c53 100644 > --- a/drivers/ata/ahci_sunxi.c > +++ b/drivers/ata/ahci_sunxi.c > @@ -80,18 +80,18 @@ static int sunxi_sata_probe(struct udevice *dev) > > base = dev_read_addr(dev); > if (base == FDT_ADDR_T_NONE) { > - debug("%s: Failed to find address (err=%d\n)", __func__, ret); > + debug("%s: Failed to find address\n", __func__); > return -EINVAL; > } > reg = (u8 *)base; > ret = sunxi_ahci_phy_init(reg); > if (ret) { > - debug("%s: Failed to init phy (err=%d\n)", __func__, ret); > + debug("%s: Failed to init phy (err=%d)\n", __func__, ret); > return ret; > } > ret = ahci_probe_scsi(dev, base); > if (ret) { > - debug("%s: Failed to probe (err=%d\n)", __func__, ret); > + debug("%s: Failed to probe (err=%d)\n", __func__, ret); > return ret; > } > > @@ -105,7 +105,7 @@ static int sunxi_sata_bind(struct udevice *dev) > > ret = ahci_bind_scsi(dev, &scsi_dev); > if (ret) { > - debug("%s: Failed to bind (err=%d\n)", __func__, ret); > + debug("%s: Failed to bind (err=%d)\n", __func__, ret); > return ret; > } >