Content-Type: multipart/mixed; boundary="===============3281125125848792089==" MIME-Version: 1.0 From: Sakari Ailus To: kbuild-all@lists.01.org Subject: Re: [PATCH] media: i2c: fix odd_ptr_err.cocci warnings Date: Mon, 01 Feb 2021 15:04:47 +0200 Message-ID: <20210201130447.GN32460@paasikivi.fi.intel.com> In-Reply-To: List-Id: --===============3281125125848792089== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Mon, Jan 18, 2021 at 02:55:07PM +0100, Paul Kocialkowski wrote: > Hi, > = > On Sat 16 Jan 21, 21:11, Julia Lawall wrote: > > From: kernel test robot > > = > > PTR_ERR should access the value just tested by IS_ERR > = > Good catch! > = > Reviewed-by: Paul Kocialkowski Thanks, Julia and Paul. A patch with similar content got recently merged: commit 6e7cca2790a54057ddf64da7843271e192f71ca0 Author: Hans Verkuil Date: Wed Jan 20 09:42:38 2021 +0100 media: i2c/ov8865.c: fix error checks using wrong variable = Fix two typos: dvdd -> dovdd and dvdd -> avdd = Both clearly copy-and-paste mistakes. = Fixes this smatch warning: = drivers/media/i2c/ov8865.c:2852 ov8865_probe() warn: passing zero to 'P= TR_ERR' = Signed-off-by: Hans Verkuil Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Mauro Carvalho Chehab -- = Kind regards, Sakari Ailus --===============3281125125848792089==--