Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13ADFC433E0 for ; Tue, 2 Feb 2021 08:45:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD43364E27 for ; Tue, 2 Feb 2021 08:45:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232310AbhBBIpB (ORCPT ); Tue, 2 Feb 2021 03:45:01 -0500 Received: from mga11.intel.com ([192.55.52.93]:11758 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231987AbhBBIo6 (ORCPT ); Tue, 2 Feb 2021 03:44:58 -0500 IronPort-SDR: 0hKx44lJ042Ci9Igk063gydQncJMKLBKUXulL/emkpOhK/mkFN+rY547Iw43zVQVwAuLIndD0X fnJMLWTpmSsg== X-IronPort-AV: E=McAfee;i="6000,8403,9882"; a="177311506" X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="177311506" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 00:43:12 -0800 IronPort-SDR: PvPeEUSI/bdOiBqg2fn5xvzVfOmfC7dZoJt3+5h5XuPodPclMk7efvjBnzBBuaWxRRg+YEI6z0 dJYk3S0eB7Yg== X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="479487441" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 00:43:08 -0800 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 47A67207DF; Tue, 2 Feb 2021 10:43:06 +0200 (EET) Date: Tue, 2 Feb 2021 10:43:06 +0200 From: Sakari Ailus To: Helen Koike Cc: linux-media@vger.kernel.org, Hans Verkuil , kernel@collabora.com, Laurent Pinchart , Kieran Bingham , Jacopo Mondi , niklas.soderlund+renesas@ragnatech.se, Dafna Hirschfeld , Hugues Fruchet , Nicolas Ferre , Yong Zhi , Sylwester Nawrocki , Maxime Ripard , Robert Foss , Philipp Zabel , Ezequiel Garcia Subject: Re: [PATCH v4 11/14] media: v4l2-async: Fix incorrect comment Message-ID: <20210202084306.GP32460@paasikivi.fi.intel.com> References: <20210128120945.5062-1-sakari.ailus@linux.intel.com> <20210128120945.5062-12-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Helen, Thanks for the review! On Mon, Feb 01, 2021 at 04:33:54PM -0300, Helen Koike wrote: > > > On 1/28/21 9:09 AM, Sakari Ailus wrote: > > From: Ezequiel Garcia > > > > The v4l2_async_notifier_cleanup() documentation mentions > > v4l2_fwnode_reference_parse_sensor_common, which was actually > > introduced as v4l2_async_notifier_parse_fwnode_sensor_common(), > > in commit 7a9ec808ad46 ("media: v4l: fwnode: Add convenience function for > > parsing common external refs"). > > > > The function drivers do use is > > v4l2_async_register_subdev_sensor_common(). > > > > Signed-off-by: Ezequiel Garcia > > Signed-off-by: Sakari Ailus > > --- > > include/media/v4l2-async.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/media/v4l2-async.h b/include/media/v4l2-async.h > > index 8815e233677e..f2cac0931372 100644 > > --- a/include/media/v4l2-async.h > > +++ b/include/media/v4l2-async.h > > @@ -250,7 +250,7 @@ void v4l2_async_notifier_unregister(struct v4l2_async_notifier *notifier); > > * notifier after calling > > * @v4l2_async_notifier_add_subdev, > > * @v4l2_async_notifier_parse_fwnode_endpoints or > > - * @v4l2_fwnode_reference_parse_sensor_common. > > + * @v4l2_async_register_subdev_sensor_common. > > This line gets removed on patch 14/14, maybe just drop this patch? I'll squash it with 14th. -- Sakari Ailus