From: Tom Rini Date: Sun, 14 Feb 2021 15:25:15 -0500 Subject: [PATCH 09/17] fdtdec: Use CONFIG_IS_ENABLED in board_fdt_blob_setup() In-Reply-To: References: <20210114032957.483086-1-sjg@chromium.org> <20210114032957.483086-10-sjg@chromium.org> <20210128235801.GO7530@bill-the-cat> <20210214190808.GG10169@bill-the-cat> <20210214191013.GH10169@bill-the-cat> Message-ID: <20210214202515.GI10169@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, Feb 14, 2021 at 07:20:45PM +0000, Peter Robinson wrote: > On Sun, Feb 14, 2021 at 7:10 PM Tom Rini wrote: > > > > On Sun, Feb 14, 2021 at 02:08:08PM -0500, Tom Rini wrote: > > > On Sun, Feb 14, 2021 at 08:05:33PM +0100, Jesper Schmitz Mouridsen wrote: > > > > > > > > On 14.02.2021 19.50, Peter Robinson wrote: > > > > > Hi Simon, > > > > > > > > > > On Thu, Jan 28, 2021 at 11:59 PM Tom Rini wrote: > > > > > > On Wed, Jan 13, 2021 at 08:29:49PM -0700, Simon Glass wrote: > > > > > > > > > > > > > This setting may be different in SPL and TPL. Update the code to check > > > > > > > the correct setting. > > > > > > > > > > > > > > Signed-off-by: Simon Glass > > > > > > Applied to u-boot/master, thanks! > > > > > This breaks booting on at least rk3399 based devices for me with the > > > > > following error: > > > > > > > > > > U-Boot TPL 2021.04-rc1 (Feb 01 2021 - 00:00:00) > > > > > Missing DTB > > > > > ### ERROR ### Please RESET the board ### > > > > Also see https://lists.denx.de/pipermail/u-boot/2021-February/440263.html > > > > > > So we have two forms of bug. sunxi (your link above Jesper) needs > > > SPL_SEPARATE_BSS to be set I think. Peter's problem is that there is no > > > TPL_SEPARATE_BSS which is a harder problem to solve quickly. I'll post > > > a revert with you both Reported-by shortly, thanks. > > > > Er, wait. I'm a bit less clear on the why on sunxi at least. I'm going > > to post the revert shortly all the same. > > The sunxi bits seem OK with 2021.04-rc1 from my testing, at least for > this problem, to now in my testing it's only been the rockchip stuff > that's had issues but I'm still getting through all my devices. Yup. I need to fix my mental map of "pine* == sunxi", that was the confusion I had. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: