Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD66BC433DB for ; Mon, 15 Feb 2021 22:43:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A419264DDA for ; Mon, 15 Feb 2021 22:43:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229777AbhBOWn4 (ORCPT ); Mon, 15 Feb 2021 17:43:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229720AbhBOWn4 (ORCPT ); Mon, 15 Feb 2021 17:43:56 -0500 Received: from mail-qt1-x84a.google.com (mail-qt1-x84a.google.com [IPv6:2607:f8b0:4864:20::84a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1BB9C061574 for ; Mon, 15 Feb 2021 14:43:15 -0800 (PST) Received: by mail-qt1-x84a.google.com with SMTP id l63so6381332qtd.12 for ; Mon, 15 Feb 2021 14:43:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:message-id:mime-version:subject:from:to:cc; bh=0wElvRgNTl0iDIYef+iukzJo48+l2BEb5QT2NVP8CrY=; b=R9JsApEa0SQDiBumN9hoKMpVMQaoyNOjHHcp1DZk4bsrhZ1emx9arNfVLpj8DhQrLM ek6kmHUUvj6vWQJv2Xk83fTgTDtQXSyxtLwzJmjrxZ21ZhUXN/k31o38BAc2aTHafvu8 7DSy0xoFlkTDYm+TldQX2gjqKSE5PZ8CLsIuD9+1G8Zk7bi+fuf2cY3QToQZ/5+GT7Jj pw2xqvY9X7ukMUfdyqZVtuU2dVhRB55YnhPQqQWhrmTGyRZWWDe/RUeYWDQHSs8JDwON ZFqCrbEJ6m83B/Wu6rf2A5ltLj1bRSaCSmT6ke7sLDPokH4bkDNXOqd5oJUdvDbdKe8z ieOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:message-id:mime-version:subject:from :to:cc; bh=0wElvRgNTl0iDIYef+iukzJo48+l2BEb5QT2NVP8CrY=; b=RrnCfWAKyu9wl7yAOTO4eipnLfeCYuNSpYnl/XfTsLTJvTFH8MJnmTHkiLU8gkcg6h l7z7RxR8o7DgrtgaB000+bMUBswgO4xCk7fjziJg42q9/+Y5VpsUf5D4QM66p03HyVSC y+zSXHetrUd5jnjqPOQ2FltiI2gaIY1frN4pwNlSljjiDFlmrOLm8cX0HRN3+IuJQXSX 9cDNYe4hf0MXFMuGSarQzesFWBvzpm5Qo7MJxrgIeK4fGANkDpB26+wpCB8ovf44B5f6 TzMqzGARootZyx7XHcyLYg5s6c2o/J+uh6gF4CMSnUL68k4+T/pGlVSWBFxu087Jl8nk 2jCw== X-Gm-Message-State: AOAM532DbR7RfzG55DwG9mxtXX+tV5hYw06ALrS9xLsB/nWFTQq2+fxZ 1NHhNeVNu4zQcZjIL7eVXx1BdpuIBwqtEGs= X-Google-Smtp-Source: ABdhPJxXr8yZQALiMRqZkVXhcR2VUKse9BYWISgiYswf+oHn/FP2CkcZi7tYR2K7xI5bwKLb4KbW8tKfKTMmJ7c= Sender: "saravanak via sendgmr" X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:909c:cac6:3bbe:67a9]) (user=saravanak job=sendgmr) by 2002:a0c:b49f:: with SMTP id c31mr16885605qve.35.1613428993272; Mon, 15 Feb 2021 14:43:13 -0800 (PST) Date: Mon, 15 Feb 2021 14:42:58 -0800 Message-Id: <20210215224258.1231449-1-saravanak@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.30.0.478.g8a0d178c01-goog Subject: [PATCH] of: property: fw_devlink: Ignore interrupts property for some configs From: Saravana Kannan To: Rob Herring , Frank Rowand , Saravana Kannan , Linus Walleij , Greg Kroah-Hartman , Thierry Reding Cc: Guenter Roeck , kernel-team@android.com, Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org When CONFIG_OF_IRQ is not defined, it doesn't make sense to parse interrupts property. Also, parsing and tracking interrupts property breaks some PPC devices[1]. But none of the IRQ drivers in PPC seem ready to be converted to a proper platform (or any bus) driver. So, there's not much of a point in tracking the interrupts property for CONFIG_PPC. So, let's stop parsing interrupts for CONFIG_PPC. [1] - https://lore.kernel.org/lkml/20210213185422.GA195733@roeck-us.net/ Fixes: 4104ca776ba3 ("of: property: Add fw_devlink support for interrupts") Reported-by: Guenter Roeck Signed-off-by: Saravana Kannan --- Greg/Rob, I believe this needs to land on driver-core-next. -Saravana drivers/of/property.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/of/property.c b/drivers/of/property.c index 79b68519fe30..5036a362f52e 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -1300,6 +1300,9 @@ static struct device_node *parse_interrupts(struct device_node *np, { struct of_phandle_args sup_args; + if (!IS_ENABLED(CONFIG_OF_IRQ) || IS_ENABLED(CONFIG_PPC)) + return NULL; + if (strcmp(prop_name, "interrupts") && strcmp(prop_name, "interrupts-extended")) return NULL; -- 2.30.0.478.g8a0d178c01-goog