Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0BAE06E50D for ; Mon, 22 Feb 2021 14:09:41 +0000 (UTC) Date: Mon, 22 Feb 2021 15:07:16 +0100 From: Katarzyna Dec Message-ID: <20210222140716.GD29585@kdec5-desk.ger.corp.intel.com> References: <20210110112153.476908-1-apoorva1.singh@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210110112153.476908-1-apoorva1.singh@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t, v2] i915/i915_hangman: Added test description for test case List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: apoorva1.singh@intel.com Cc: igt-dev@lists.freedesktop.org, petri.latvala@intel.com List-ID: On Sun, Jan 10, 2021 at 04:51:53PM +0530, apoorva1.singh@intel.com wrote: > From: Apoorva Singh > > Added test and subtests description > > v2: Added descriptions for newly added subtests > > Signed-off-by: Apoorva Singh > Cc: Melkaveri, Arjun > Cc: Dec, Katarzyna > Cc: Petri Latvala > --- > tests/i915/i915_hangman.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/tests/i915/i915_hangman.c b/tests/i915/i915_hangman.c > index 72e4d8b8..d8004c55 100644 > --- a/tests/i915/i915_hangman.c > +++ b/tests/i915/i915_hangman.c > @@ -38,6 +38,8 @@ > #include "igt_debugfs.h" > #include "sw_sync.h" > > +IGT_TEST_DESCRIPTION("Tests the handling of hang scenarios"); > + > #ifndef I915_PARAM_CMD_PARSER_VERSION > #define I915_PARAM_CMD_PARSER_VERSION 28 > #endif > @@ -324,9 +326,11 @@ igt_main > igt_require(has_error_state(sysfs)); > } > > + igt_describe("Validates the error state after manually triggering a hang"); > igt_subtest("error-state-basic") > test_error_state_basic(); > > + igt_describe("For each engine, validates the error state after injecting a hanging batch"); > igt_subtest_with_dynamic("error-state-capture") { > __for_each_physical_engine(device, e) { > igt_dynamic_f("%s", e->name) > @@ -334,6 +338,7 @@ igt_main > } > } > > + igt_describe("Verify that other engines remain unaffected after an engine is hanged"); > igt_subtest_with_dynamic("engine-hang") { > int has_gpu_reset = 0; > struct drm_i915_getparam gp = { > @@ -352,6 +357,8 @@ igt_main > } > } > > + igt_describe("Verify that other engines remain unaffected after a hang with invalid cs" > + "is injected on an engine"); > igt_subtest_with_dynamic("engine-error") { > int has_gpu_reset = 0; > struct drm_i915_getparam gp = { > @@ -369,6 +376,7 @@ igt_main > } > } > > + igt_describe("Verify that execution of unterminated batch buffer triggers a hang"); > igt_subtest("hangcheck-unterminated") > hangcheck_unterminated(); LGTM :) Acked-by: Katarzyna Dec Kasia :) > > -- > 2.25.1 > _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev