Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14F32C433E0 for ; Fri, 26 Feb 2021 03:37:05 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9772E64EE3 for ; Fri, 26 Feb 2021 03:37:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9772E64EE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.90044.170265 (Exim 4.92) (envelope-from ) id 1lFTvy-0004WF-7X; Fri, 26 Feb 2021 03:36:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 90044.170265; Fri, 26 Feb 2021 03:36:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lFTvy-0004W8-4O; Fri, 26 Feb 2021 03:36:54 +0000 Received: by outflank-mailman (input) for mailman id 90044; Fri, 26 Feb 2021 03:36:53 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lFTvx-0004W3-D3 for xen-devel@lists.xenproject.org; Fri, 26 Feb 2021 03:36:53 +0000 Received: from mail-ot1-x32c.google.com (unknown [2607:f8b0:4864:20::32c]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 3b6c8a3e-a57e-4933-b36c-32aa2e14c796; Fri, 26 Feb 2021 03:36:52 +0000 (UTC) Received: by mail-ot1-x32c.google.com with SMTP id b16so7946029otq.1 for ; Thu, 25 Feb 2021 19:36:52 -0800 (PST) Received: from thewall (142-79-211-230.starry-inc.net. [142.79.211.230]) by smtp.gmail.com with ESMTPSA id k18sm1605251ots.24.2021.02.25.19.36.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Feb 2021 19:36:51 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b6c8a3e-a57e-4933-b36c-32aa2e14c796 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IqFdziwHDxVIOjGZX/oKUvNBbcd3HE80EMON7TdM10Q=; b=H4njjzxla+7jFyKNzQUp1uBAOvrWjqk9z1Neh9YzVlpWSJ9fU6sVHxkUac4FQZzPwH eosPqVotvN6xGC6eUuJc3ihqRTCoGMZ8zszqZpeTLOo+qjYf6KLtd65n7fxMYBYxtgw9 uFcXTatyQC9uSuLe9455APqCDW9F0cnZ62ANW4I/K0NsFppA3gG0INLxwzp8yQ+a7ldP RRCQGc8i27q3DYeqc5fqopW3OcDZXE20t3MqZ9EdN39/TV6uuT7fSYwSDJPxIsxO2fy9 JK6IcDPiJ+oB6X8+jhuQcfmzOcp979BwakKDZuf+W32tBZ8HAXfRjwAw9QzEBt6u1wPx +SGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IqFdziwHDxVIOjGZX/oKUvNBbcd3HE80EMON7TdM10Q=; b=tromzoaRz/uRjlWzwnpkT0wxQaoD/3wcRRx7o76KNj7CVVtGSuOSNLNH+SSYOTJScm VvIuDKPuNzmMK488E/NbkxA1atDRQG2Nn6vu5OP8wnAWz51oJzFq9JBM/TA0S6Y8aMmH /7Y00Zdyci6IaVAidvsPjpAZCdU9XYSO5qHKBHqDz3oMR6Nb0IPC6oWnoJYg4CaoKmNR XmcMgF1ZEWrXQQguNfMWKF0zZmAszT9NtKHPReXGvpiK09kbo5znsvsf5Ds50gex7rfb 7E5UKdK0/jLNvfdiHPwc43WAj1MOl16GsGHx925O1Vx/rBOCqsPpoRxUTgM7LhaJhNcG fhxw== X-Gm-Message-State: AOAM533NaLQAyv8k0NHpBtG35az+lTFNx5X8loVbw9y9JA9E6Bvse9dB WpVVixIYUFXF7l4HS+OR8jU= X-Google-Smtp-Source: ABdhPJx1yb77m+oOkROwInIy0TQylzhb9Rk5GTpsKXfWrN9GyeZLsgWiplBx1IwLg2srnPVvzKiL5Q== X-Received: by 2002:a05:6830:150c:: with SMTP id k12mr793866otp.104.1614310612287; Thu, 25 Feb 2021 19:36:52 -0800 (PST) Date: Thu, 25 Feb 2021 20:36:50 -0700 From: Connor Davis To: Jan Beulich Cc: Bobby Eshleman , Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH for-next 4/6] xen: Fix build when !CONFIG_GRANT_TABLE Message-ID: <20210226033650.ou6eqdu7lfmuuhtk@thewall> References: <259e6dce-7fc4-1f2e-49b6-61a047012953@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <259e6dce-7fc4-1f2e-49b6-61a047012953@suse.com> On Thu, Feb 25, 2021 at 04:53:23PM +0100, Jan Beulich wrote: > On 25.02.2021 16:24, Connor Davis wrote: > > --- a/xen/include/xen/grant_table.h > > +++ b/xen/include/xen/grant_table.h > > @@ -66,6 +66,8 @@ int gnttab_acquire_resource( > > > > #define opt_max_grant_frames 0 > > > > +struct grant_table {}; > > + > > static inline int grant_table_init(struct domain *d, > > int max_grant_frames, > > int max_maptrack_frames) > > You shouldn't actually declare a struct, all you need is to > move the forward decl further up in the file ahead of the > #ifdef. Thanks, will fix this in v2. Connor