From: Tom Rini Date: Wed, 3 Mar 2021 14:08:38 -0500 Subject: [PATCH 4/4] reset: Remove addr parameter from reset_cpu() In-Reply-To: <2d9ece4576e9ed07b8c8dd7a809ea565cc106317.1608045173.git.hws@denx.de> References: <2d9ece4576e9ed07b8c8dd7a809ea565cc106317.1608045173.git.hws@denx.de> Message-ID: <20210303190838.GM1310@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Dec 15, 2020 at 04:47:52PM +0100, Harald Seiler wrote: > Historically, the reset_cpu() function had an `addr` parameter which was > meant to pass in an address of the reset vector location, where the CPU > should reset to. This feature is no longer used anywhere in U-Boot as > all reset_cpu() implementations now ignore the passed value. Generic > code has been added which always calls reset_cpu() with `0` which means > this feature can no longer be used easily anyway. > > Over time, many implementations seem to have "misunderstood" the > existence of this parameter as a way to customize/parameterize the reset > (e.g. COLD vs WARM resets). As this is not properly supported, the > code will almost always not do what it is intended to (because all > call-sites just call reset_cpu() with 0). > > To avoid confusion and to clean up the codebase from unused left-overs > of the past, remove the `addr` parameter entirely. Code which intends > to support different kinds of resets should be rewritten as a sysreset > driver instead. > > This transformation was done with the following coccinelle patch: > > @@ > expression argvalue; > @@ > - reset_cpu(argvalue) > + reset_cpu() > > @@ > identifier argname; > type argtype; > @@ > - reset_cpu(argtype argname) > + reset_cpu(void) > { ... } > > Signed-off-by: Harald Seiler > Reviewed-by: Simon Glass Applied to u-boot/next, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: