Received: by 2002:a19:6d5:0:0:0:0:0 with SMTP id 204csp6360121lfg; Thu, 4 Mar 2021 08:05:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJwl6hQRlxVUvUch+XmCs9Wlh4P8oLCc4wPUFc9tJagdiMY9sn7FzZaTNPBzCcH61HfWuPu5 X-Received: by 2002:a05:6e02:1aa5:: with SMTP id l5mr4360179ilv.278.1614873954875; Thu, 04 Mar 2021 08:05:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614873954; cv=none; d=google.com; s=arc-20160816; b=TbaN0+xnDPrtK+4Nnfe6H3s9hHchvVkaZ2kMiOvU09riEeCY9H63PJWRBwYDHx6eS8 KC/IJAmjS2Dpq6pNLB6GQCFBnBkdNPumAysQ+EtGQFWwuTWGqbZhDh/fFegTY4GDKwdk VO6EUIx0US1PPBVTT0AFPDIL/mZN4Mk8VX8us8rA50ZHUDTAt5N+1T9yl//yPdVa/wVi 0+k/SpWjf04oLjCbmXKY8vcCDzCXxxYf+bDWriCR2VDD0kXD/AFO2HCigtIkH1KXlyts 9l7o3TseNYNi8F0ARFIlBGVNjiD73V036JqbbwyG6RcsnlZspsOh6vsz4ktEalgHISY0 0uyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:organization:references:in-reply-to:message-id:subject :to:from:date:dkim-signature; bh=qY1DlRsij3cTrbhkPV5OgPfiBwcs7doGA1y8LRt1/t0=; b=b/nDsROkyNMrMv5py4RJlBnCqBzg0md+hc9SXVrClAODy+rH1ly+nVKpJcTz+akJN/ wLz7rGBbnoKWpLRXQ3xs67CjZ5Gjm3oCE/zdFrrDljbVkLrBH/IiiL6N59Q69yQF1CkO x7pR0pOYHNk3ch9o7OvQoc+OI5uojCNHBqylnYRgPTEzSb6OTz8gL41TmtspvIhKukMu SUj4F3OlbEKdYhsxXLvFpFO6aY4t6GG6f1igqF3aUL3OKUThYaDIWRS5kNccu2JVur+x 5k9ULAEZuy1IaycreN4c74cE9MD1RIW3w2WOIscXBCbmgnpV4Zjv7jhmMPVv+p38jC59 RWXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=dKy2V+R9; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id b13si26055756ilv.50.2021.03.04.08.05.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Mar 2021 08:05:54 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=dKy2V+R9; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:49926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHqU6-0002zC-6G for alex.bennee@linaro.org; Thu, 04 Mar 2021 11:05:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55260) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHqTv-0002wp-H6 for qemu-arm@nongnu.org; Thu, 04 Mar 2021 11:05:43 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:59822) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lHqTr-00016N-8r for qemu-arm@nongnu.org; Thu, 04 Mar 2021 11:05:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614873938; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qY1DlRsij3cTrbhkPV5OgPfiBwcs7doGA1y8LRt1/t0=; b=dKy2V+R9kAFBizb9Di6FdXSbEzcsazFozefRcJ/RAYJ0wd959h6N3iTH3GzBMq7m6qlNrk 6gNFC3GNP3RNFJSEWnbtD6KpsCgOLmvSFyzbfnO/YwGIXeNnJw4ceuBTIFROYgxoSr6gQn Qp+fY68OOjFEQdIALUMR0WTxQElc50E= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-124-no-0lgYdN2q0sICV6b5Euw-1; Thu, 04 Mar 2021 11:05:36 -0500 X-MC-Unique: no-0lgYdN2q0sICV6b5Euw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B14E38030D1; Thu, 4 Mar 2021 16:05:33 +0000 (UTC) Received: from gondolin (ovpn-114-163.ams2.redhat.com [10.36.114.163]) by smtp.corp.redhat.com (Postfix) with ESMTP id 305F6179B3; Thu, 4 Mar 2021 16:05:24 +0000 (UTC) Date: Thu, 4 Mar 2021 17:05:21 +0100 From: Cornelia Huck To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Subject: Re: [PATCH 02/19] target/s390x/kvm: Simplify debug code Message-ID: <20210304170521.78c61998.cohuck@redhat.com> In-Reply-To: <20210303182219.1631042-3-philmd@redhat.com> References: <20210303182219.1631042-1-philmd@redhat.com> <20210303182219.1631042-3-philmd@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Received-SPF: pass client-ip=170.10.133.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , kvm@vger.kernel.org, David Hildenbrand , qemu-devel@nongnu.org, haxm-team@intel.com, Colin Xu , Halil Pasic , Christian Borntraeger , Claudio Fontana , Marcel Apfelbaum , Thomas Huth , Eduardo Habkost , Richard Henderson , Greg Kurz , Cameron Esfahani , Roman Bolshakov , qemu-arm@nongnu.org, Sunil Muthuswamy , David Gibson , Marcelo Tosatti , qemu-s390x@nongnu.org, qemu-ppc@nongnu.org, Wenchao Wang , Paolo Bonzini Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: /sE+0ni7clnd On Wed, 3 Mar 2021 19:22:02 +0100 Philippe Mathieu-Daud=C3=A9 wrote: > We already have the 'run' variable holding 'cs->kvm_run' value. >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > target/s390x/kvm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c > index 7a892d663df..73f816a7222 100644 > --- a/target/s390x/kvm.c > +++ b/target/s390x/kvm.c > @@ -1785,8 +1785,7 @@ static int handle_intercept(S390CPU *cpu) > int icpt_code =3D run->s390_sieic.icptcode; > int r =3D 0; > =20 > - DPRINTF("intercept: 0x%x (at 0x%lx)\n", icpt_code, > - (long)cs->kvm_run->psw_addr); > + DPRINTF("intercept: 0x%x (at 0x%lx)\n", icpt_code, (long)run->psw_ad= dr); > switch (icpt_code) { > case ICPT_INSTRUCTION: > case ICPT_PV_INSTR: Thanks, queued this one to s390-next.