Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A8C6C433E0 for ; Mon, 8 Mar 2021 16:47:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E43F265227 for ; Mon, 8 Mar 2021 16:47:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230327AbhCHQqm (ORCPT ); Mon, 8 Mar 2021 11:46:42 -0500 Received: from mx2.suse.de ([195.135.220.15]:53764 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230144AbhCHQqX (ORCPT ); Mon, 8 Mar 2021 11:46:23 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 11250AE05; Mon, 8 Mar 2021 16:46:22 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 35D35DA81B; Mon, 8 Mar 2021 17:44:24 +0100 (CET) Date: Mon, 8 Mar 2021 17:44:24 +0100 From: David Sterba To: Qu Wenruo Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH v2 1/2] btrfs: use a dedicated variable for qgroup released data rsv for insert_prealloc_file_extent() Message-ID: <20210308164424.GD7604@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Qu Wenruo , linux-btrfs@vger.kernel.org References: <20210303104152.105877-1-wqu@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210303104152.105877-1-wqu@suse.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Wed, Mar 03, 2021 at 06:41:51PM +0800, Qu Wenruo wrote: > There is a piece of weird code in insert_prealloc_file_extent(), which > looks like: > > ret = btrfs_qgroup_release_data(inode, file_offset, len); > if (ret < 0) > return ERR_PTR(ret); > if (trans) { > ret = insert_reserved_file_extent(trans, inode, > file_offset, &stack_fi, > true, ret); > ... > } > extent_info.is_new_extent = true; > extent_info.qgroup_reserved = ret; > ... > > Note how the variable @ret is abused here, and if anyone is adding code > just after btrfs_qgroup_release_data() call, it's super easy to > overwrite the @ret and cause tons of qgroup related bugs. > > Fix such abuse by introducing new variable @qgroup_released, so that we > won't reuse the existing variable @ret. > > Signed-off-by: Qu Wenruo Added to misc-next, thanks.