IronPort-SDR: GjEfadTcBpJQTJyChi7xpR3yDx97Ijk39zZsWjfdp8hLUps3gQsqz8ZynzHM35VtqaUWNba0dR
 LVmsq0NverNA==
IronPort-SDR: iv+HvTurjOnEkDLuhu8g2pBp4rv9JtBbVxD/AQB5x/EDymNpe9Q1GjpFxkl0iT2HQz07X9zoQJ
 mxiNKD+QJn7w==
Date:   Tue, 23 Mar 2021 16:21:54 +0200
From:   Mika Westerberg <mika.westerberg@linux.intel.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Andreas Noever <andreas.noever@gmail.com>,
        Michael Jamet <michael.jamet@intel.com>,
        Yehezkel Bernat <YehezkelShB@gmail.com>,
        Richard Weinberger <richard@nod.at>, linux-usb@vger.kernel.org,
        linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@inria.fr>
Subject: Re: [PATCH] thunderbolt: unlock on error path in tb_domain_add()
Message-ID: <20210323142154.GW2542@lahna.fi.intel.com>
References: <YFnqyqDzSHenVN9O@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YFnqyqDzSHenVN9O@mwanda>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Mar 23, 2021 at 04:19:06PM +0300, Dan Carpenter wrote:
> We accidentally deleted this unlock on the error path.  Undelete it.
> 
> Fixes: 7f0a34d7900b ("thunderbolt: Decrease control channel timeout for software connection manager")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Julia also reported this yesterday and I was just about to send a patch
that fixes it too :) Applied this one now, thanks!

> ---
>  drivers/thunderbolt/domain.c | 1 +
>  1 files changed, 1 insertions(+), 0 deletion(-)
> 
> diff --git a/drivers/thunderbolt/domain.c b/drivers/thunderbolt/domain.c
> index a7d83eec3d15..98f4056f89ff 100644
> --- a/drivers/thunderbolt/domain.c
> +++ b/drivers/thunderbolt/domain.c
> @@ -493,6 +493,7 @@ int tb_domain_add(struct tb *tb)
>  	device_del(&tb->dev);
>  err_ctl_stop:
>  	tb_ctl_stop(tb->ctl);
> +	mutex_unlock(&tb->lock);
>  
>  	return ret;
>  }