Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF12CC433ED for ; Wed, 31 Mar 2021 17:50:47 +0000 (UTC) Received: from mother.openwall.net (mother.openwall.net [195.42.179.200]) by mail.kernel.org (Postfix) with SMTP id 9538960FE3 for ; Wed, 31 Mar 2021 17:50:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9538960FE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernel-hardening-return-21098-kernel-hardening=archiver.kernel.org@lists.openwall.com Received: (qmail 30029 invoked by uid 550); 31 Mar 2021 17:50:39 -0000 Mailing-List: contact kernel-hardening-help@lists.openwall.com; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-ID: Received: (qmail 30009 invoked from network); 31 Mar 2021 17:50:39 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=fwPCJ0ln7XiN1Mgyh62R5lYieMyObsTHbG0RZrvRPwE=; b=OefcY/8KfUGCvJz0PF4h17nCzx8f0uaNcos4bTKX5FJPltpnno8jfg/iqcQ8GisI2O sHzAFk2S5lMRyMS6dPjFOX+nxDw6q0h8Yq+yTa5WONZV88VtK8jwKjKAtVpgtoDF0Mxi tENIdh63kVi4PxUTOmbdWQya7sFMLfNIU5yvU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=fwPCJ0ln7XiN1Mgyh62R5lYieMyObsTHbG0RZrvRPwE=; b=bRN8ErqXgHz1TWk9mhLDZgWURT8RzwS3K1LzgGCNr3CfR0iimFrkNfnAbcBRS6S07W kQDy865xqD8GMBGfcfJbHexcMlVuT5ZXOKoVKi986iHNxaAnIseyG+AsameXd/0ByfXl 4BKZSzgNXQg2OXiC64Z1ULgz0x6D/uZXH91Nm8uA4P2/5pP+9kx21Lj5nUmcu5xAoGN7 yLYzbe0gNge13lKv2+r3mE1oYj7wD/IAFrDN/Yar9CHIsWqqTRid1gCxPB8vitd/S7aN x16g8ydkQLY15icA1v+qEsKtAZm70Ng04WVe4Qf3etJFO7vhrhagPjHiVisIC5M4j5FS lQjg== X-Gm-Message-State: AOAM530vRf7PZArjaFRd5i8A0MoeONe5wErhtTBL4Sb7/5sr1iOcrUXe PXqt24k9NTY2QlQ/xb3DUe4mLg== X-Google-Smtp-Source: ABdhPJxLFRk32S5JAWcjXEQfVNlU3MgfcnfPT07dz6zmQQRJYgHlVguRXJRY5mE9rC3ZM2LThifa9g== X-Received: by 2002:a17:90a:c918:: with SMTP id v24mr4631376pjt.182.1617213026927; Wed, 31 Mar 2021 10:50:26 -0700 (PDT) Date: Wed, 31 Mar 2021 10:50:25 -0700 From: Kees Cook To: =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= Cc: Jann Horn , Al Viro , Andrew Morton , Andy Lutomirski , Anton Ivanov , Arnd Bergmann , Casey Schaufler , David Howells , Jeff Dike , Jonathan Corbet , Michael Kerrisk , Richard Weinberger , Shuah Khan , Vincent Dagonneau , kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-security-module@vger.kernel.org, x86@kernel.org, =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , James Morris , "Serge E . Hallyn" Subject: Re: [PATCH v31 07/12] landlock: Support filesystem access-control Message-ID: <202103311048.3D4D927961@keescook> References: <20210324191520.125779-1-mic@digikod.net> <20210324191520.125779-8-mic@digikod.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Mar 31, 2021 at 07:33:50PM +0200, Mickaël Salaün wrote: > Jann, Kees, are you OK with this patch and the next one? I don't feel qualified to say it's using the VFS correctly, but given the extensive testing via gcov and syzkaller, I'm comfortable with it landing. I defer to James. :) -Kees -- Kees Cook