Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57223C433ED for ; Fri, 2 Apr 2021 01:10:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 22CB6610C7 for ; Fri, 2 Apr 2021 01:10:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234043AbhDBBKr convert rfc822-to-8bit (ORCPT ); Thu, 1 Apr 2021 21:10:47 -0400 Received: from james.kirk.hungrycats.org ([174.142.39.145]:32792 "EHLO james.kirk.hungrycats.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231179AbhDBBKq (ORCPT ); Thu, 1 Apr 2021 21:10:46 -0400 Received: by james.kirk.hungrycats.org (Postfix, from userid 1002) id C7D039F8B59; Thu, 1 Apr 2021 21:10:45 -0400 (EDT) Date: Thu, 1 Apr 2021 21:10:45 -0400 From: Zygo Blaxell To: Markus Schaaf Cc: Chris Murphy , Btrfs BTRFS Subject: Re: Any ideas what this warnings are about? Message-ID: <20210402011045.GX32440@hungrycats.org> References: <43acc426-d683-d1b6-729d-c6bc4a2fff4d@gmail.com> <20210331015827.GV32440@hungrycats.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Thu, Apr 01, 2021 at 12:20:51PM +0200, Markus Schaaf wrote: > Am 31.03.21 um 22:20 schrieb Chris Murphy: > > > Flushoncommit is safe but noisy in dmesg, and can make things slow it > > just depends on the workload. And discard=async is also considered > > safe, though relatively new. The only way to know for sure is disable > > it, and only it, run for some time period to establish "normative" > > behavior, and then enable only this option and see if behavior changes > > from the baseline > > [...] > > Thank you for your detailed explanation. I was trying flushoncommit for > better crash consistency. But this was based on theory, not experience. flushoncommit does give better crash consistency--I've been using it for years for that reason. I have to patch the kernel to silence the warning though. > BR