From: Philipp Zabel Date: Fri, 2 Apr 2021 14:01:37 +0200 Subject: [PATCH v2 2/3] drivers: char: ipmi: Add Aspeed SSIF BMC driver In-Reply-To: <20210330141029.20412-3-quan@os.amperecomputing.com> References: <20210330141029.20412-1-quan@os.amperecomputing.com> <20210330141029.20412-3-quan@os.amperecomputing.com> Message-ID: <20210402120137.GA26002@pengutronix.de> List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi Quan, On Tue, Mar 30, 2021 at 09:10:28PM +0700, Quan Nguyen wrote: > The SMBus system interface (SSIF) IPMI BMC driver can be used to perform > in-band IPMI communication with their host in management (BMC) side. > > This commits adds support specifically for Aspeed AST2500 which commonly > used as Board Management Controllers. > > Signed-off-by: Quan Nguyen > --- [...] > diff --git a/drivers/char/ipmi/ssif_bmc_aspeed.c b/drivers/char/ipmi/ssif_bmc_aspeed.c > new file mode 100644 > index 000000000000..a563fcff5acc > --- /dev/null > +++ b/drivers/char/ipmi/ssif_bmc_aspeed.c > @@ -0,0 +1,132 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * The driver for BMC side of Aspeed SSIF interface > + * > + * Copyright (c) 2021, Ampere Computing LLC > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of > + * the License, or (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program. If not, see . > + */ > + > +#include > +#include > +#include > +#include > +#include > + > +#include "ssif_bmc.h" > + > +struct aspeed_i2c_bus { > + struct i2c_adapter adap; > + struct device *dev; This device handle is apparently unused. > + void __iomem *base; > + struct reset_control *rst; This reset control handle is unused as well. > + /* Synchronizes I/O mem access to base. */ > + spinlock_t lock; > +}; regards Philipp