Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E4ACC433ED for ; Thu, 8 Apr 2021 17:35:52 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82234610E5 for ; Thu, 8 Apr 2021 17:35:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82234610E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VqPFWiN7YKsIQjHjCzztePFc+d1FVm/+CtltOIMxpFI=; b=lfKMd56tWq8bNvcNbprxO/Gfw yqnaZuyRB4EOjgPkQ/w0Ff0krQPazVnoOuqgq3vcDKHlYPEkajgXtk2WvRN6i9hPq1agB5p+dCVpJ zjU2K1Fs3b3iAc52aSSuL9aC0vmGDcS7QU2kx+UV2InxVXcwnxE59adokVqCVRN+MUUFRtnJTr263 V4TFUs73s1bWNeB3lubAP7WMmLbMuHmZzQEpdUow/UGCDw0CrcHE/xrg0WeSovmZqF4ZfiDoDcCoR dp2XpnJQTqQFZSDKUltFSNnmALKCTFlWmIFhapF94tG/U2Rf3pzgfgSdd7jZSGf9hbbw+stRfx514 2CqcbOUKg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUYXN-008nET-Pd; Thu, 08 Apr 2021 17:33:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUYWw-008nAz-1H for linux-arm-kernel@lists.infradead.org; Thu, 08 Apr 2021 17:33:38 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 89906610D0; Thu, 8 Apr 2021 17:33:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617903199; bh=lRQar/s16nu1W0vs6H3B5FNZmPius8SGNAGgo7SjcN0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LUsInQNHDM0BKvXt1PmNMPFoEtc7vLVuh25riR0MZDVZE4zD8hYtbKjgGH0pPy4Lh m/RrQsTDwvCx8pO+KPNvtTJXke+uvtDasV8n9knfqY6gYasA7bvkBkgaJBnGPqGj/5 AA59MufpRV2ZsPjggIKWpTkBqwm64P/rquf//CpKBlce3N463sQDOWSc7aeG9yQ7bF vb/rzko88lfSKBOKCvFOL6GMwIIih7BS93dz5MaKbFFJYBBoMC9szZ6SR+Icbm0mAI NB/YsEhxjHloKl1nvI6O2PbDSiggnEp/7nxDB5js2WiJdnGYWH+oEqs9ocpFlm6rm4 PkHeb4mgqoeZA== Date: Thu, 8 Apr 2021 18:33:00 +0100 From: Mark Brown To: Marc Zyngier Cc: Catalin Marinas , Will Deacon , Mark Rutland , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 4/4] arm64: Document values for system registers on boot Message-ID: <20210408173300.GR4516@sirena.org.uk> References: <20210401180942.35815-1-broonie@kernel.org> <20210401180942.35815-5-broonie@kernel.org> <87pmz4ofxo.wl-maz@kernel.org> MIME-Version: 1.0 In-Reply-To: <87pmz4ofxo.wl-maz@kernel.org> X-Cookie: Editing is a rewording activity. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210408_183322_842046_E56B3CD8 X-CRM114-Status: GOOD ( 22.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2239571137572631667==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2239571137572631667== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="l2C7pJE7HE4aLL3l" Content-Disposition: inline --l2C7pJE7HE4aLL3l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 08, 2021 at 06:16:03PM +0100, Marc Zyngier wrote: > Mark Brown wrote: > > Specify that where the architecture provides a reset value that value > > must be used. > > level where the kernel image will be entered must be initialised by > > software at a higher exception level to prevent execution in an UNKNOWN > > - state. > > + state. Where these architected system registers have reset values > > + specified by the architecture they must be initialised to those values > > + unless specified more specifically. > Is that always enforceable? Is that even desirable? I'm not convinced on either front frankly, like I said in the cover letter I was worrying that it is too strict a requirement. I couldn't think of a better/more appropriate wording and figured it might start a discussion. > Take for example ICC_SRE_EL2.SRE. The reset value for that bit is > 0. But it is extremely likely that the FW has set this bit to 1 in > order to be able to use interrupts with the sysreg interface. However, > as outlined in the GIC spec: > > If software changes this bit from 1 to 0, the results are UNPREDICTABLE. > That definitely means it's unenforcable without an explict override for that case, having now seen that case I'm sure there's others. > We could go and specify this one, but I fear there is a lot of things > we'd have to make explicit... Yeah, that's pushing me towards dropping this patch. We could add a general statement recommending that people use the defaults without actually requiring it but that's just vague and unenforcable instead of strict and unimplementable which isn't particularly better. If we're going to have to keep updating the document it's going to be less effort all round to just update for cases we can't handle in code rather than keep on adding exceptions and require firmware to reset lots of stuff we don't *really* have strict requirements for. --l2C7pJE7HE4aLL3l Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmBvPkwACgkQJNaLcl1U h9CVBwgAhRHSm09H4Q6fXWRmtL614GLJdq3cAl3qgFTvlRIlo+SV670XvAJpdPKC BWHiI8mTrszB5k3z9FB13mU3ys2t7DByVOO4oQLZRC1WSz44C1/KJwLZaivgYRzA ekh7kP52y6cVuPs26n8QVzWE5cpygUmLw9qhuVg0pB84/qQQEj5Cer4k0nxiZKJb z8VrUbi4yh36lqo+uKuXNar4QByAvKcthcD85fD82KUP6HAaBQkJnLgNs5r8j03y IssAsD9S48M0/PFvBvYZk1wfO6YmZ+xn8yjRPDorrDsQrQI+JTCG2aSarei9RLDm 7ei6s8bcp0SBllIbDV76VXHiH+i+og== =hMPE -----END PGP SIGNATURE----- --l2C7pJE7HE4aLL3l-- --===============2239571137572631667== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2239571137572631667==--