IronPort-SDR: WXywM2oe2wXHdYU5zp5LShBeLPIxEpxzFay14LDnKbSBYhmjSyjO/ebFdqtwbs465hCS+VRehJ
 4GGVti9Xk/gw==
IronPort-SDR: dYc3YdhqPPVN9UNd/ED6G6EefHle5UX7sXVTk1T/MevybQOBlkA3Up/QlXPoxYTwv3hZWeoQfa
 5MsDJ5FV2oig==
Date:   Fri, 9 Apr 2021 12:33:35 +0300
From:   Mika Westerberg <mika.westerberg@linux.intel.com>
To:     linux-usb@vger.kernel.org
Cc:     Michael Jamet <michael.jamet@intel.com>,
        Yehezkel Bernat <YehezkelShB@gmail.com>,
        Andreas Noever <andreas.noever@gmail.com>,
        Lukas Wunner <lukas@wunner.de>,
        Mario Limonciello <mario.limonciello@dell.com>,
        Christian Kellner <christian@kellner.me>,
        Benson Leung <bleung@google.com>,
        Prashant Malani <pmalani@google.com>,
        Diego Rivas <diegorivas@google.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v3 0/3] thunderbolt: Expose details about tunneling
Message-ID: <20210409093335.GO2542@lahna.fi.intel.com>
References: <20210329074150.62622-1-mika.westerberg@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210329074150.62622-1-mika.westerberg@linux.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Mon, Mar 29, 2021 at 10:41:47AM +0300, Mika Westerberg wrote:
> Hello there,
> 
> There has been ask if we can expose more details about the connected
> devices and the tunneling to userspace, so it can then provide more
> detailed information to the user.
> 
> First we add uevent details for each device (USB4 router) that adds
> USB4_TYPE=host|device|hub and USB4_VERSION=1.0 (if the device actually is
> USB4). The host|device|hub definitions follow the USB4 spec.
> 
> Then for each device router we expose two new attributes: "usb3" and "dp"
> that if present mean that the device has corresponding adapter (USB 3.x
> upstream adapter and DP OUT adapter). The contents of the attributes then
> hold number of tunnels ending to this router. So if USB 3.x is tunneled
> "usb3" reads 1. Since there can be multiple DP OUT adaptes the "dp"
> attribute holds number of DP tunnels ending to this router. For PCIe
> tunneling the "authorized" attribute works the same way.
> 
> Previous versions can be found:
> 
>   v2: https://lore.kernel.org/linux-usb/20210323145701.86161-1-mika.westerberg@linux.intel.com/
>   v1: https://lore.kernel.org/linux-usb/20210309134818.63118-1-mika.westerberg@linux.intel.com/
> 
> Changes from v2:
> 
>   * Added missing sysfs_emit()
> 
> Changes from v1:
> 
>   * Added Greg's Reviewed-by tags for patch 1 and 2
>   * Use sysfs_emit()
>   * Drop the locking in the new attributes
>   * Drop the kobject_uevent()
> 
> Mika Westerberg (3):
>   thunderbolt: Add details to router uevent
>   thunderbolt: Hide authorized attribute if router does not support PCIe tunnels
>   thunderbolt: Expose more details about USB 3.x and DisplayPort tunnels

Applied the first two patches to thunderbolt.git/next. I'm dropping the
last one for now. We can revisit it later if really needed.