Content-Type: multipart/mixed; boundary="===============1383359241306477238==" MIME-Version: 1.0 From: kernel test robot To: kbuild-all@lists.01.org Subject: [PATCH] scsi: iscsi: fix boolreturn.cocci warnings Date: Wed, 14 Apr 2021 12:17:11 +0800 Message-ID: <20210414041710.GA57795@73e32e2373e0> In-Reply-To: <20210413230648.5593-3-michael.christie@oracle.com> List-Id: --===============1383359241306477238== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: kernel test robot drivers/scsi/libiscsi.c:1737:11-12: WARNING: return of 0/1 in function 'isc= si_eh_running' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci CC: Mike Christie Reported-by: kernel test robot Signed-off-by: kernel test robot --- url: https://github.com/0day-ci/linux/commits/Mike-Christie/scsi-libicsi= -and-qedi-tmf-fixes/20210414-072516 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-ne= xt libiscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/scsi/libiscsi.c +++ b/drivers/scsi/libiscsi.c @@ -1734,7 +1734,7 @@ static bool iscsi_eh_running(struct iscs switch (ISCSI_TM_FUNC_VALUE(tmf)) { case ISCSI_TM_FUNC_LOGICAL_UNIT_RESET: if (sc->device->lun !=3D scsilun_to_int(&tmf->lun)) - return 0; + return false; = ISCSI_DBG_EH(conn->session, "Requeue cmd sent during LU RESET processing.\n"); --===============1383359241306477238==--