Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 809E3C433ED for ; Fri, 23 Apr 2021 02:56:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C89461445 for ; Fri, 23 Apr 2021 02:56:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236407AbhDWC45 (ORCPT ); Thu, 22 Apr 2021 22:56:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229600AbhDWC45 (ORCPT ); Thu, 22 Apr 2021 22:56:57 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F1E5C06174A for ; Thu, 22 Apr 2021 19:56:20 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id f6-20020a17090a6546b029015088cf4a1eso477093pjs.2 for ; Thu, 22 Apr 2021 19:56:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20150623.gappssmtp.com; s=20150623; h=subject:date:message-id:mime-version:content-transfer-encoding:cc :from:to; bh=UtQhf0AMGUbWT9+v2yf9kUp3nmfSVtohRhb6bLrpe3w=; b=g//+B6F+TXQhW76hcLtZtiPnhUoG4OKOoeXsITq/NnITlSIoZ/PSEkyiJBwjx1pzOJ b/bru8FIC5SXz4K1SStTS1wrvbNgZ9GOW48lVyUxKaO+1SVehz0ICVVFzTklw331xhjG SYZVHe9vBOMA2SzGyusWqV5V0DOepdOP26d3+HgKF1B371z9qMc5+XH2CI/ISZW9rJhO LcUJnRg5wcq4VBdUDV/WkD8UDrOWLLvUBHOVOmY55jzheZBUoqDnqhxj87IJ3d3H14QU oD8WIYr7Ch8+u757kgjJ9rVTih+G9Y98n+xTjNje/DpNFrFV1FvtKilSaqX+Nf1sBZG+ os/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:date:message-id:mime-version :content-transfer-encoding:cc:from:to; bh=UtQhf0AMGUbWT9+v2yf9kUp3nmfSVtohRhb6bLrpe3w=; b=Z8aAS8HhNLEgF+/g9sCYX8pzbV6+Yu7j7UynxuJBGolwan8pxeDMSN3V01gCd85+Yd O/CdY5/zPA61P/1ggGGpEcmU+9SZr9VVXefy05gJbooPzNdcqoWVLt76e/FPSDzjdDBC t8C9jCW0sHaIbncaB2IXVGcTF8SJdM3Yo3kS9P1liyMaYs61/Dxl2n1zxzNIYZ+5Kife zzjGOJld/id+KvW4aKNcqCgckv6aVlviK2GSmRa8nxVUd4vHTIiYoaRnNJYGDbzmtdrV vBJBI4a0vQ9wnuQqVKCoWZGWEGiz0iGEejYSRHYj8ad0WMBiTL9LuNPoIZZKaMICDP40 DgyQ== X-Gm-Message-State: AOAM530ahRaY9ZAWGgW93/Duijox8DQBgpxoGxMwFYbxF4zIcQWF7Itc T479fBv6MCclCbssVMptRhEsTVioR9NWKw== X-Google-Smtp-Source: ABdhPJwUbOVgaL9jeXHuyFS1nq5rKBtjrsM1C9sCYcWtBQPflZeSEQ9adYi/u2sQZXINu1KuHSZoBA== X-Received: by 2002:a17:90a:9a85:: with SMTP id e5mr3107773pjp.201.1619146579609; Thu, 22 Apr 2021 19:56:19 -0700 (PDT) Received: from localhost (76-210-143-223.lightspeed.sntcca.sbcglobal.net. [76.210.143.223]) by smtp.gmail.com with ESMTPSA id a4sm3217271pff.140.2021.04.22.19.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Apr 2021 19:56:19 -0700 (PDT) Subject: [PATCH] asm-generic: Remove asm/setup.h from the UABI. Date: Thu, 22 Apr 2021 19:55:45 -0700 Message-Id: <20210423025545.313965-1-palmer@dabbelt.com> X-Mailer: git-send-email 2.31.1.498.g6c1eba8ee3d-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Palmer Dabbelt From: Palmer Dabbelt To: Arnd Bergmann Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org From: Palmer Dabbelt I honestly have no idea if this is sane. This all came up in the context of increasing COMMAND_LINE_SIZE in the RISC-V port. In theory that's a UABI break, as COMMAND_LINE_SIZE is the maximum length of /proc/cmdline and userspace could staticly rely on that to be correct. Usually I wouldn't mess around with changing this sort of thing, but PowerPC increased it with a5980d064fe2 ("powerpc: Bump COMMAND_LINE_SIZE to 2048"). There are also a handful of examples of COMMAND_LINE_SIZE increasing, but they're from before the UAPI split so I'm not quite sure what that means: e5a6a1c90948 ("powerpc: derive COMMAND_LINE_SIZE from asm-generic"), 684d2fd48e71 ("[S390] kernel: Append scpdata to kernel boot command line"), 22242681cff5 ("MIPS: Extend COMMAND_LINE_SIZE"), and 2b74b85693c7 ("sh: Derive COMMAND_LINE_SIZE from asm-generic/setup.h."). It seems to me like COMMAND_LINE_SIZE really just shouldn't have been part of the UABI to begin with, and userspace should be able to handle /proc/cmdline of whatever length it turns out to be. I don't see any references to COMMAND_LINE_SIZE anywhere but Linux via a quick Google search, but that's not really enough to consider it unused on my end. I couldn't think of a better way to ask about this then just sending the patch. Signed-off-by: Palmer Dabbelt --- include/{uapi => }/asm-generic/setup.h | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename include/{uapi => }/asm-generic/setup.h (100%) diff --git a/include/uapi/asm-generic/setup.h b/include/asm-generic/setup.h similarity index 100% rename from include/uapi/asm-generic/setup.h rename to include/asm-generic/setup.h -- 2.31.1.498.g6c1eba8ee3d-goog