Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D83C71 for ; Mon, 10 May 2021 13:53:42 +0000 (UTC) Received: by mail-wm1-f50.google.com with SMTP id o127so9235187wmo.4 for ; Mon, 10 May 2021 06:53:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KRbn9Co6BAj/ELHOTzhIdqY0Fo6rGq0pnb6CnZ+fuLw=; b=Co8E1ItR1mt8bRNskveWoJzDVvks2uOIGa6FImnYO90p6S1BcBIk4yghrUqBSWMGph Fm1Fn0AK0gXmTHwf1OMLglsSQudJ/Y3j23XThvP1f0YRgCdtUq3wODfy0e5PnAxiyQWQ tP8a2TVFUgrtrPjMu45cuJiwK1LhCeQpfAWl1OoJ3CSTbxp2aBSUMs0mVY1yMGW0CS54 8NFlCi3gI4uwpUsOqcyQgpyn54ag3H5TrGy03hqGSLxmkPvmYvkv7JllY2l4d+dSHOCO uaPr4Me4cOh4ziwYm94jc2/J53IG7L/5jZOY/SNs2oHjEPjdnWLZZv7PtQVq5YEZPZEt ABpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KRbn9Co6BAj/ELHOTzhIdqY0Fo6rGq0pnb6CnZ+fuLw=; b=mYyGBYUcaCGbUo6equA+1m8Sggu3nsuoYCxd0K8h9yDqZoe5zvrKWZvlJ45XMaW4Vn paC8rkjSGikzakm7FlwDZjPr5h2oraXPV9EKeJAHPjlJeKNnPlmH+YbJBpwsDtpLQunn Yt//q09Bvug1PUHYC/OmWUCrE7LSLsrpiWqpO/Qgxk5me+HPzhr12ICND8UdocyzD0xW MdEmDLlkStwDZiKyBkE3IRItMTo3+Mfi9vmo+OfRCY6iMzZpwmN3g5zaCMDqsr8tVRJy mbWGbxwLRa0WrvDBJDe7qmFIWYrr0wDinqM9VntnU6q/LOnfBHqS04BXdRrOEXSYaSg8 T+lA== X-Gm-Message-State: AOAM531cv726ZDwSmzL1iMqSpe7+egl6cJWMua8nX+kb4odxOLfgOrSu Rt6ttAjajXdVUgcsU6h3oOs= X-Google-Smtp-Source: ABdhPJxKFSRfiuFi6EOtBi3OxWRKn8G4M/c+HNXcTzMzwJbsEJBaUftnNnJy+KMZ63v0bUD7ov3eUQ== X-Received: by 2002:a05:600c:3388:: with SMTP id o8mr37316393wmp.101.1620654821148; Mon, 10 May 2021 06:53:41 -0700 (PDT) Received: from agape.jhs ([5.171.73.3]) by smtp.gmail.com with ESMTPSA id 3sm19797790wms.30.2021.05.10.06.53.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 May 2021 06:53:40 -0700 (PDT) Date: Mon, 10 May 2021 15:53:38 +0200 From: Fabio Aiuto To: David Laight Cc: "gregkh@linuxfoundation.org" , "linux-staging@lists.linux.dev" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 1/2] staging: rtl8723bs: replace private CRC-32 routines with in-kernel ones Message-ID: <20210510135338.GC4434@agape.jhs> References: <29938747c82e4cf1837be5f1cdb803b7@AcuMS.aculab.com> X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <29938747c82e4cf1837be5f1cdb803b7@AcuMS.aculab.com> User-Agent: Mutt/1.10.1 (2018-07-13) Hello David, On Mon, May 10, 2021 at 01:38:49PM +0000, David Laight wrote: > > replace private CRC-32 routines with in-kernel ones. > > Have you verified that they compute the same CRC? thank you, I forgot to write in the cover letter that it is not tested. I don't know how could I test it without having the hardware... Maybe is it reliable enough writing a small standalone program using both procedures and compare the results? > > There are all sorts of subtle reasons why the outputs can differ. > > David > > - > Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK > Registration No: 1397386 (Wales) > thank you, fabio