From: Tom Rini Date: Mon, 17 May 2021 21:39:36 -0400 Subject: [PATCH v2 1/3] Add valgrind headers to U-Boot In-Reply-To: References: <20210505200821.2104070-1-seanga2@gmail.com> <20210505200821.2104070-2-seanga2@gmail.com> <20210517211826.GA11532@bill-the-cat> Message-ID: <20210518013936.GJ17669@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, May 17, 2021 at 09:36:10PM -0400, Sean Anderson wrote: > > On 5/17/21 5:18 PM, Tom Rini wrote: > > On Wed, May 05, 2021 at 04:08:18PM -0400, Sean Anderson wrote: > > > > > Valgrind uses magic code sequences to define an ABI that the client may use > > > to request behavior from the host. In particular, this may be used to > > > inform valgrind about custom allocators, such as the one used in U-Boot. > > > > > > This adds headers defining these sequences to U-Boot. It also adds a config > > > option to disable emission of these sequences entirely, in the (likely) > > > event that the user does not wish to use valgrind. Note that this option > > > was originally called NVALGRIND, but was renamed (and inverted) to > > > CONFIG_VALGRIND. > > > > > > These headers were copied from valgrind 3.16.1-4 as distributed in Arch > > > Linux. They are licensed with the bzip2 1.16 license. This appears to be a > > > BSD license with some clauses from Zlib. > > > > > > Signed-off-by: Sean Anderson > > > Reviewed-by: Simon Glass > > > > I'm not sure which part of the series breaks building without valgrind > > installed for everything, but some part of this does, please re-test. > > Thanks. > > > > Is this due to warnings? I noticed that compiling without > CONFIG_VALGRIND set resulted in a bunch of "This statement has no > effect" warnings after I had sent out this series. If this is it, I can > investigate for v4. Yes, those warnings. CI builds with -Werror on. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 659 bytes Desc: not available URL: