Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AE80C433ED for ; Wed, 19 May 2021 19:08:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 41FD66135A for ; Wed, 19 May 2021 19:08:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41FD66135A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B15A66B0036; Wed, 19 May 2021 15:08:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AC6EA6B006E; Wed, 19 May 2021 15:08:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 918116B0070; Wed, 19 May 2021 15:08:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0136.hostedemail.com [216.40.44.136]) by kanga.kvack.org (Postfix) with ESMTP id 5F37E6B0036 for ; Wed, 19 May 2021 15:08:08 -0400 (EDT) Received: from smtpin36.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 06607824999B for ; Wed, 19 May 2021 19:08:08 +0000 (UTC) X-FDA: 78158915856.36.47B1777 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 6CE4140B8CFD for ; Wed, 19 May 2021 19:08:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621451287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XUxviSfrN+zpw9Qx7g5rMkBonou88/CYcXLWe5t96Xc=; b=Mkz3IQUgQLzNqgq1qoDVsIG1UpOTr3rzu5M7Kldtym6xVgVOOBHcRDuKwpPlImTBMIiZ6R PCljohAoDm9u3kc8h0GJ+YTZIDyoHuCncs91uuse0W6lJWTHQHIvrdzxJoCn3ID1MP+ALL RcQzw4PcujrM7G+wZlflWcstFOtZd2A= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-443-AqW_wrFmP76B5C6nBHfTww-1; Wed, 19 May 2021 15:08:04 -0400 X-MC-Unique: AqW_wrFmP76B5C6nBHfTww-1 Received: by mail-wm1-f69.google.com with SMTP id b128-20020a1c1b860000b029015b52bdb65aso1777155wmb.5 for ; Wed, 19 May 2021 12:08:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZO/Tg9gg9bn/Y0D+8WtwIa3TeflHx3GoPulbW2F+HhA=; b=VjbHv+V6rRdJkvlWuK32VeWj9H+Mce7G52bWYFvEn6NNDDcgfVnTo8yMkpqwFbNqU6 mJljv6fBGeF7Bp5rSk7ABz/P8ugydadCDE0rwKchhCBYfubXPlBA06VPOefhCl0hLAuS XWrto3naraU5TPSBJiJB/oeoVPhrSu2pLc22zDnwBidI/Xg5QWYZIFHcI9KqS7ke2J26 a7Ja3T91udgQGLGAX3ofzqHbHwNOWLJFazHOBYx9/SikXSFFuq6FtbJGi2auMudsfTfl nT+qVjlKmHla55NWiyXtwE9wWdaWHj69wSehpyzXWdIHCZT9ukZ8U1Tyjozt2gWoaVm8 fQnw== X-Gm-Message-State: AOAM5324OOG0N8Gmo6caESfZQi92ls5OepBQKaMjRqoONZGNlduXjMCA qYkO1GsIBKgWcJ69zBfJiRE6hwbdZQPw7tZsYmtA3zjCRRSgiMVd+rayjSJ4w2y/4ZTloh3tNVP dcnsExBN6dA== X-Received: by 2002:a5d:6882:: with SMTP id h2mr401750wru.275.1621451283739; Wed, 19 May 2021 12:08:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+0ELM7FIfULXFR9X73ag1ofps4kkvCvWaMLxWZQH/ftcAVuGzxznKoNQ7LuytJDJ0tRGv/A== X-Received: by 2002:a5d:6882:: with SMTP id h2mr401733wru.275.1621451283562; Wed, 19 May 2021 12:08:03 -0700 (PDT) Received: from localhost (cpc111743-lutn13-2-0-cust979.9-3.cable.virginm.net. [82.17.115.212]) by smtp.gmail.com with ESMTPSA id i11sm313207wrq.26.2021.05.19.12.08.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 May 2021 12:08:02 -0700 (PDT) Date: Wed, 19 May 2021 20:08:01 +0100 From: Aaron Tomlin To: Vlastimil Babka Cc: linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@suse.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/page_alloc: bail out on fatal signal during reclaim/compaction retry attempt Message-ID: <20210519190801.t7fqdtixqmobqsps@ava.usersys.com> X-PGP-Key: http://pgp.mit.edu/pks/lookup?search=atomlin%40redhat.com X-PGP-Fingerprint: 7906 84EB FA8A 9638 8D1E 6E9B E2DE 9658 19CC 77D6 References: <20210519130609.r3ml6ohb2qsrfq2t@ava.usersys.com> <20210519145014.3220164-1-atomlin@redhat.com> <076e1c68-b4a2-26ea-9538-d88e6da800cc@suse.cz> MIME-Version: 1.0 In-Reply-To: <076e1c68-b4a2-26ea-9538-d88e6da800cc@suse.cz> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kaijdhkoyswy6ze5" Content-Disposition: inline X-Rspamd-Queue-Id: 6CE4140B8CFD Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Mkz3IQUg; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf26.hostedemail.com: domain of atomlin@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=atomlin@redhat.com X-Rspamd-Server: rspam03 X-Stat-Signature: i9up83x67y6k4w83y1ta7xyq17jtfp4a X-HE-Tag: 1621451287-950677 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --kaijdhkoyswy6ze5 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 2021-05-19 17:22 +0200, Vlastimil Babka wrote: > Hm, indeed, if fatal_signal_pending() is true then try_to_compact_pages()= will > bail out in the for-each-zone loop after trying a single zone and if that= zone > keeps returning COMPACT_SKIPPED, things can get stuck. > And direct reclaim might see compaction_ready() for another zone and retu= rn 1, > faking the progress. Indeed. > So your patch seems to be solving the issue. But maybe we should just do = the > test at the beginning of should_compact_retry() and not specific to > compaction_needs_reclaim() - if there's a fatal signal, there will be no > compaction happening, so we should just say not to retry. Fair enough - I will post a v2. > I suppose if the patch fixes your situation where fatal_signal_pending() = was > true, there's hopefully not a more general problem with the retry logic? At the present time, not to my knowledge. That being said, I will continue to review the relevant source code further. Kind regards, --=20 Aaron Tomlin --kaijdhkoyswy6ze5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEeQaE6/qKljiNHm6b4t6WWBnMd9YFAmClYf4ACgkQ4t6WWBnM d9ZhVA/+JIMsrNtkmj/bQZxLjZSCsNMbf9a4tbnVvndL+8IRoOpH6liJXOUeK1mp U0pkcqxWX1SiL2hbXLUwrdOtj9jQmGQG/Dj9C5jYdxq7I/a4wIfrYCduLprq0s8P E17jIxfH0nHxL4rmN/ujZZtRiS6pTUx2jzUAAMuLipkWvYuaw3viWhoHY3zowoTI 0Vu6yuQVHj9geImwa6NeBg5UpKfMv88g7vJ6IZ6anGT7Kzpx5Zkyt20fy2a4gfgy 4Px0zCruKvjH6Y0DD4HMGLfZvLiYRdvIbjavm8IaI9qV1u22qbl9+WwY+YNw33pK cZYWMg21J+DbagWAX1nULzXgiDQb3w07Pcez8ObuhyalJyUYPOzOwL8JsNsUyKWw yrg/KpZVKpvWRhBX+XwLymTLJX9VL0TmY45trwA638xKb/zj2MTwx+Tfv0dTjzwy O7K6Wp0aXzFAp4MYE/uwK0D1FaidtMPOHGH+i7jWy7q0vHAMDXw6sUMjEf2y45/J /SscBWWmCEbs2BZU0QpfC5iqvD6bQ24B/7pAYs3S8fzl8x0ScYTSbXAPAFnqn9Wo hQyyHth7d4U/eN/z2VnstsZjOuYb8TK+DCq1dTwm/kMB3zEolgusk5qDD5I41mB0 cJy11PUfhSrPMYi8KcvVlIUcAMqx0+6RT9pME7jp5wVA8Jy2b44= =wzHG -----END PGP SIGNATURE----- --kaijdhkoyswy6ze5--