Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA960C47089 for ; Thu, 27 May 2021 11:42:53 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E16156113B for ; Thu, 27 May 2021 11:42:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E16156113B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5C31F82EE7; Thu, 27 May 2021 13:42:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="ITYVxkwU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6708882EE6; Thu, 27 May 2021 13:42:25 +0200 (CEST) Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5B9D882E83 for ; Thu, 27 May 2021 13:42:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82e.google.com with SMTP id t20so3183494qtx.8 for ; Thu, 27 May 2021 04:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=64S8y9Ex927jitteM3Rz4o1JSFIY8WWG4CQc0Pmz+Nw=; b=ITYVxkwULOex+eY7zAWl0jiIG9GDziHiJawR4sPIxrPh+xDTPWk4UnG8ryz0lK0vkm 3tf1GTR3C043ijgjBllKngh6zN4/gOShM6qQQPND0ukUYxtLnO6YAx2cDLO3fwABX+pL EgNzTSTI59LDxW0va/c8NV2m0PmcdIMNws1Q4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=64S8y9Ex927jitteM3Rz4o1JSFIY8WWG4CQc0Pmz+Nw=; b=Ty6uBx/yXVME/CcrpgagoJXZqXLzF/RerCVKGFjIIU1wmNOibecBZdnzJysBAvaSas wyS1O9zikDGYOcBco/F+YrquNLTO3V5BGWjKtYuZSb6jdg9zGFDdHFt/6k+t6w8Ezdy3 PA3hi3XTAuEn7c1WEVKLEtFObNws7fp8GtdycIN/yQ3KOZYz4XU9gGZSyT91pI6ETgs4 cNApN32y6cU7FrIwHpl834teD8RvdQ0oi2f7ourSvL/l26JBC2y4ot+1EOCkVBPqId+7 s6P8qFI17+AeDre6F81nezVP8Bj4lXb9DdcCM5Xvvxv1S0CUkTExzDPDqZjDh0oulTzn /4xQ== X-Gm-Message-State: AOAM532Pp5XJC3edlBvFkzVHJN4Oh+32TB7Iir1cqv3G1Vx63jOTKusP genYT4bSvua2TrzYNolgMOy2Rw== X-Google-Smtp-Source: ABdhPJzIIy8hbQzXmZN9uw4XdpaAjLtbwwl/wwj4kYg70z3zytIrQpQNakbcOzJuoKlmomfVzEKc0g== X-Received: by 2002:ac8:5ac2:: with SMTP id d2mr2665769qtd.154.1622115734117; Thu, 27 May 2021 04:42:14 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2083-4b51-adf2-e538.res6.spectrum.com. [2603:6081:7b01:cbda:2083:4b51:adf2:e538]) by smtp.gmail.com with ESMTPSA id 69sm1196728qkj.12.2021.05.27.04.42.12 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 May 2021 04:42:13 -0700 (PDT) Date: Thu, 27 May 2021 07:42:11 -0400 From: Tom Rini To: Matt Merhar Cc: u-boot@lists.denx.de, Priyanka Jain , Andy Fleming , Stefan Roese , Wolfgang Denk , Mario Six , Daniel Schwierzeck , Ovidiu Panait , Simon Glass Subject: Re: [PATCH] powerpc: fix regression in arch_initr_trap() Message-ID: <20210527114211.GT17669@bill-the-cat> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="yA9el+CTtdoPwe5m" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean --yA9el+CTtdoPwe5m Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 17, 2021 at 05:32:48PM +0000, Matt Merhar wrote: > The assembly output of the arch_initr_trap() function differed by a > single byte after common.h was removed from traps.c: >=20 > fff49a18 : > fff49a18: 94 21 ff f0 stwu r1,-16(r1) > fff49a1c: 7c 08 02 a6 mflr r0 > fff49a20: 90 01 00 14 stw r0,20(r1) > -fff49a24: 80 62 00 44 lwz r3,68(r2) > +fff49a24: 80 62 00 38 lwz r3,56(r2) > fff49a28: 4b ff 76 19 bl fff41040 > fff49a2c: 80 01 00 14 lwz r0,20(r1) > fff49a30: 38 60 00 00 li r3,0 > fff49a34: 38 21 00 10 addi r1,r1,16 > fff49a38: 7c 08 03 a6 mtlr r0 >=20 > This was causing a consistent hard lockup during the MMC read / loading > of the QoriQ FMan firmware on a P2041RDB board. >=20 > Re-adding the header causes identical assembly to be emitted and allows > the firmware loading and subsequent boot to succeed. >=20 > Fixes: 401d1c4f5d ("common: Drop asm/global_data.h from common header") > Signed-off-by: Matt Merhar Applied to u-boot/master, thanks! --=20 Tom --yA9el+CTtdoPwe5m Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmCvhZMACgkQFHw5/5Y0 tyxGbgwAqLCH0g2XAZX2nQB1xJGamrOF6yuTv1fjpqy0+bTqgSVU9HFjlYFL0JkX akwXKJWThxOXwdz2NXd/kX9b9YqvGwa0ypb/ybLc9MVx0BPNjrssdpJ4KHeKmXXL y/ieaAix4deJEfHBhsjyjkXAdJ6zL6FnDxYmNsOsDQols3gFcqLJXRQDP6eUqVKQ eiR53OFcAfnUNLq7UH+31VSB2lckt7fWi2WjGwuYs8pcM1HoC92ldCtML5L9d2kC ydjhIcqbX93IGXN5G+WmnoVL2wmJ9JNNAeOjoyh2JATpD2YMotnyRCy6rToDGNzk QGMazcJVTfm0N4D5AQGHFJ0WVI+c8dXBdpY9j/aIh0OX4XNyIaAMb3P0PFkvGZqW d5XUmQJpKf5MV5Gx2qb0BfVBDWD90TPW5iIukUvnHvK3IOoeErGaAg4qv0aqFVEe PryPkryVqgokCydWDyUKEPHOyI+13L+Wa879ZYOTAAULUBxtreFjQNAqpGFRrxCD nBxxUBpH =utvc -----END PGP SIGNATURE----- --yA9el+CTtdoPwe5m--