Return-Path: From: Vidya Srinivas Date: Thu, 27 May 2021 20:01:28 +0530 Message-Id: <20210527143128.25366-1-vidya.srinivas@intel.com> In-Reply-To: <1621570131-23943-1-git-send-email-vidya.srinivas@intel.com> References: <1621570131-23943-1-git-send-email-vidya.srinivas@intel.com> MIME-Version: 1.0 Subject: [igt-dev] [PATCH 4/4] [RFC] tests/kms_big_fb: Wait for vblank before collecting CRC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: intel-gfx@lists.freedesktop.org, igt-dev@lists.freedesktop.org Cc: charlton.lin@intel.com List-ID: Without wait for vblank, CRC mismatch is seen between big and small CRC on some intel Gen11 platforms. Change-Id: I3bec931aa901130997e693ac1cacf389e2a8100f Signed-off-by: Vidya Srinivas --- tests/kms_big_fb.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c index b2027b6b9d1b..da682593429b 100644 --- a/tests/kms_big_fb.c +++ b/tests/kms_big_fb.c @@ -254,6 +254,7 @@ static void unset_lut(data_t *data) static bool test_plane(data_t *data) { igt_plane_t *plane = data->plane; + igt_display_t *display = &data->display; struct igt_fb *small_fb = &data->small_fb; struct igt_fb *big_fb = &data->big_fb; int w = data->big_fb_width - small_fb->width; @@ -269,6 +270,7 @@ static bool test_plane(data_t *data) { w / 3, h * 3 / 4, }, { w, h, }, }; + bool check_platform_intel = is_i915_device(data->drm_fd); if (!igt_plane_has_format_mod(plane, data->format, data->modifier)) return false; @@ -336,17 +338,19 @@ static bool test_plane(data_t *data) igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_UNIVERSAL); - - + if (check_platform_intel) + igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset); igt_pipe_crc_collect_crc(data->pipe_crc, &small_crc); igt_plane_set_fb(plane, big_fb); igt_fb_set_position(big_fb, plane, x, y); igt_fb_set_size(big_fb, plane, small_fb->width, small_fb->height); + igt_plane_set_size(plane, data->width, data->height); igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_UNIVERSAL); - + if (check_platform_intel) + igt_wait_for_vblank(data->drm_fd, display->pipes[data->pipe].crtc_offset); igt_pipe_crc_collect_crc(data->pipe_crc, &big_crc); igt_plane_set_fb(plane, NULL); -- 2.26.2 _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev