Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47E87C47082 for ; Tue, 8 Jun 2021 10:38:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D7A161278 for ; Tue, 8 Jun 2021 10:38:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231389AbhFHKkd (ORCPT ); Tue, 8 Jun 2021 06:40:33 -0400 Received: from mail.netfilter.org ([217.70.188.207]:56208 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231283AbhFHKkd (ORCPT ); Tue, 8 Jun 2021 06:40:33 -0400 Received: from netfilter.org (unknown [90.77.255.23]) by mail.netfilter.org (Postfix) with ESMTPSA id F2BAB63E3D; Tue, 8 Jun 2021 12:37:27 +0200 (CEST) Date: Tue, 8 Jun 2021 12:38:37 +0200 From: Pablo Neira Ayuso To: Phil Sutter Cc: netfilter-devel@vger.kernel.org, Florian Westphal Subject: Re: [nf-next PATCH v2] netfilter: nft_exthdr: Fix for unsafe packet data read Message-ID: <20210608103837.GB16424@salvia> References: <20210608094057.24598-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210608094057.24598-1-phil@nwl.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org On Tue, Jun 08, 2021 at 11:40:57AM +0200, Phil Sutter wrote: > While iterating through an SCTP packet's chunks, skb_header_pointer() is > called for the minimum expected chunk header size. If (that part of) the > skbuff is non-linear, the following memcpy() may read data past > temporary buffer '_sch'. Use skb_copy_bits() instead which does the > right thing in this situation. Applied, thanks.