Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A8C3C48BD1 for ; Fri, 11 Jun 2021 01:36:56 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id D0BEB611C9 for ; Fri, 11 Jun 2021 01:36:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0BEB611C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0EBA4067C; Fri, 11 Jun 2021 03:36:54 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id A9AAD4014F for ; Fri, 11 Jun 2021 03:36:53 +0200 (CEST) IronPort-SDR: xE7oTBIgfZ9TAkasGlL2sfpIu/iUQoisLlxtun3pxmHt5V+/HI/zBcgHTRk1r2NQzvdPw7UC0k LqOzAkLnPY2w== X-IronPort-AV: E=McAfee;i="6200,9189,10011"; a="291072518" X-IronPort-AV: E=Sophos;i="5.83,265,1616482800"; d="scan'208";a="291072518" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2021 18:36:52 -0700 IronPort-SDR: BVlSigJbkQi4RFvwndRuw0k9Z7yoQAIRoHmwx5H/e5vuN8R+qCQJo4rR9U0QNZAQTL7PWhCYF8 I7hyr45SJ+qg== X-IronPort-AV: E=Sophos;i="5.83,265,1616482800"; d="scan'208";a="483083213" Received: from intel-npg-odc-srv01.cd.intel.com ([10.240.178.194]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2021 18:36:50 -0700 From: Steve Yang To: dev@dpdk.org Cc: beilei.xing@intel.com, Steve Yang Date: Fri, 11 Jun 2021 01:35:11 +0000 Message-Id: <20210611013511.977843-1-stevex.yang@intel.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v1] net/i40e: fix set rss hash function invalid X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" i40e can support following rss hash function types: default (toeplitz), symmetric toeplitz, and simple_xor. However, when filter engine parses pattern action, it only supports symmetric toeplitz & default (toeplitz). Delete the hash function limitation when parsing pattern action. Signed-off-by: Steve Yang --- drivers/net/i40e/i40e_hash.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c index b1cb24f437..bd734722d9 100644 --- a/drivers/net/i40e/i40e_hash.c +++ b/drivers/net/i40e/i40e_hash.c @@ -1107,11 +1107,6 @@ i40e_hash_parse_pattern_act(const struct rte_eth_dev *dev, if (rss_act->func == RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ) rss_conf->symmetric_enable = true; - else if (rss_act->func != RTE_ETH_HASH_FUNCTION_DEFAULT) - return rte_flow_error_set(error, -EINVAL, - RTE_FLOW_ERROR_TYPE_ACTION_CONF, - NULL, - "Only symmetric TOEPLITZ supported when pattern specified"); if (!i40e_hash_validate_rss_types(rss_act->types)) return rte_flow_error_set(error, EINVAL, -- 2.27.0