Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72490C4743D for ; Fri, 11 Jun 2021 04:17:30 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB3DA61181 for ; Fri, 11 Jun 2021 04:17:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB3DA61181 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B95B282F3B; Fri, 11 Jun 2021 06:16:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="msmG5Ig9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8838782F24; Fri, 11 Jun 2021 06:16:45 +0200 (CEST) Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2D36982F15 for ; Fri, 11 Jun 2021 06:16:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=seanga2@gmail.com Received: by mail-qt1-x82f.google.com with SMTP id l17so1639925qtq.12 for ; Thu, 10 Jun 2021 21:16:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CWfh6RTqDxq8liIs2AMEd2GVF8MvDAX5ZGlb0Q9ypvI=; b=msmG5Ig9Sx1nRW+qKARm9eq+Jg0UIkjgBkmyXgck8RN4A7GEd2+SweYsYZuNnJpsO4 hDuVcW6RUdvsrwFofmsqB2TiHS7YrSVdZ4BENuQHBK8W/y4B/EgmXiFb8g8CCLdFAvnW eO/wbrrFTcJvZy4qte5uLF1oGT6Ov/SjBQiPffqp95sqjgXUpDDJ893c9TWlyMqasRWZ 3U1IDX6f9ZzkF0bUhrSU8XGLssFTRnB+e9tL9Cf7kKXaNwS6zR3e7Y/QAfIuM6qnvWnJ Lsiiquer4FHW8QUXZ7+3nUpZ7ILo5fYDztMPLQC74b0aSrWETz1DPh9fbXPgRIHG51qy DyAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CWfh6RTqDxq8liIs2AMEd2GVF8MvDAX5ZGlb0Q9ypvI=; b=Kz0J1dB5GvFhqEJa/yugl+mpvQFAJU7lbVYB4JciBZQTRZp55+QZafZIDlr+AgcjB3 C1VgK1MmQb3wZRpt7xN9DP3SEVzknAjgRY9i029PNwwoZQ3Pn7TCLaZWM1F4aaFhRabg m1+wrC7JB9EVorvaTAEgucbISB1K/Kaq4F4Fvj7ayROh3/BO2p5cNhK1kbrJJ34wHR3+ 7ZpdEqytQphlPX+a5FAouMFwal1+nnzTV6qZcoV1qAAPCZE9SCOvyaG2gup58W66csmT t5UUSnAPZ8OUB7WcGXkeJ+U4b/DywBVHdjOMEIltQ+H4xGH++8h53QzoYudb1A4T2Tvo XyRw== X-Gm-Message-State: AOAM530ZbVFJyn8DIhKMNtk1CnE70LdA1TYOH363EASLMuwnMppBt5Rn AhD7/osTyrIBhydC2xz1pkfPQew/LEk= X-Google-Smtp-Source: ABdhPJwoOlbFKqjKOik0TZWwudOr5KkwNcIqhbsP0Yj7ddaknri85DwkviV0zpJhPsHgLP2hXmGllg== X-Received: by 2002:ac8:5a44:: with SMTP id o4mr2136092qta.189.1623384991869; Thu, 10 Jun 2021 21:16:31 -0700 (PDT) Received: from godwin.fios-router.home (pool-74-96-87-9.washdc.fios.verizon.net. [74.96.87.9]) by smtp.gmail.com with ESMTPSA id d16sm3399033qtj.69.2021.06.10.21.16.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jun 2021 21:16:31 -0700 (PDT) From: Sean Anderson To: u-boot@lists.denx.de Cc: Damien Le Moal , Leo Liang , Lukasz Majewski , Sean Anderson Subject: [PATCH v3 06/11] clk: k210: Don't set PLL rates if we are already at the correct rate Date: Fri, 11 Jun 2021 00:16:12 -0400 Message-Id: <20210611041617.1665833-7-seanga2@gmail.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20210611041617.1665833-1-seanga2@gmail.com> References: <20210611041617.1665833-1-seanga2@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean This speeds up boot by preventing multiple reconfigurations of the PLLs. Signed-off-by: Sean Anderson --- (no changes since v1) drivers/clk/kendryte/clk.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/clk/kendryte/clk.c b/drivers/clk/kendryte/clk.c index a2901f9b96..3148756968 100644 --- a/drivers/clk/kendryte/clk.c +++ b/drivers/clk/kendryte/clk.c @@ -847,21 +847,22 @@ static ulong k210_pll_set_rate(struct k210_clk_priv *priv, int id, ulong rate, const struct k210_pll_params *pll = &k210_plls[id]; struct k210_pll_config config = {}; u32 reg; + ulong calc_rate; if (rate_in < 0) return rate_in; - log_debug("Calculating parameters with rate=%lu and rate_in=%lu\n", - rate, rate_in); err = k210_pll_calc_config(rate, rate_in, &config); if (err) return err; log_debug("Got r=%u f=%u od=%u\n", config.r, config.f, config.od); - /* - * Don't use clk_disable as it might not actually disable the pll due to - * refcounting - */ + /* Don't bother setting the rate if we're already at that rate */ + calc_rate = DIV_ROUND_DOWN_ULL(((u64)rate_in) * config.f, + config.r * config.od); + if (calc_rate == k210_pll_get_rate(priv, id, rate)) + return calc_rate; + k210_pll_disable(priv, id); reg = readl(priv->base + pll->off); @@ -875,7 +876,7 @@ static ulong k210_pll_set_rate(struct k210_clk_priv *priv, int id, ulong rate, | FIELD_PREP(K210_PLL_BWADJ, config.f - 1); writel(reg, priv->base + pll->off); - err = k210_pll_enable(priv, id); + k210_pll_enable(priv, id); serial_setbrg(); return k210_pll_get_rate(priv, id, rate); -- 2.31.0