Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D3A0C48BD1 for ; Fri, 11 Jun 2021 14:13:31 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 997A1613FA for ; Fri, 11 Jun 2021 14:13:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 997A1613FA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 51E3E803B9; Fri, 11 Jun 2021 16:13:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="pJcqrBlP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9132F80488; Fri, 11 Jun 2021 16:13:24 +0200 (CEST) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6560E8031F for ; Fri, 11 Jun 2021 16:13:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x834.google.com with SMTP id 93so2632516qtc.10 for ; Fri, 11 Jun 2021 07:13:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=O27Z7RsQbF7blkbifUVW/Ou66zbkoFZa1hLl9gbsxXA=; b=pJcqrBlPKNFkaUdb2ii6BXX5pY+jEPYUdJLgAPXC1j/T9XwfxdGyLJbsAd0j83E649 TPkjU+iukSWM6j5sCF4kr3h/PaMe3v6VeZaxqVlORblysYIpXK3deeQp0pN4katks99J Z6Bz2gsU30WPDMSQGna+ig/5NdUlm9KhFJxQY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=O27Z7RsQbF7blkbifUVW/Ou66zbkoFZa1hLl9gbsxXA=; b=UZgONnuMRiZR9SyIvaIAzCBlxlvZjGQ7lZoUF84an2S/yofq+QyMpJ1qBGBCOj7hdU 2XN6o4JtY4B3l6vlKHAYG7HYdKDfRfQ6zBVNRlwnh50ogT3SaymSPZJHLbIEkY1QH44I zbWOojB1oRfCZ0b4bgt1kQcXNwhcvS/xC/7nrKKJyyjdm36VnqgsJ7L+O3AC762qBH9X 4nauZ6eBF01i+sHvTIh3iJJmY2kVBhDGVGoO8si1FfA0AtvM6NoJ2z5sXybVciPGVS5D cJyyTJRi9yyed2zp5mec22fsEiUzdGqQGR7aSUIX9mEwJ/XXyML+U1Rj6uxQ14QYhtUV 1Q7Q== X-Gm-Message-State: AOAM532dGtR/h32NRUxzdtfMhJJBc9fxAQOWdWXzxm5O3rTtVHn/HkSp XxGI1q0Oaox0ZTPwOwOe1tE58u3kTK6J4Q== X-Google-Smtp-Source: ABdhPJxG8CR4RHl85cWtZ8yY67MdtguaWu5RfdHqA5tS/73GtxZgAqZC7+AXDPM/7NifW8Mh985Piw== X-Received: by 2002:ac8:774c:: with SMTP id g12mr4009224qtu.39.1623420800101; Fri, 11 Jun 2021 07:13:20 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-a919-72df-8fd4-9925.res6.spectrum.com. [2603:6081:7b01:cbda:a919:72df:8fd4:9925]) by smtp.gmail.com with ESMTPSA id z2sm4314481qkc.111.2021.06.11.07.13.18 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 11 Jun 2021 07:13:19 -0700 (PDT) Date: Fri, 11 Jun 2021 10:13:17 -0400 From: Tom Rini To: Lokesh Vutla Cc: Tero Kristo , u-boot@lists.denx.de Subject: Re: [PATCHv6 00/26] HSM rearch series for TI K3 devices Message-ID: <20210611141317.GV9516@bill-the-cat> References: <20210611084527.7048-1-kristo@kernel.org> <2a06a7d2-8101-91e9-3813-ce9d4f327d84@ti.com> <22da4ad1-8a11-50fb-7e97-2caa0ee187dc@kernel.org> <4d3f8b0d-0ad1-6d39-65b2-6a0599916667@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jrLL7VzBua603j+s" Content-Disposition: inline In-Reply-To: <4d3f8b0d-0ad1-6d39-65b2-6a0599916667@ti.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --jrLL7VzBua603j+s Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 11, 2021 at 07:13:19PM +0530, Lokesh Vutla wrote: > Tom, >=20 > On 11/06/21 4:48 pm, Tero Kristo wrote: > > On 11/06/2021 14:08, Lokesh Vutla wrote: > >> Hi Tero, > >> > >> On 11/06/21 2:15 pm, Tero Kristo wrote: > >>> Hello, > >>> > >>> One more post, this time with the #ifdef hackery converted to use the > >>> IS_ENABLED / CONFIG_IS_ENABLED macros, and also removed the "common.h" > >>> include from k3-clk.h header. This version also contains fixes to any > >>> build issues reported by Lokesh, and these are squashed in to relevant > >>> patches. > >> > >> Can you see if the below warnings can be fixed? > >> > >> hsm/0018-arm-mach-k3-add-support-for-detecting-firmware-image.patch > >> ------------------------------------------------------------------- > >> WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' w= here > >> possible > >> #26: FILE: arch/arm/mach-k3/common.c:31: > >> +#if IS_ENABLED(CONFIG_SYS_K3_SPL_ATF) > >=20 > > This is static data, can't be fixed. Unless we want to compile it in al= ways? > >=20 > >> > >> WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' w= here > >> possible > >> #35: FILE: arch/arm/mach-k3/common.c:40: > >> +#if CONFIG_IS_ENABLED(FIT_IMAGE_POST_PROCESS) > >=20 > > Same, static data. > >=20 > >> > >> WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' w= here > >> possible > >> #55: FILE: arch/arm/mach-k3/common.c:131: > >> +#if IS_ENABLED(CONFIG_SYS_K3_SPL_ATF) > >=20 > > This is actually just an old macro I changed from #ifdef to IS_ENABLED.= Fixing > > the whole file from the existing #ifdef:s should be outside the scope o= f this > > series. > >=20 > >> > >> WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' w= here > >> possible > >> #124: FILE: arch/arm/mach-k3/common.c:264: > >> +#if CONFIG_IS_ENABLED(FIT_IMAGE_POST_PROCESS) > >=20 > > This code addresses the static data defined before, changing this will = break > > compilation; unless we compile the data always in. > >=20 > >> > >> WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' w= here > >> possible > >> #128: FILE: arch/arm/mach-k3/common.c:268: > >> +#if IS_ENABLED(CONFIG_SYS_K3_SPL_ATF) > >=20 > > Same as above. > >=20 > >> WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' w= here > >> possible > >> #150: FILE: arch/arm/mach-k3/common.c:290: > >> +#if IS_ENABLED(CONFIG_TI_SECURE_DEVICE) > >=20 > > This can't be changed, the code it addresses is only linked in with the= config, > > causing a linker time failure if this is fixed. > >=20 > > Imho, I am not too convinced about the checkpatch tool complaining abou= t these > > issues. :) > >=20 > > -Tero > >=20 > >> > >> total: 0 errors, 6 warnings, 0 checks, 144 lines checked > >> > >> NOTE: For some of the reported defects, checkpatch may be able to > >> =A0=A0=A0=A0=A0=A0 mechanically convert to the typical style using --f= ix or --fix-inplace. > >> > >> hsm/0018-arm-mach-k3-add-support-for-detecting-firmware-image.patch ha= s style > >> problems, please review. > >> ------------------------------------------------------------------- > >> hsm/0019-arm-mach-k3-do-board-config-for-PM-only-if-supported.patch > >> ------------------------------------------------------------------- > >> WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef' w= here > >> possible > >> #24: FILE: arch/arm/mach-k3/sysfw-loader.c:162: > >> +#if !CONFIG_IS_ENABLED(K3_DM_FW) > >> > >> total: 0 errors, 1 warnings, 0 checks, 13 lines checked > >> > >> NOTE: For some of the reported defects, checkpatch may be able to > >> =A0=A0=A0=A0=A0=A0 mechanically convert to the typical style using --f= ix or --fix-inplace. >=20 > I assume you are okay with this? Well, if all the cases where we should have been using IS_ENABLED/CONFIG_IS_ENABLED but weren't have been fixed, and we aren't adding to more files, then yes, everything else that can be done as a later clean-up can just be done as a later clean-up, and indeed if it's not possible to use an if (...) it's not possible to use an if :) --=20 Tom --jrLL7VzBua603j+s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDDb30ACgkQFHw5/5Y0 tyylTgwAk3GcoAndEUqE3LooLO3UJAkxRvIez6Ul606kqQI5s9Xa3Km41jsxV8WY fFp2yWcDQSK0wFOSELHxdlCdJBsCq0mysiEcBZe5WPLspMbLn98iAjmkYf/kEXJq iznS1QufxcppxlMl3lXJcc2B9XiqZ/MZTTeL/6nS3dREAAqq8DFnFcDFt1/h4G94 YXJhvV5oB05L7Jd0XFTLvK7heQeNINQMpK8/IUJCLc6XIGGKFvRbvjzkt602OpZz 7sIkmKKweDaEbwVyrqPQYOJ7LX2s8VMkjcOH5sunFX2g/iSGlfXhOksDgjUfCl43 5mL8qkyuhzqjMdGQBuu2SDqTUhZ87DBJXUAlnkOI1oo5ZM4VeLmAwXc2qy0ThcMo /GGaoaL5GPrS7Nu0BKAX87lwm+cag+NidIKj4yEh0cTYgF40joWvp9f6JLe/Iw9b pKadOzQ5Kx+ZXgwhnnHQRi5+uKVa8pTo3zOlL2luV1eRmyEkM4p6GR7v3zSBMvQM DKDr3vUs =b4Z+ -----END PGP SIGNATURE----- --jrLL7VzBua603j+s--