Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79DFAC48BDF for ; Tue, 15 Jun 2021 11:50:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3FA71613BF for ; Tue, 15 Jun 2021 11:50:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3FA71613BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A90AF89CD9; Tue, 15 Jun 2021 11:50:24 +0000 (UTC) Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by gabe.freedesktop.org (Postfix) with ESMTPS id F044789CD9 for ; Tue, 15 Jun 2021 11:50:22 +0000 (UTC) Received: by mail-lf1-x142.google.com with SMTP id bp38so26609173lfb.0 for ; Tue, 15 Jun 2021 04:50:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version; bh=1xUcdoU0rgH6jjTSj2XB1E78P9DWja+pl0vW8u+yUME=; b=loh2Rs1j+aBMTB7nwR1wvQdD871fGH12MVpbxkvb/HGtKVG5YUTUDbVx7OK9O23RHD CO0miiJiQwtvZ2Fizq52zvuPBeSfpHO2XkfnKUvu6P8nboa9/9qGPqVH7ov6QX0XBct5 whgtfm1JxRtHiIcp4i9uB6ShT8tZkLSkFrmEvTn7kMbWQYapbcyOxKJ/rQlHwTQr941z v1aYcwND+61o78Dfd5AfNUjMVbz+6ucdAuQUdtrk+ANUquE8zOT1BUq9+v4zJt/lJKNF Imo1V3MbWn+DhBr3Xi1SDR30eAO2bqjLM0s928uFaSMDjyRHcvEiWJg932IIK9v8JBRM KPUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version; bh=1xUcdoU0rgH6jjTSj2XB1E78P9DWja+pl0vW8u+yUME=; b=d7fbtQ7/cQxcRzTnyPi2UgJIC63H2zUX8ApuEhW5iRS3rnMQ7Y6BhblmdVD9GdwBKD YiEhOfsS7NSPV6U15HtGEXBA2SQbgMRjyBRSdLN+l4DDDM/97NnVafed3odvYfJmREyR jzFcII10nOtMKbXcwTpPc8AsKDPxCFNmeJbpBWQSoXEVrSRFWZL2egXoQz8uTOsutx4r 4gOBzBVX7utHhyLkGvM6l9VtNqmY7tsEJgjH354QY6Vkw1zHN6/f1EuQofg1BbotgDVI ebmam8Dym4MDLlKQdFYNir2tLHyFPonscRKCUG/9RmaaLnOCnk7OqnhSzgm4hbDwe4iA mVBQ== X-Gm-Message-State: AOAM532GNnT6RMf/ly5YiUv9oM/MamEL7acaCm6r0VFNEzHYKjDGXlgN UrTnZm14sT+cywVqBp2D8uw= X-Google-Smtp-Source: ABdhPJyVl/Us4ycZpKhFtZUdcJ/KKU637NmPeEn55W0oyLi7vLmz4aF3vWo84Ws3DTmeFHKHVmceuA== X-Received: by 2002:a19:7d82:: with SMTP id y124mr15068746lfc.76.1623752229076; Tue, 15 Jun 2021 03:17:09 -0700 (PDT) Received: from eldfell ([194.136.85.206]) by smtp.gmail.com with ESMTPSA id z20sm2118351ljk.50.2021.06.15.03.17.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 03:17:08 -0700 (PDT) Date: Tue, 15 Jun 2021 13:16:56 +0300 From: Pekka Paalanen To: Laurent Pinchart Subject: Re: [PATCH v3] Documentation: gpu: Mention the requirements for new properties Message-ID: <20210615131656.2ecefdc4@eldfell> In-Reply-To: References: <20210610174731.1209188-1-maxime@cerno.tech> <20210611120309.2b5eb4htupv5ss32@e110455-lin.cambridge.arm.com> <20210614174912.15a49336@eldfell> <20210614152413.nguqia3s4tlowio4@e110455-lin.cambridge.arm.com> <20210615100335.0b8f96d5@eldfell> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/aSclia/U0zdUZzWMZ0xn.Ur"; protocol="application/pgp-signature" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ludovic Desroches , Haneen Mohammed , Alexandre Belloni , Linux Doc Mailing List , Xinliang Liu , Daniel Vetter , Liviu Dudau , Alexandre Torgue , dri-devel , Sandy Huang , Melissa Wen , Andrzej Hajda , Thierry Reding , Gerd Hoffmann , Benjamin Gaignard , Anitha Chrisanthus , Daniel Vetter , Jonathan Hunter , Sam Ravnborg , Jerome Brunet , Marek Vasut , Jonathan Corbet , Joonyoung Shim , Krzysztof Kozlowski , Kevin Hilman , Neil Armstrong , Russell King , Steven Price , David Airlie , Xinwei Kong , Noralf =?UTF-8?B?VHLDuG5uZXM=?= , VMware Graphics , Alyssa Rosenzweig , Chen Feng , Hyun Kwon , NXP Linux Team , Chun-Kuang Hu , Tian Tao , Thomas Zimmermann , Jonas Karlman , Martin Blumenstingl , Edmund Dea , Sascha Hauer , Alison Wang , Roland Scheidegger , Shawn Guo , Ben Skeggs , Maxime Ripard , Rodrigo Vivi , Matthias Brugger , Chen-Yu Tsai , Sean Paul , Pengutronix Kernel Team , Paul Cercueil , Jernej Skrabec , Rodrigo Siqueira , Tomi Valkeinen , Hans de Goede , Andrew Jeffery , Yannick Fertr e , Boris Brezillon , Seung-Woo Kim , Nicolas Ferre , Robert Foss , Joel Stanley , Tomeu Vizoso , Kyungmin Park , Kieran Bingham , Qiang Yu , Maxime Coquelin , Alex Deucher , Huang Rui , Oleksandr Andrushchenko , Philippe Cornu , Jyri Sarha , Christian =?UTF-8?B?S8O2bmln?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --Sig_/aSclia/U0zdUZzWMZ0xn.Ur Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 15 Jun 2021 12:45:57 +0300 Laurent Pinchart wrote: > On Tue, Jun 15, 2021 at 07:15:18AM +0000, Simon Ser wrote: > > On Tuesday, June 15th, 2021 at 09:03, Pekka Paalanen wrote: > > =20 > > > indeed it will, but what else could one do to test userspace KMS > > > clients in generic CI where all you can have is virtual hardware? May= be > > > in the long run VKMS needs to loop back to a userspace daemon that > > > implements all the complex processing and returns the writeback result > > > via VKMS again? That daemon would then need a single upstream, like t= he > > > kernel, where it is maintained and correctness verified. =20 > >=20 > > The complex processing must be implemented even without write-back, bec= ause > > user-space can ask for CRCs of the CRTC. > > =20 > > > Or an LD_PRELOAD that hijacks all KMS ioctls and implements virtual > > > stuff in userspace? Didn't someone already have something like that? > > > It would need to be lifted to be a required part of kernel UAPI > > > submissions, I suppose like IGT is nowadays. =20 > >=20 > > FWIW, I have a mock libdrm [1] for libliftoff. This is nowhere near a f= ull > > software implementation with write-back connectors, but allows to expose > > virtual planes and check atomic commits in CI. > >=20 > > [1]: https://github.com/emersion/libliftoff/blob/master/test/libdrm_moc= k.c > > =20 > > > For compositor developers like me knowing the exact formulas would be= a huge > > > benefit as it would allow me to use KMS to off-load precision-sensiti= ve > > > operations (e.g. professional color management). Otherwise, composit= ors > > > probably need a switch: "high quality color management? Then do not u= se KMS > > > features." =20 > >=20 > > I think for alpha blending there are already rounding issues depending = on the > > hardware. I wouldn't keep my hopes up for any guarantee that all hw use= s the > > exact same formulae for color management stuff. =20 >=20 > Good, because otherwise you would be very quickly disappointed :-) >=20 > For scaling we would also need to replicate the exact same filter taps, > which are often not documented. That is where the documented tolerances come into play. Userspace projects need screenshot-based testing, and we need to know how much tolerance we should allow or expect. Good reminder about CRCs. CRCs have zero tolerance, so they are not useful for testing properties that have any leeway, are they? Thanks, pq --Sig_/aSclia/U0zdUZzWMZ0xn.Ur Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEJQjwWQChkWOYOIONI1/ltBGqqqcFAmDIfhgACgkQI1/ltBGq qqf9uw//Z7wP5lb4lQfPWOw5s+nFR9pu8B8zVwQzEuz2RTx5Vc/XXfa2Fc0rukCj Y380sIPdp2+avUNDyitBKW8E7rU3mab7UmBdn6CmLnvZVM+BQ3vdtDvZ2WfezT7j AkEzJYm9QhiYyqezwzCa1Jo2ugUJwSxT6TKQbVsT64vCCajdZIQJvDizCPy0HNvY /dncTRXyWta650vMnzYle6YlWrYL+kJst8J/zU5+H3nffgJef6zpxz+o37Libz/w WYZWYSJ7swv54xNCddkuJrSf60vs7KlwiXZuBEt5dSu2ro81unrU6FVpEazF8x1e 3jigPFgMppxYTIVOGtrjbQku7hJB1f9u+DNGjKTeH8HMc0QkAfcb+V7nrmaetZs6 02GvihbFh67ewL7hcIXVpNETdsfQD3pVCDz1Xz6w5A6bixa0HuH31C3ATBhUuKhH tJNv99eZvmfBIaeuFNkCgPbxP2vdFmStT1x/bq06g+2RCG71+EzkKF6hX0JD+kRf CqRqBDvwNy4sXgDkwz+ftpHrn+OvO7LrR4X5NtZUeo24VaXlrJTqqX5lSHr6OgZg oREPacO/pUjTluJY+sb+qUBkxTcu9hP5MC5LnHvtiQ2yxWel2Wp+MOF42Sl2B98w jTfx9rHSqauMN7hs33K2UBnAcpf2sswYagwmg0clpgF/ipcJ96k= =4xXK -----END PGP SIGNATURE----- --Sig_/aSclia/U0zdUZzWMZ0xn.Ur--