Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3285C2B9F4 for ; Thu, 17 Jun 2021 13:28:37 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 16F1C610A2 for ; Thu, 17 Jun 2021 13:28:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16F1C610A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7CB1E16F3; Thu, 17 Jun 2021 15:27:45 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7CB1E16F3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1623936515; bh=wutnWbTDe0uhFciWBJMvlKQqEBpsL675GE24ZQ1PLWU=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=AWju3uI4z0VXwgSIXKcEPmXugNSWWRIdwgdYDa+3/K3DBlzE1AYl9AzgGtPGyNT5+ X1fMdJhLa6iS+QfasvtTPByjGq37eAC9a+nG4QmjXntDaYQwhfq1K/aPrHtcdEtAv+ UWqtZCJ0Ze6tMnvOHQ7kIhHTwpCIMwLl9xJNEWq8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 16651F80171; Thu, 17 Jun 2021 15:27:45 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 71CAEF8025A; Thu, 17 Jun 2021 15:27:43 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 28322F8016D for ; Thu, 17 Jun 2021 15:27:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 28322F8016D Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IofAuLty" Received: by mail.kernel.org (Postfix) with ESMTPSA id 0FBD161040; Thu, 17 Jun 2021 13:27:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623936456; bh=wutnWbTDe0uhFciWBJMvlKQqEBpsL675GE24ZQ1PLWU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IofAuLtyH9GQ9LzgCEKgEC4KcZusn7MTQA/TccqUCo1PEyRGtl6SSrrdI1fjKAnZN JwiH+Qve9FKsSPaPJd+YtQ5B9TvBxJlluT37JCaW/8aeSV5UfGUGVMNC5v/TtCEzVi nsL3uDWp6pgSZGfDmS4BErFRpMFn6suKUe7ez/2IVGGZhL517H8SZy3etTr2qow/Su R+PW49H27fDGUwutMsTSP2X5VpcFRPoFqjT0Uk0ZH3Cn8wTwhBT7zHk0sscxKp6adc QxN3ZqoRV+eIg34qTJLVJn5jbrA66UeBnrcPwpKPxswzJx6t/u6szRxZt90NuGJddL UkFckzSB2bsSw== Date: Thu, 17 Jun 2021 14:27:16 +0100 From: Mark Brown To: Shuming =?utf-8?B?W+iMg+abuOmKmF0=?= Subject: Re: [PATCH 1/2] ASoC: rt711: remap buttons Message-ID: <20210617132716.GE5067@sirena.org.uk> References: <20210617090809.16901-1-shumingf@realtek.com> <20210617123914.GD5067@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zjcmjzIkjQU2rmur" Content-Disposition: inline In-Reply-To: X-Cookie: But it does move! User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Oder Chiou , Jack Yu , "alsa-devel@alsa-project.org" , "lars@metafoo.de" , "lgirdwood@gmail.com" , "jairaj.arava@intel.com" , Derek =?utf-8?B?W+aWueW+t+e+qV0=?= , "bard.liao@intel.com" , "sathya.prakash.m.r@intel.com" , "Flove\(HsinFu\)" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --zjcmjzIkjQU2rmur Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 17, 2021 at 01:19:05PM +0000, Shuming [=E8=8C=83=E6=9B=B8=E9=8A= =98] wrote: > > > This patch uses the same mapping as the machine driver: > > > BTN_0 : KEY_PLAYPAUSE > > > BTN_1 : KEY_VOICECOMMAND > > > BTN_2 : KEY_VOLUMEUP > > > BTN_3 : KEY_VOLUMEDOWN > > Which machine driver? Can't there be multiple machine drivers, and if > > they're already overriding things why do this? > The rt711 codec is designed in the Intel platform only for now. I'm sure your sales team would be happy to change that! > The machine driver is 'sof_sdw.c' that resides under sound/soc/intel/boar= ds. > It seems Intel uses the same mapping in all other Intel machine drivers. > Please check the commit as below. > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/commit/= ?id=3D1f64a08bd5a9a218deb37c03c1e98e9567379698 Sure, but if the machine drivers for these platforms already do the right thing why change the CODEC driver? > Hi Sathya, > Do you know why the m/c driver uses this mapping? I'd guess it's just because that's the standard set of headphone buttons that Intel uses for their platforms. --zjcmjzIkjQU2rmur Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmDLTbMACgkQJNaLcl1U h9DsyQf/cPVBZnWs5i6VHZ7Mvy2yg1HJ5/flMyl53ML2qb90y3MYm0i+Z7zY4Yqo BoLxGNN1/+3FCX+TijnZxkjuT/WBt7Mta19fr8i1yGKb5zl5iyII7cOJOyu+ZnDV 9w/sR4uOtKqOTPeqvV2gVMnjp5nj6BFxVl20fYeq9Jt7hrdMHtkPYzt2wbAz8FTS xTsiBF2HuD3cm/hz9QvcBTpycdY0xTii9jVn/eTRU1azWsgGaUgVpjbkD6hhppC9 8qLir3DHv4m8i7gSL89XQ8m1VAikBjhUNiCMpnnXVjg1HlSQOl9/smScHvAwVpSt e/86nm18smCD7KHW22odJLB1jysTUg== =WfLZ -----END PGP SIGNATURE----- --zjcmjzIkjQU2rmur--