Content-Type: multipart/mixed; boundary="===============6297537257544418523==" MIME-Version: 1.0 From: Guenter Roeck To: kbuild-all@lists.01.org Subject: Re: [PATCH 1/2] watchdog: iTCO_wdt: use pm_ptr() Date: Sat, 19 Jun 2021 16:19:33 -0700 Message-ID: <20210619231933.GA3821829@roeck-us.net> In-Reply-To: <202106200634.4MqYLYfW-lkp@intel.com> List-Id: --===============6297537257544418523== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Sun, Jun 20, 2021 at 06:27:52AM +0800, kernel test robot wrote: > Hi "Enrico, > = > I love your patch! Yet something to improve: > = > [auto build test ERROR on linux/master] > [also build test ERROR on hwmon/hwmon-next linus/master v5.13-rc6 next-20= 210618] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > = > url: https://github.com/0day-ci/linux/commits/Enrico-Weigelt-metux-IT-= consult/watchdog-iTCO_wdt-use-pm_ptr/20210617-024441 > base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.gi= t dd860052c99b1e088352bdd4fb7aef46f8d2ef47 > config: ia64-allmodconfig (attached as .config) > compiler: ia64-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=3D1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbi= n/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/0day-ci/linux/commit/670a790c3acfccf4b540545= 9048ba2a05b912eef > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Enrico-Weigelt-metux-IT-consult/= watchdog-iTCO_wdt-use-pm_ptr/20210617-024441 > git checkout 670a790c3acfccf4b5405459048ba2a05b912eef > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=3D$HOME/0day COMPILER=3Dgcc-9.3.0 make.cros= s ARCH=3Dia64 = > = > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > = > All errors (new ones prefixed by >>): > = > In file included from include/linux/device.h:25, > from include/linux/acpi.h:15, > from drivers/watchdog/iTCO_wdt.c:48: > >> drivers/watchdog/iTCO_wdt.c:645:21: error: 'iTCO_wdt_pm' undeclared he= re (not in a function); did you mean 'iTCO_wdt_ops'? > 645 | .pm =3D pm_ptr(&iTCO_wdt_pm), > | ^~~~~~~~~~~ > include/linux/pm.h:377:23: note: in definition of macro 'pm_ptr' > 377 | #define pm_ptr(_ptr) (_ptr) > | ^~~~ > = > = > vim +645 drivers/watchdog/iTCO_wdt.c > = > 640 = > 641 static struct platform_driver iTCO_wdt_driver =3D { > 642 .probe =3D iTCO_wdt_probe, > 643 .driver =3D { > 644 .name =3D DRV_NAME, > > 645 .pm =3D pm_ptr(&iTCO_wdt_pm), I'll drop this patch for now. Guenter > 646 }, > 647 }; > 648 = > = > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org --===============6297537257544418523==--