Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE3DFC2B9F4 for ; Tue, 22 Jun 2021 03:35:02 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B62361245 for ; Tue, 22 Jun 2021 03:35:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B62361245 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 275F5829A6; Tue, 22 Jun 2021 05:35:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="fM9S8FfQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1EDFA82995; Tue, 22 Jun 2021 05:34:58 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2062c.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e89::62c]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F2DF6829B2 for ; Tue, 22 Jun 2021 05:34:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=Wesley.sheng@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d0/7zQAxqUcTmNRmPgOyRtjeFmrLxpPmrK/fdCJrSQVWi4AEoYmOnOpzXMnoLef/6KZTV7jTmf9RyR78eamFLYec1jxsewvvLQosLIRao8PnBYP9dUWeQkMdwVnwlFYV2Ju3kE4DOL2iuk2MSnIJW5vkUszzWz+NuH+859YAfo1IeA4ZBpNPXwzJwZNX04XzYFOlhwvN3OanNFWctA0f1+wOx0d+ZEoyaVeF/vGS1QP84Jx9K31uHDjUazmQYdOPvkl4YC9sX2fCfcPPZB3S1ry2vQypFEwFj2mQwPxY9ENBLMaWdRB06ePoQmRJxAFLANEmOZNbbFW7HhMsPIQMDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tdauT6sKWIN8irUwyUikTcVWM2KJ6h9BbPPfFHuIJ70=; b=Py/rmBg9uJd7I2nVZ4N0iR7qiICkATXUbm48/wXUXviNYyJSiQTJ9qyPMx/c/mgImuZ4VkFH9kweB7kJlECwKrZVCsws6RO9pzigc2x3aNIuouipQe5rYLN4UcmOFHwgVdi/3BwWiSUlX/cxb8uhnLYHPEc+OtGrswThrsYb2eRpiTCdd0n1VFrnDHSgJoyQJNpHKnfhhue5iE+h7RiEE2ejnfkoNQ//MrFKVGCZ5kyabLyBefJsFXy1J45uObjLDMLWMBtB3wrgnDrNrFMIOL4JP+grS3Ng8wSc7sL67tDbHApPTijkNwvg6z24hDH4imQYNGhxMhscT7Lr7fI5pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.denx.de smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tdauT6sKWIN8irUwyUikTcVWM2KJ6h9BbPPfFHuIJ70=; b=fM9S8FfQ6+VLoUQAiXkXr42Lgfqju3pBoqEMWuoKztb3LSE8Ej/i2UFzv7I4pBtkUKs5IUO4yAKu6JYEc924L9AqHz1Pipp45iadeKWLcBWzQqZW33zYehLaHdlbzhW6VVBUuNzDe/yrLAjQtwheUOyy9fD6b7eltdtJyEEBXKo= Received: from DM5PR06CA0037.namprd06.prod.outlook.com (2603:10b6:3:5d::23) by CH2PR12MB4150.namprd12.prod.outlook.com (2603:10b6:610:a6::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.15; Tue, 22 Jun 2021 03:34:51 +0000 Received: from DM6NAM11FT034.eop-nam11.prod.protection.outlook.com (2603:10b6:3:5d:cafe::48) by DM5PR06CA0037.outlook.office365.com (2603:10b6:3:5d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.21 via Frontend Transport; Tue, 22 Jun 2021 03:34:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; Received: from SATLEXMB03.amd.com (165.204.84.17) by DM6NAM11FT034.mail.protection.outlook.com (10.13.173.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4242.16 via Frontend Transport; Tue, 22 Jun 2021 03:34:49 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 21 Jun 2021 22:34:49 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 21 Jun 2021 22:34:49 -0500 Received: from weisheng-Pro-E800-G4-WS950T.amd.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2242.4 via Frontend Transport; Mon, 21 Jun 2021 22:34:47 -0500 From: Wesley Sheng To: CC: , Subject: [PATCH] nvme: Remove the redundant aqa value setting Date: Tue, 22 Jun 2021 11:34:43 +0800 Message-ID: <20210622033443.29672-1-wesley.sheng@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3a65ed9e-7ad2-443e-42e2-08d9352eb0c6 X-MS-TrafficTypeDiagnostic: CH2PR12MB4150: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1775; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PSjztKfMYRaFAiZts4Gyllm6VMb1TuIwipHvI8PYXmF41ftVCsT4/Jf0s2PaxSlnCtKGl4BseW8mgTTPJ68lvgX8TFEKixdeMNnDj5zOU0Gq1mmjMFjymcFxb4EIqDvKvKoA8yC8WGY/33ik45qiVlSKQLg5hKbKnSlHkmsoNZaARO9K9jhQ2fsNu5x2diTPu7Vt1JmEPGlsepIrsQXxu1PptBvyke0eRaJVs8pV9UDDCtMLXp+KhvhYuMuHmIfhqq58OMoMtszdMt3CDVGpyvExPvil+XTH/bBpwXwcEp1xGj7ZnCGuoE0dwDLtQWn6wrsfOZ70BweNokykF6ejTaXmwLYd0eJssiSd+Jw62rqU+dIzXj23AzG7Nzm8R3JrIwM6YHhhS7buu31uYmuhqbrmaYHC7PbFm2CCIQRfi8R7QtzfTC0S++Ql1qFXVWGkDMFykb5BgrVsCIq2GqFATcz9XAv8GiWiJizeqpCgK18astgOJ3GnNS3JbKsyPhDb3Rw3bqsVzWr8taOR6ugeliSvPFUTLkQ0eDInjHFDNNeVqj4eOz+U5qbalcS6wMbS/itfd1pjkstN8p0O/3fajArwKnZJvqiJ6ZVk7B0RFZrNM2Ao6oLcQvbQeyHJypWmviaGnirn06Tp4tawMjUu8RM1zPd29ZXnZrOxQbNxZEw1+EuZG8d98kS0HaZN++SC X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB03.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(4636009)(346002)(136003)(376002)(39860400002)(396003)(46966006)(36840700001)(6666004)(6916009)(8936002)(44832011)(26005)(86362001)(36756003)(4326008)(8676002)(4744005)(356005)(47076005)(186003)(81166007)(2616005)(70586007)(36860700001)(54906003)(1076003)(2906002)(478600001)(82740400003)(83380400001)(426003)(316002)(5660300002)(336012)(82310400003)(7696005)(70206006)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jun 2021 03:34:49.9057 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3a65ed9e-7ad2-443e-42e2-08d9352eb0c6 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT034.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4150 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean From: Wesley Sheng AQA (Admin Queue Attributes) register is a dword size with lower word of ASQS, and higher word of ACQS. The code set the variable aqa twice, but it is redundant. Signed-off-by: Wesley Sheng --- drivers/nvme/nvme.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/nvme/nvme.c b/drivers/nvme/nvme.c index fc64d93ab8..a062234163 100644 --- a/drivers/nvme/nvme.c +++ b/drivers/nvme/nvme.c @@ -379,7 +379,6 @@ static int nvme_configure_admin_queue(struct nvme_dev *dev) aqa = nvmeq->q_depth - 1; aqa |= aqa << 16; - aqa |= aqa << 16; dev->page_size = 1 << page_shift; -- 2.25.1