Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03EC0C49EA5 for ; Thu, 24 Jun 2021 02:12:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A44596137D for ; Thu, 24 Jun 2021 02:12:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A44596137D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cdjrlc.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=7BDs9u916dGtDzAl24J2oWJI6adtsTMb2HTchbqXQeA=; b=HiNbDjs2zXbWpj lUNSaUYkBDoMsyQqKtHyM8zp45+kznxrnxYuzhe7d9dvqr8tDY2v3ajcVXSvjJcKbeNKYOy/3WDBH C0AyoV1tZiIosQ/pvzQkojIAaD3aUrlJItMIuzHoRLiUj8MLDGIRO/OhK05ZDNR/El3O4qb91Y1DA ZF//VOF23A+A95mqFQvqFCY23pWigBN/OQOMn3+FsfrtOHmFJUHs8Qynt0qE2RSKAIpnaLhIA/LeC +zoWtK9aLnT4gCjWw3bzQXKw44SxlRxrvMoRldmceeS2kz9NZqR0cP6cXmXTkghvhxRTPSSY5R+Ao z//jFiYUAWQyc+PyP3Sw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwEp8-00COpH-R0; Thu, 24 Jun 2021 02:10:35 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwEp6-00COoz-LF for linux-arm-kernel@bombadil.infradead.org; Thu, 24 Jun 2021 02:10:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:MIME-Version :Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:In-Reply-To:References; bh=2TLoaFSFg3GqpTAKOJQzn23p+wC246PXNITZQHx+Leg=; b=CAjmMnn3sKkqokIiStvV6oZz97 kqNZO1+CWRfUMuTsPTgOCcL3wOwsUzH6pjK9HWdgd+NkyT/f96U3hvmqBMiXrDyOSkBOZdtJ1u6Lr jOLyA6RZLnwecQ7lBgOj3O2CMCuIZfC+eVZO1vKWBLtHJ5eCgkMkFmP43aWf4ooBsZF3ltCp5MqSe 1lBy7fLvlSvCNxDbRU0H2wNeyZRoWbAPY9YFCDOVndwe0Gt/je60AWxh9jYInecjipKHfMLtnMVCP PkaOeajmhdyFD5Kzzictz2aPNa85gp4YHD+vbRWxOA18A2SJIe2dSFzuFdzxJxOZZ3mCjKS7pY08L UIt6aNKg==; Received: from smtpbgbr2.qq.com ([54.207.22.56]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwEot-00B6TY-Jq for linux-arm-kernel@lists.infradead.org; Thu, 24 Jun 2021 02:10:30 +0000 X-QQ-mid: bizesmtp45t1624500588tqxk6qsb Received: from localhost.localdomain (unknown [182.148.13.245]) by esmtp6.qq.com (ESMTP) with id ; Thu, 24 Jun 2021 10:09:39 +0800 (CST) X-QQ-SSF: 01000000002000409000B00A0000000 X-QQ-FEAT: Ea2I0ipxPJhEH4bHJxnq9qckaedYZ340QDk4Kny/L3e2iWrhKxOgtdAZmB2JG mzHEg5LT791Z6Mbx0KtEBX7skvwuCDklSw09z5FKnfPYtUbv2GAV5NR/BtfGcX7SUwA4G2x CUiUDWpp3DvXND0nxQpet352dFzmSJw+hIG+Ysdw3SxklN7UR/xeQyQrF738gyDRD8h5p6Y 2NzUpToXsg3/d8f5BTDd7H0X0DZ5Pfxv+XP9U0CipyoMXknc3fUNQu4dkR7+uJjup6wz9sw jRduwec8RQk2eIoZ3IqHZUWJSSkP4nVR/dz8NMI7mtog2j X-QQ-GoodBg: 0 From: Jinchao Wang To: gregkh@linuxfoundation.org, jirislaby@kernel.org, michal.simek@xilinx.com Cc: linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, wjc@cdjrlc.com Subject: [PATCH] PNP: moved EXPORT_SYMBOL so that it immediately followed its function/variable Date: Thu, 24 Jun 2021 10:09:29 +0800 Message-Id: <20210624020929.49968-1-wjc@cdjrlc.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:cdjrlc.com:qybgforeign:qybgforeign7 X-QQ-Bgrelay: 1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210624_031027_163814_E83654CC X-CRM114-Status: GOOD ( 13.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org change made to resolve following checkpatch message: WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable Signed-off-by: Jinchao Wang --- drivers/pnp/card.c | 7 +++---- drivers/pnp/driver.c | 9 ++++----- drivers/pnp/isapnp/compat.c | 1 - drivers/pnp/manager.c | 7 +++---- drivers/pnp/support.c | 1 - 5 files changed, 10 insertions(+), 15 deletions(-) diff --git a/drivers/pnp/card.c b/drivers/pnp/card.c index d40ed8621571..9610a9f08ff4 100644 --- a/drivers/pnp/card.c +++ b/drivers/pnp/card.c @@ -369,6 +369,7 @@ struct pnp_dev *pnp_request_card_device(struct pnp_card_link *clink, dev->card_link = NULL; return NULL; } +EXPORT_SYMBOL(pnp_request_card_device); /** * pnp_release_card_device - call this when the driver no longer needs the device @@ -382,6 +383,7 @@ void pnp_release_card_device(struct pnp_dev *dev) device_release_driver(&dev->dev); drv->link.remove = &card_remove_first; } +EXPORT_SYMBOL(pnp_release_card_device); /* * suspend/resume callbacks @@ -439,6 +441,7 @@ int pnp_register_card_driver(struct pnp_card_driver *drv) } return 0; } +EXPORT_SYMBOL(pnp_register_card_driver); /** * pnp_unregister_card_driver - unregisters a PnP card driver from the PnP Layer @@ -451,8 +454,4 @@ void pnp_unregister_card_driver(struct pnp_card_driver *drv) mutex_unlock(&pnp_lock); pnp_unregister_driver(&drv->link); } - -EXPORT_SYMBOL(pnp_request_card_device); -EXPORT_SYMBOL(pnp_release_card_device); -EXPORT_SYMBOL(pnp_register_card_driver); EXPORT_SYMBOL(pnp_unregister_card_driver); diff --git a/drivers/pnp/driver.c b/drivers/pnp/driver.c index 93a30a8f88d1..c29d590c5e4f 100644 --- a/drivers/pnp/driver.c +++ b/drivers/pnp/driver.c @@ -68,6 +68,7 @@ int pnp_device_attach(struct pnp_dev *pnp_dev) mutex_unlock(&pnp_lock); return 0; } +EXPORT_SYMBOL(pnp_device_attach); void pnp_device_detach(struct pnp_dev *pnp_dev) { @@ -76,6 +77,7 @@ void pnp_device_detach(struct pnp_dev *pnp_dev) pnp_dev->status = PNP_READY; mutex_unlock(&pnp_lock); } +EXPORT_SYMBOL(pnp_device_detach); static int pnp_device_probe(struct device *dev) { @@ -271,11 +273,13 @@ int pnp_register_driver(struct pnp_driver *drv) return driver_register(&drv->driver); } +EXPORT_SYMBOL(pnp_register_driver); void pnp_unregister_driver(struct pnp_driver *drv) { driver_unregister(&drv->driver); } +EXPORT_SYMBOL(pnp_unregister_driver); /** * pnp_add_id - adds an EISA id to the specified device @@ -310,8 +314,3 @@ struct pnp_id *pnp_add_id(struct pnp_dev *dev, const char *id) return dev_id; } - -EXPORT_SYMBOL(pnp_register_driver); -EXPORT_SYMBOL(pnp_unregister_driver); -EXPORT_SYMBOL(pnp_device_attach); -EXPORT_SYMBOL(pnp_device_detach); diff --git a/drivers/pnp/isapnp/compat.c b/drivers/pnp/isapnp/compat.c index 035e95092489..d60d9e377da5 100644 --- a/drivers/pnp/isapnp/compat.c +++ b/drivers/pnp/isapnp/compat.c @@ -63,5 +63,4 @@ struct pnp_dev *pnp_find_dev(struct pnp_card *card, unsigned short vendor, } return NULL; } - EXPORT_SYMBOL(pnp_find_dev); diff --git a/drivers/pnp/manager.c b/drivers/pnp/manager.c index 144055593ec8..1765d6e60a8a 100644 --- a/drivers/pnp/manager.c +++ b/drivers/pnp/manager.c @@ -350,6 +350,7 @@ int pnp_start_dev(struct pnp_dev *dev) dev_info(&dev->dev, "activated\n"); return 0; } +EXPORT_SYMBOL(pnp_start_dev); /** * pnp_stop_dev - low-level disable of the PnP device @@ -371,6 +372,7 @@ int pnp_stop_dev(struct pnp_dev *dev) dev_info(&dev->dev, "disabled\n"); return 0; } +EXPORT_SYMBOL(pnp_stop_dev); /** * pnp_activate_dev - activates a PnP device for use @@ -396,6 +398,7 @@ int pnp_activate_dev(struct pnp_dev *dev) dev->active = 1; return 0; } +EXPORT_SYMBOL(pnp_activate_dev); /** * pnp_disable_dev - disables device @@ -423,8 +426,4 @@ int pnp_disable_dev(struct pnp_dev *dev) return 0; } - -EXPORT_SYMBOL(pnp_start_dev); -EXPORT_SYMBOL(pnp_stop_dev); -EXPORT_SYMBOL(pnp_activate_dev); EXPORT_SYMBOL(pnp_disable_dev); diff --git a/drivers/pnp/support.c b/drivers/pnp/support.c index e4f53d31191d..a6073db10ec6 100644 --- a/drivers/pnp/support.c +++ b/drivers/pnp/support.c @@ -30,7 +30,6 @@ int pnp_is_active(struct pnp_dev *dev) else return 1; } - EXPORT_SYMBOL(pnp_is_active); /* -- 2.31.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel