Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE4B7C2B9F4 for ; Fri, 25 Jun 2021 12:39:00 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB59661921 for ; Fri, 25 Jun 2021 12:38:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB59661921 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 985AD82BF6; Fri, 25 Jun 2021 14:38:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="BbCx4mDs"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2C1BF82C00; Fri, 25 Jun 2021 14:38:55 +0200 (CEST) Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A47F982BDF for ; Fri, 25 Jun 2021 14:38:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x835.google.com with SMTP id r7so7318749qta.12 for ; Fri, 25 Jun 2021 05:38:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jL6AACZikC6m7hw69sIRtGLS9RGptxH5zvlFdkl/Dj4=; b=BbCx4mDsE0WRbiCbZ/uNm+4Az8Acr3wMTTjPEEoaIoA2iOLyBBm2JSXWLXPU24uotX ingnsydVRDZiTbsWUBmvPU6tcQ6y3ysTCX/yv4cwqNJHcMSM44zADd8JUiuA5yrCPmto JSPd91rCU4c/p7riS3C7H1WT/fxHV3lZzd3QU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jL6AACZikC6m7hw69sIRtGLS9RGptxH5zvlFdkl/Dj4=; b=TUCjQUGVe1rAoq9J5pLQpQJ+cDwDYn7xXDnU2pPci99Wo0Okaito/ytnB/yMYtf7qa xjZFQbB4inFp+lgsHz/6H3RPCRW7cC3lTPdsD3vzTZLiu4LmAnQSZAnZEVvTrAsdNmCm 5vLttWb0iecesPo88hRDa8QTxsFE7xKL2JlvxTHFTulBFAH8guGevh498EQMkzPbNerh sVH9xUKYgVsZDqy2qwhUsW3BVvH191AWorPvVzSY2zHLr/7kIHevsTNE/WJDy3pIoy2E nozwmMOdGCgHYSVuKY2IsAPNcU5s2iO3tIIysKtj7+TFL/rWa7/+uCTe5IoY7qXAZBDt 7Yug== X-Gm-Message-State: AOAM532r6oA26CB6kGYUkz7u+S/klqXYtjHSHknS4jiSBO1IAAkIwd/5 6KOJDv/gTDN7pXQN3R0orcl1sA== X-Google-Smtp-Source: ABdhPJyh7gM61jEsWNbtexcmVWxWYWAMS08vkTJnTUj01aFOr1fm4qDdAQP5q0hlUfprJea/RsDlog== X-Received: by 2002:ac8:5a10:: with SMTP id n16mr9425343qta.124.1624624730543; Fri, 25 Jun 2021 05:38:50 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-b806-617b-65c1-2cd7.res6.spectrum.com. [2603:6081:7b01:cbda:b806:617b:65c1:2cd7]) by smtp.gmail.com with ESMTPSA id x9sm3880314qtf.76.2021.06.25.05.38.49 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 25 Jun 2021 05:38:49 -0700 (PDT) Date: Fri, 25 Jun 2021 08:38:47 -0400 From: Tom Rini To: Marek Vasut Cc: Ivaylo Dimitrov , Pali =?iso-8859-1?Q?Roh=E1r?= , Lokesh Vutla , Simon Glass , Merlijn Wajer , u-boot@lists.denx.de, Pavel Machek Subject: Re: [PATCH 1/2] DM_USB: allow building without OF_CONTROL Message-ID: <20210625123847.GM9516@bill-the-cat> References: <3c44a3cf-b9ad-1b31-d0a4-54c896222d78@gmail.com> <0a8a9dab-ee44-fab7-d712-d66cb121c170@gmail.com> <249e8e4f-b5f7-1f97-adbd-a83d75883ef4@denx.de> <338bfdad-15f6-fbff-6fde-d0411e585bf4@gmail.com> <20210619205129.GA9516@bill-the-cat> <7c4024e6-f58e-1f9a-d969-0d0b190c2484@denx.de> <20210620155426.GB9516@bill-the-cat> <19957b67-732a-f53d-4453-d37ce28a92a9@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="PLe3xFgSmS0d151j" Content-Disposition: inline In-Reply-To: <19957b67-732a-f53d-4453-d37ce28a92a9@denx.de> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --PLe3xFgSmS0d151j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 20, 2021 at 09:43:43PM +0200, Marek Vasut wrote: > On 6/20/21 5:54 PM, Tom Rini wrote: >=20 > [...] >=20 > > > As far as I understand, the RX51 has gigabytes of eMMC storage, so it= can > > > use SPL just like any other OMAP3 board. > >=20 > > U-Boot is being called by the old vendor X-Loader fork and needs to take > > up the existing flash spot. >=20 > So, why not place SPL in those 256 kiB and load U-Boot proper from the eM= MC > ? >=20 > > > > So we need to make > > > > changes in subsystems they use so that they can continue to work. > > > >=20 > > > > So, are the changes being proposed to the generic USB code, such th= at > > > > DM_USB can be enabled, and when DM_USB_GADGET gets a deadline (Note, > > > > that's not set yet, but that's not to say never, it's just not been= set, > > > > so getting ahead of problems here would be appreciated) that can al= so be > > > > enabled, OK? > > >=20 > > > I am confused by this reply. I noticed a lot of boards were removed o= ver > > > time because they were not converted to DM/DT, and to get rid of all = the > > > ifdefs, but now it seems the direction has been completely reversed a= nd we > > > should start adding back all the ifdefs to cater for boards which are= not > > > converted instead of fixing the boards ? > >=20 > > A lot of boards are being removed because no one wants to update and > > maintain them and they have likely not been run-time tested in years. > > Trying to clean up the code in those cases is best done by removing the > > platform, as no one using it. That is not the case here. >=20 > Note that there have been boards which had to be switched to SPL to even > permit converting them to DM/DT, and thus prevent removal. >=20 > > If your only > > concern about the approach taken is some #ifdef's in the code, do you > > want to see them converted to use some wrapper macro like we do in a few > > other cases and __maybe_unused some functions as needed? >=20 > I think there is a better option which does not add any ifdefs at all _an= d_ > is future-proof -- place SPL in those 256 kiB, load U-Boot from eMMC and > then enable all the functionality you might need in U-Boot. That would fr= ee > you from dealing with the size limitations basically indefinitely. So, at this point I'm waiting for either of: - A response to Marek's questions about using SPL, from the Nokia NX51 folks. - A patch to rework things so that USB gadget support more cleanly removes from the code paths non-gadget code, so there's no #if's being added here. Or some similar clean-up. --=20 Tom --PLe3xFgSmS0d151j Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDVzlMACgkQFHw5/5Y0 tyzE+Qv/UuOKR6SQn3wsTlyRTIOn7VFHD3ZrHvMUuCekAowOa4/AciRi/jLZeDyX ASHEJ9O5mkY/gz7yz/4QmVtaPJZxX6BqxoXdz2wEQHAzMB4R/jopAr4AExCfOlyr 2djFb1E2qBYaiASKBCxyXowuzokh9cnKPHvHCVZ0EE4POAO2v0zcm6lqECixjbxv ISL6JjC/gaEjC+Cp8D+23Nf2w7YVxDYEzxfFKFZNpfK+ZQV71jDGnpsvdfHPaPVe zo5tVtZb0yDIOot65dEDPytodjk5Mj/7lPJFOK4beCbSqd+mwQEExKHYfNrd18IE OO37k/p8iFY5bWduFgeNL3fEQrgKeBuTHnOY+kvERhKkzZP/uIt11aMDak5+A0qg T/qnsYQpsP5k6LKMFjAMF5cWSpWU4COPEvT3gOcxorE/79W6Y8T22aXuz8KRXuDO gifQIbRHKYj5t5fs+oC9O7jnCioe86BQj0/hWtmLTJumbdKe8JaEkD1V9zWxNt8Z L5UhMRen =Dk78 -----END PGP SIGNATURE----- --PLe3xFgSmS0d151j--