Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 720B6C11F67 for ; Tue, 29 Jun 2021 23:33:17 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9BC0E61C74 for ; Tue, 29 Jun 2021 23:33:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BC0E61C74 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9D43583206; Wed, 30 Jun 2021 01:33:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 0BAAD8320A; Wed, 30 Jun 2021 01:33:13 +0200 (CEST) Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2046483204 for ; Wed, 30 Jun 2021 01:33:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=tom.rini@gmail.com Received: by mail-qt1-f172.google.com with SMTP id f20so103482qtk.10 for ; Tue, 29 Jun 2021 16:33:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=7HLnQHyTzMLJ/ev+Nm7wzdKsLUiVE1Y6LZAKATEGiLY=; b=Mv3V7k19waKeCOvL9cOLQpXB3S5OpCbkmx/0+onM2mSN1kM7FR9tD2OBRBeaWbUW6C 55IjGQiUWKQEDJ2F7VQ3JspvJW7X283qhyWhT4Qrt72ysK9Q+mnrfNlecRwp/cLdGXPt Kuy0b9KQdQi1AyA8yyJ9cypMNU5eRgHuZ2vjgJHP7eo0cMZMOFt2XJjGAlE6vnv0Mzlh hR1sxQPwVSrKIzxx+jyi6hAKieOKMxDXnyF0R5PCf70JvmaNzfi6QoCJbZkXNiaA9G9N GfVCKJiNJeJnyScHxNa6nGuQa+8bo4bkS1oNMOovWna81rE+klcezWu1wTbzJG/6t669 hBVQ== X-Gm-Message-State: AOAM5308d/LiaX+oC0eFgD2vOfCFZ030fm51IOilnv0a8LG4bRqxQCoh A+sAcAV/lXlpgmSAfVS/z1ht0L8Nejzz X-Google-Smtp-Source: ABdhPJwXsIbKI76tXyisI2t/BTxRyb2si+zW516qM4X2J0GqGjmUvp/RYF+FpimrI5fHDKNWvUsrLg== X-Received: by 2002:ac8:5cd5:: with SMTP id s21mr12180358qta.192.1625009588382; Tue, 29 Jun 2021 16:33:08 -0700 (PDT) Received: from bill-the-cat.lan (2603-6081-7b01-cbda-ed48-3ab5-19c4-9a46.res6.spectrum.com. [2603:6081:7b01:cbda:ed48:3ab5:19c4:9a46]) by smtp.gmail.com with ESMTPSA id 189sm12834748qkh.45.2021.06.29.16.33.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Jun 2021 16:33:07 -0700 (PDT) From: Tom Rini To: u-boot@lists.denx.de Subject: [PATCH] arm: armv8: Fix warning about redeclaring global functions as weak Date: Tue, 29 Jun 2021 19:33:04 -0400 Message-Id: <20210629233304.6117-1-trini@konsulko.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean As seen with clang-12: warning: __asm_invalidate_l3_dcache changed binding to STB_WEAK As we indeed use ENTRY and then declare the function weak manually. Use the WEAK declarative from instead. Signed-off-by: Tom Rini --- arch/arm/cpu/armv8/cache.S | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/arch/arm/cpu/armv8/cache.S b/arch/arm/cpu/armv8/cache.S index 443d94c262a0..e04907dd8c0b 100644 --- a/arch/arm/cpu/armv8/cache.S +++ b/arch/arm/cpu/armv8/cache.S @@ -188,27 +188,24 @@ ENDPROC(__asm_invalidate_icache_all) .popsection .pushsection .text.__asm_invalidate_l3_dcache, "ax" -ENTRY(__asm_invalidate_l3_dcache) +WEAK(__asm_invalidate_l3_dcache) mov x0, #0 /* return status as success */ ret ENDPROC(__asm_invalidate_l3_dcache) - .weak __asm_invalidate_l3_dcache .popsection .pushsection .text.__asm_flush_l3_dcache, "ax" -ENTRY(__asm_flush_l3_dcache) +WEAK(__asm_flush_l3_dcache) mov x0, #0 /* return status as success */ ret ENDPROC(__asm_flush_l3_dcache) - .weak __asm_flush_l3_dcache .popsection .pushsection .text.__asm_invalidate_l3_icache, "ax" -ENTRY(__asm_invalidate_l3_icache) +WEAK(__asm_invalidate_l3_icache) mov x0, #0 /* return status as success */ ret ENDPROC(__asm_invalidate_l3_icache) - .weak __asm_invalidate_l3_icache .popsection /* -- 2.17.1