Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NORMAL_HTTP_TO_IP,NUMERIC_HTTP_ADDR, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25D9EC07E99 for ; Fri, 9 Jul 2021 16:31:12 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 759096139A for ; Fri, 9 Jul 2021 16:31:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 759096139A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 029CC831D2; Fri, 9 Jul 2021 18:31:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="tUM/BJw4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 28A488321A; Fri, 9 Jul 2021 18:31:07 +0200 (CEST) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 00F74831A4 for ; Fri, 9 Jul 2021 18:31:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x832.google.com with SMTP id g12so7998503qtb.2 for ; Fri, 09 Jul 2021 09:31:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=koXmdvUPoSGW0RsrI/ND05E0/NNbK/sHn4udS5P5210=; b=tUM/BJw4YVsZbQoPxOBodrBfCNvxN1ln0HDBw0eawRSBDg4QWhvFZBv19qUVpGKjJ+ ETyx6tqt8PTR6j2W+k93u1LHKjRCKgeeizEHkFpD6zt7TkamVPm4JDKz/pGr0vyA0fUY OS6I0kqqd03etz66CWHyiBSbTXL2CbBq2Qe1k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=koXmdvUPoSGW0RsrI/ND05E0/NNbK/sHn4udS5P5210=; b=aOEVcjc7CvfBQRTfY26b+ErvPaF0rJa5L+s1yZZgXvM15Oqx5ypYitLYPcdm50uSwo SSf9se/3Cicn2cy/0GAp5kDJQql/74qVXEeJDiek6ClgzXg7J6urCqwlPf1CMzRi0OfT IAz5i2jXjBZdF8B48WEJnI4ucYOF/5bQ+pyeNjkpUdcaCIDD+DtdXM1O5EpM/QG8KzZh dNdqByugL2JBF+I6OaRACDpuzuGTYCJAMuoc239stncut2Kf08G7wg0vPaaB4aFU0kUz uY8CXrE4ZNCPFidkWVp3NbDh+7mi+gI0n9A0HWF5oKtBY8uknNcX9NSLMe0JLF7pY1+t CJhA== X-Gm-Message-State: AOAM530TtkI+x2+Y+UIMygH9PCzaNZIm1ZkTctrXnIQrsxbduKV5Ijwh su4l/vHYeg9XTu7cXKu4jFBRfQ== X-Google-Smtp-Source: ABdhPJwxHbG3zsBSTrmrK027ysx5CRoN9PfgnCsI/kCMBsZJPT2Qhhqe8xMHCxC/aPzRiEsvUhJV7g== X-Received: by 2002:ac8:602:: with SMTP id d2mr35914487qth.146.1625848260841; Fri, 09 Jul 2021 09:31:00 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-1083-622a-b9ec-c6c6.res6.spectrum.com. [2603:6081:7b01:cbda:1083:622a:b9ec:c6c6]) by smtp.gmail.com with ESMTPSA id i21sm2663624qkl.20.2021.07.09.09.31.00 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 09 Jul 2021 09:31:00 -0700 (PDT) Date: Fri, 9 Jul 2021 12:30:58 -0400 From: Tom Rini To: Trevor Woerner Cc: U-Boot Mailing List Subject: Re: [PATCH] get_maintainer.pl: update from Linux kernel v5.13-rc6 Message-ID: <20210709163058.GJ9516@bill-the-cat> References: <20210615073029.39312-1-twoerner@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7/RBRHXQzbLI2rru" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --7/RBRHXQzbLI2rru Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 08, 2021 at 08:22:35AM -0400, Trevor Woerner wrote: > ping? >=20 > Tom, have you had a chance to try out this update? Thanks, I need to do a build/related PR shortly and I'll pick this up then. >=20 > On Tue, Jun 15, 2021 at 3:30 AM Trevor Woerner wrote: >=20 > > Update U-Boot's version of scripts/get_maintainer.pl to sync it up with > > the > > latest changes to the Linux kernel's version of the same script. > > > > The last sync was with Linux kernel version v4.16. The commits to the > > kernel's > > get_maintainer.pl since then (starting with the most recent) are: > > > > 6343f6b71f83 get_maintainer: exclude MAINTAINERS file(s) from > > --git-fallback > > cdfe2d220476 get_maintainer: add test for file in VCS > > e33c9fe8b80c get_maintainer: fix unexpected behavior for > > path/to//file (double slashes) > > 0c78c0137621 get_maintainer: add email addresses from .yaml fil= es > > 0ef82fcefb99 scripts/get_maintainer.pl: deprioritize old Fixes: > > addresses > > ef0c08192ac0 get_maintainer: remove uses of P: for maintainer n= ame > > 2f5bd343694e scripts/get_maintainer.pl: add signatures from > > Fixes: lines in commit message > > 49662503e8e4 get_maintainer: add ability to skip moderated mail= ing > > lists > > 0fbd75fd7fee get_maintainer: allow option --mpath to > > read all files in > > 5f0baf95b1ed get_maintainer.pl: add -mpath=3D for > > MAINTAINERS file location > > 31bb82c9caa9 get_maintainer: allow usage outside of kernel tree > > 0455c74788fd get_maintainer: improve patch recognition > > 882ea1d64eb3 scripts: use SPDX tag in get_maintainer and checkp= atch > > > > Signed-off-by: Trevor Woerner > > --- > > scripts/get_maintainer.pl | 204 +++++++++++++++++++++++++------------- > > 1 file changed, 134 insertions(+), 70 deletions(-) > > > > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl > > index e3b41616c9..81116e215e 100755 > > --- a/scripts/get_maintainer.pl > > +++ b/scripts/get_maintainer.pl > > @@ -1,4 +1,6 @@ > > #!/usr/bin/env perl > > +# SPDX-License-Identifier: GPL-2.0 > > +# > > # (c) 2007, Joe Perches > > # created from checkpatch.pl > > # > > @@ -7,8 +9,6 @@ > > # > > # usage: perl scripts/get_maintainer.pl [OPTIONS] > > # perl scripts/get_maintainer.pl [OPTIONS] -f > > -# > > -# Licensed under the terms of the GNU GPL License version 2 > > > > use warnings; > > use strict; > > @@ -19,6 +19,7 @@ my $V =3D '0.26'; > > use Getopt::Long qw(:config no_auto_abbrev); > > use Cwd; > > use File::Find; > > +use File::Spec::Functions; > > > > my $cur_path =3D fastgetcwd() . '/'; > > my $lk_path =3D "./"; > > @@ -26,7 +27,9 @@ my $email =3D 1; > > my $email_usename =3D 1; > > my $email_maintainer =3D 1; > > my $email_reviewer =3D 1; > > +my $email_fixes =3D 1; > > my $email_list =3D 1; > > +my $email_moderated_list =3D 1; > > my $email_subscriber_list =3D 0; > > my $email_git_penguin_chiefs =3D 0; > > my $email_git =3D 0; > > @@ -48,24 +51,31 @@ my $output_roles =3D 0; > > my $output_rolestats =3D 1; > > my $output_section_maxlen =3D 50; > > my $scm =3D 0; > > +my $tree =3D 1; > > my $web =3D 0; > > my $subsystem =3D 0; > > my $status =3D 0; > > my $letters =3D ""; > > my $keywords =3D 1; > > my $sections =3D 0; > > -my $file_emails =3D 0; > > +my $email_file_emails =3D 0; > > my $from_filename =3D 0; > > my $pattern_depth =3D 0; > > my $self_test =3D undef; > > my $version =3D 0; > > my $help =3D 0; > > -my $find_maintainer_files =3D 1; > > - > > +my $find_maintainer_files =3D 0; > > +my $maintainer_path; > > my $vcs_used =3D 0; > > > > my $exit =3D 0; > > > > +my @files =3D (); > > +my @fixes =3D (); # If a patch description incl= udes > > Fixes: lines > > +my @range =3D (); > > +my @keyword_tvi =3D (); > > +my @file_emails =3D (); > > + > > my %commit_author_hash; > > my %commit_signer_hash; > > > > @@ -245,6 +255,8 @@ if (!GetOptions( > > 'r!' =3D> \$email_reviewer, > > 'n!' =3D> \$email_usename, > > 'l!' =3D> \$email_list, > > + 'fixes!' =3D> \$email_fixes, > > + 'moderated!' =3D> \$email_moderated_list, > > 's!' =3D> \$email_subscriber_list, > > 'multiline!' =3D> \$output_multiline, > > 'roles!' =3D> \$output_roles, > > @@ -253,14 +265,16 @@ if (!GetOptions( > > 'subsystem!' =3D> \$subsystem, > > 'status!' =3D> \$status, > > 'scm!' =3D> \$scm, > > + 'tree!' =3D> \$tree, > > 'web!' =3D> \$web, > > 'letters=3Ds' =3D> \$letters, > > 'pattern-depth=3Di' =3D> \$pattern_depth, > > 'k|keywords!' =3D> \$keywords, > > 'sections!' =3D> \$sections, > > - 'fe|file-emails!' =3D> \$file_emails, > > + 'fe|file-emails!' =3D> \$email_file_emails, > > 'f|file' =3D> \$from_filename, > > 'find-maintainer-files' =3D> \$find_maintainer_files, > > + 'mpath|maintainer-path=3Ds' =3D> \$maintainer_path, > > 'self-test:s' =3D> \$self_test, > > 'v|version' =3D> \$version, > > 'h|help|usage' =3D> \$help, > > @@ -317,7 +331,7 @@ if ($email && > > die "$P: Please select at least 1 email option\n"; > > } > > > > -if (!top_of_kernel_tree($lk_path)) { > > +if ($tree && !top_of_kernel_tree($lk_path)) { > > die "$P: The current directory does not appear to be " > > . "a U-Boot source tree.\n"; > > } > > @@ -382,26 +396,52 @@ sub find_ignore_git { > > read_all_maintainer_files(); > > > > sub read_all_maintainer_files { > > - if (-d "${lk_path}MAINTAINERS") { > > - opendir(DIR, "${lk_path}MAINTAINERS") or die $!; > > - my @files =3D readdir(DIR); > > - closedir(DIR); > > - foreach my $file (@files) { > > - push(@mfiles, "${lk_path}MAINTAINERS/$file") if ($file !~ > > /^\./); > > - } > > - } > > - > > - if ($find_maintainer_files) { > > - find( { wanted =3D> \&find_is_maintainer_file, > > - preprocess =3D> \&find_ignore_git, > > - no_chdir =3D> 1, > > - }, "${lk_path}"); > > + my $path =3D "${lk_path}MAINTAINERS"; > > + if (defined $maintainer_path) { > > + $path =3D $maintainer_path; > > + # Perl Cookbook tilde expansion if necessary > > + $path =3D~ s@^~([^/]*)@ $1 ? (getpwnam($1))[7] : ( $ENV{HOME} || > > $ENV{LOGDIR} || (getpwuid($<))[7])@ex; > > + } > > + > > + if (-d $path) { > > + $path .=3D '/' if ($path !~ m@/$@); > > + if ($find_maintainer_files) { > > + find( { wanted =3D> \&find_is_maintainer_file, > > + preprocess =3D> \&find_ignore_git, > > + no_chdir =3D> 1, > > + }, "$path"); > > + } else { > > + opendir(DIR, "$path") or die $!; > > + my @files =3D readdir(DIR); > > + closedir(DIR); > > + foreach my $file (@files) { > > + push(@mfiles, "$path$file") if ($file !~ /^\./); > > + } > > + } > > + } elsif (-f "$path") { > > + push(@mfiles, "$path"); > > } else { > > - push(@mfiles, "${lk_path}MAINTAINERS") if -f > > "${lk_path}MAINTAINERS"; > > + die "$P: MAINTAINER file not found '$path'\n"; > > } > > - > > + die "$P: No MAINTAINER files found in '$path'\n" if (scalar(@mfile= s) > > =3D=3D 0); > > foreach my $file (@mfiles) { > > - read_maintainer_file("$file"); > > + read_maintainer_file("$file"); > > + } > > +} > > + > > +sub maintainers_in_file { > > + my ($file) =3D @_; > > + > > + return if ($file =3D~ m@\bMAINTAINERS$@); > > + > > + if (-f $file && ($email_file_emails || $file =3D~ /\.yaml$/)) { > > + open(my $f, '<', $file) > > + or die "$P: Can't open $file: $!\n"; > > + my $text =3D do { local($/) ; <$f> }; > > + close($f); > > + > > + my @poss_addr =3D $text =3D~ m$[A-Za-z=C0-=FF\"\' > > \,\.\+-]*\s*[\,]*\s*[\(\<\{]{0,1}[A-Za-z0-9_\.\+-]+\@[A-Za-z0-9\.-]+\.[= A-Za-z0-9]+[\)\>\}]{0,1}$g; > > + push(@file_emails, clean_file_emails(@poss_addr)); > > } > > } > > > > @@ -485,17 +525,13 @@ sub read_mailmap { > > > > ## use the filenames on the command line or find the filenames in the > > patchfiles > > > > -my @files =3D (); > > -my @range =3D (); > > -my @keyword_tvi =3D (); > > -my @file_emails =3D (); > > - > > if (!@ARGV) { > > push(@ARGV, "&STDIN"); > > } > > > > foreach my $file (@ARGV) { > > if ($file ne "&STDIN") { > > + $file =3D canonpath($file); > > ##if $file is a directory and it lacks a trailing slash, add one > > if ((-d $file)) { > > $file =3D~ s@([^/])$@$1/@; > > @@ -503,11 +539,14 @@ foreach my $file (@ARGV) { > > die "$P: file '${file}' not found\n"; > > } > > } > > + if ($from_filename && (vcs_exists() && !vcs_file_exists($file))) { > > + warn "$P: file '$file' not found in version control $!\n"; > > + } > > if ($from_filename || ($file ne "&STDIN" && vcs_file_exists($file)= )) { > > $file =3D~ s/^\Q${cur_path}\E//; #strip any absolute path > > $file =3D~ s/^\Q${lk_path}\E//; #or the path to the lk tree > > push(@files, $file); > > - if ($file ne "MAINTAINERS" && -f $file && ($keywords || > > $file_emails)) { > > + if ($file ne "MAINTAINERS" && -f $file && $keywords) { > > open(my $f, '<', $file) > > or die "$P: Can't open $file: $!\n"; > > my $text =3D do { local($/) ; <$f> }; > > @@ -519,10 +558,6 @@ foreach my $file (@ARGV) { > > } > > } > > } > > - if ($file_emails) { > > - my @poss_addr =3D $text =3D~ m$[A-Za-z=C0-=FF\"\' > > \,\.\+-]*\s*[\,]*\s*[\(\<\{]{0,1}[A-Za-z0-9_\.\+-]+\@[A-Za-z0-9\.-]+\.[= A-Za-z0-9]+[\)\>\}]{0,1}$g; > > - push(@file_emails, clean_file_emails(@poss_addr)); > > - } > > } > > } else { > > my $file_cnt =3D @files; > > @@ -540,7 +575,20 @@ foreach my $file (@ARGV) { > > > > while (<$patch>) { > > my $patch_line =3D $_; > > - if (m/^\+\+\+\s+(\S+)/ or m/^---\s+(\S+)/) { > > + if (m/^ mode change [0-7]+ =3D> [0-7]+ (\S+)\s*$/) { > > + my $filename =3D $1; > > + push(@files, $filename); > > + } elsif (m/^rename (?:from|to) (\S+)\s*$/) { > > + my $filename =3D $1; > > + push(@files, $filename); > > + } elsif (m/^diff --git a\/(\S+) b\/(\S+)\s*$/) { > > + my $filename1 =3D $1; > > + my $filename2 =3D $2; > > + push(@files, $filename1); > > + push(@files, $filename2); > > + } elsif (m/^Fixes:\s+([0-9a-fA-F]{6,40})/) { > > + push(@fixes, $1) if ($email_fixes); > > + } elsif (m/^\+\+\+\s+(\S+)/ or m/^---\s+(\S+)/) { > > my $filename =3D $1; > > $filename =3D~ s@^[^/]*/@@; > > $filename =3D~ s@\n@@; > > @@ -570,6 +618,7 @@ foreach my $file (@ARGV) { > > } > > > > @file_emails =3D uniq(@file_emails); > > +@fixes =3D uniq(@fixes); > > > > my %email_hash_name; > > my %email_hash_address; > > @@ -584,7 +633,6 @@ my %deduplicate_name_hash =3D (); > > my %deduplicate_address_hash =3D (); > > > > my @maintainers =3D get_maintainers(); > > - > > if (@maintainers) { > > @maintainers =3D merge_email(@maintainers); > > output(@maintainers); > > @@ -890,6 +938,8 @@ sub get_maintainers { > > print("\n"); > > } > > } > > + > > + maintainers_in_file($file); > > } > > > > if ($keywords) { > > @@ -905,8 +955,10 @@ sub get_maintainers { > > > > foreach my $file (@files) { > > if ($email && > > - ($email_git || ($email_git_fallback && > > - !$exact_pattern_match_hash{$file}))) { > > + ($email_git || > > + ($email_git_fallback && > > + $file !~ /MAINTAINERS$/ && > > + !$exact_pattern_match_hash{$file}))) { > > vcs_file_signoffs($file); > > } > > if ($email && $email_git_blame) { > > @@ -937,6 +989,10 @@ sub get_maintainers { > > } > > } > > > > + foreach my $fix (@fixes) { > > + vcs_add_commit_signers($fix, "blamed_fixes"); > > + } > > + > > my @to =3D (); > > if ($email || $email_list) { > > if ($email) { > > @@ -997,11 +1053,13 @@ MAINTAINER field selection options: > > --r =3D> include reviewer(s) if any > > --n =3D> include name 'Full Name ' > > --l =3D> include list(s) if any > > - --s =3D> include subscriber only list(s) if any > > + --moderated =3D> include moderated lists(s) if any (default: true) > > + --s =3D> include subscriber only list(s) if any (default: false) > > --remove-duplicates =3D> minimize duplicate email names/addresses > > --roles =3D> show roles (status:subsystem, git-signer, list, etc..= =2E) > > --rolestats =3D> show roles and statistics (commits/total_commits,= %) > > --file-emails =3D> add email addresses found in -f file (default: 0 > > (off)) > > + --fixes =3D> for patches, add signatures of commits with 'Fixes: > > ' (default: 1 (on)) > > --scm =3D> print SCM tree(s) if any > > --status =3D> print status if any > > --subsystem =3D> print subsystem name if any > > @@ -1018,13 +1076,14 @@ Other options: > > --sections =3D> print all of the subsystem sections with pattern mat= ches > > --letters =3D> print all matching 'letter' types from all matching > > sections > > --mailmap =3D> use .mailmap file (default: $email_use_mailmap) > > + --no-tree =3D> run without a kernel tree > > --self-test =3D> show potential issues with MAINTAINERS file content > > --version =3D> show version > > --help =3D> show this help information > > > > Default options: > > - [--email --nogit --git-fallback --m --r --n --l --multiline > > --pattern-depth=3D0 > > - --remove-duplicates --rolestats] > > + [--email --tree --nogit --git-fallback --m --r --n --l --multiline > > + --pattern-depth=3D0 --remove-duplicates --rolestats] > > > > Notes: > > Using "-f directory" may give unexpected results: > > @@ -1288,11 +1347,14 @@ sub add_categories { > > } else { > > if ($email_list) { > > if (!$hash_list_to{lc($list_address)}) { > > - $hash_list_to{lc($list_address)} =3D 1; > > if ($list_additional =3D~ m/moderated/) { > > - push(@list_to, [$list_address, > > - "moderated > > list${list_role}"]); > > + if ($email_moderated_list) { > > + $hash_list_to{lc($list_address)} = =3D 1; > > + push(@list_to, [$list_address, > > + "moderated > > list${list_role}"]); > > + } > > } else { > > + $hash_list_to{lc($list_address)} =3D 1; > > push(@list_to, [$list_address, > > "open list${list_role}"= ]); > > } > > @@ -1300,35 +1362,11 @@ sub add_categories { > > } > > } > > } elsif ($ptype eq "M") { > > - my ($name, $address) =3D parse_email($pvalue); > > - if ($name eq "") { > > - if ($i > 0) { > > - my $tv =3D $typevalue[$i - 1]; > > - if ($tv =3D~ m/^([A-Z]):\s*(.*)/) { > > - if ($1 eq "P") { > > - $name =3D $2; > > - $pvalue =3D format_email($name, $addres= s, > > $email_usename); > > - } > > - } > > - } > > - } > > if ($email_maintainer) { > > my $role =3D get_maintainer_role($i); > > push_email_addresses($pvalue, $role); > > } > > } elsif ($ptype eq "R") { > > - my ($name, $address) =3D parse_email($pvalue); > > - if ($name eq "") { > > - if ($i > 0) { > > - my $tv =3D $typevalue[$i - 1]; > > - if ($tv =3D~ m/^([A-Z]):\s*(.*)/) { > > - if ($1 eq "P") { > > - $name =3D $2; > > - $pvalue =3D format_email($name, $addres= s, > > $email_usename); > > - } > > - } > > - } > > - } > > if ($email_reviewer) { > > my $subsystem =3D get_subsystem_name($i); > > push_email_addresses($pvalue, "reviewer:$subsystem"= ); > > @@ -1699,6 +1737,32 @@ sub vcs_is_hg { > > return $vcs_used =3D=3D 2; > > } > > > > +sub vcs_add_commit_signers { > > + return if (!vcs_exists()); > > + > > + my ($commit, $desc) =3D @_; > > + my $commit_count =3D 0; > > + my $commit_authors_ref; > > + my $commit_signers_ref; > > + my $stats_ref; > > + my @commit_authors =3D (); > > + my @commit_signers =3D (); > > + my $cmd; > > + > > + $cmd =3D $VCS_cmds{"find_commit_signers_cmd"}; > > + $cmd =3D~ s/(\$\w+)/$1/eeg; #substitute variables in $cmd > > + > > + ($commit_count, $commit_signers_ref, $commit_authors_ref, $stats_r= ef) > > =3D vcs_find_signers($cmd, ""); > > + @commit_authors =3D @{$commit_authors_ref} if defined > > $commit_authors_ref; > > + @commit_signers =3D @{$commit_signers_ref} if defined > > $commit_signers_ref; > > + > > + foreach my $signer (@commit_signers) { > > + $signer =3D deduplicate_email($signer); > > + } > > + > > + vcs_assign($desc, 1, @commit_signers); > > +} > > + > > sub interactive_get_maintainers { > > my ($list_ref) =3D @_; > > my @list =3D @$list_ref; > > @@ -1792,7 +1856,7 @@ tm toggle maintainers > > tg toggle git entries > > tl toggle open list entries > > ts toggle subscriber list entries > > -f emails in file [$file_emails] > > +f emails in file [$email_file_emails] > > k keywords in file [$keywords] > > r remove duplicates [$email_remove_duplicates] > > p# pattern match depth [$pattern_depth] > > @@ -1917,7 +1981,7 @@ EOT > > bool_invert(\$email_git_all_signature_types); > > $rerun =3D 1; > > } elsif ($sel eq "f") { > > - bool_invert(\$file_emails); > > + bool_invert(\$email_file_emails); > > $rerun =3D 1; > > } elsif ($sel eq "r") { > > bool_invert(\$email_remove_duplicates); > > -- > > 2.30.0.rc0 > > > > --=20 Tom --7/RBRHXQzbLI2rru Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDoecIACgkQFHw5/5Y0 tywOJgv9Hl+cP5xrT0CgnR1F2jmQjRy/cN+btw2wE9cgzAuDJuWddq3tte+9CtL4 bLxJdVKPbG5BenwMuvw/mPhfe91zP4sUwzdM0STvfIR17CcokekkS0ejTGPPOcmF 2NoFVrxas2GZvK+f+mg4Xdr6PsYit15S2mdGu/G/UvFmcENIHIows0ggM07XJkga Y5ZvxcfPzxe/2HSO31IdYSUMwRElC74PtrkiQFMxPNoSV4zusZZF/Yhdjdzqg6Tj XXpJI+BoiPbcC4EHHEvTocnzAngHxpaxIXya2NnUPEH/5mWT0ISxzEjU/66v26zo nbYxkAbEhkgzy9awi15dwe5Y2Y8RBAtCh/fTjFBzak+Tvp42NZ/NTet7j2VMpjSI FZQ0bNvMOUIntathQTfFyxBhDS/t5zbdT4uH96nKckH6AZtfNIBSFGit7UFfNTvm l0vncIEhphA87LeEXn7xzwZwTwgLI5SGIMeFL4Qq9hLzv3+0i45vmn9Z4/SWgTnK YCFMwI0v =pQsc -----END PGP SIGNATURE----- --7/RBRHXQzbLI2rru--