Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA7AFC12002 for ; Wed, 14 Jul 2021 20:53:35 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3376F613D0 for ; Wed, 14 Jul 2021 20:53:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3376F613D0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D6D4782003; Wed, 14 Jul 2021 22:53:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Qggmeqwx"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9737682BFA; Wed, 14 Jul 2021 22:52:41 +0200 (CEST) Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id ADBE282BD2 for ; Wed, 14 Jul 2021 22:52:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x730.google.com with SMTP id r125so3049813qkf.1 for ; Wed, 14 Jul 2021 13:52:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9+600vJuJAiyOfAOwZqCmMLp0h6WWeAmsU+mM9NdGuI=; b=Qggmeqwxv4BFJkN8RyyAKuZbEL3w2eY6JGyN08PjmaB1pao8WABI5E0od6+TA3U5H2 PCD/VmC8HyFIFiGcTSH59f+bEUljQXbr5H1WzZSCUTjTOewYmfCjd6TVwVTqShXF25Dg 4cdKCNGuAnqv5tUJ5AiaHUqdn+BFpAteCtjqY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9+600vJuJAiyOfAOwZqCmMLp0h6WWeAmsU+mM9NdGuI=; b=bczs68uzZIx+YNssKC1ZDaGoCxgV5y1zQICpgb1QJt5E3NhQ6bPcguGRFssw/z3Zsu 452Gakmkynv5Xgw29WcQKcju2HhVoCE65V/l3ukda3WyZeph2mGl2mTmfciY2zaJHK6J oxD41YjQkifvY4KpKiyjUBFbkrDNeHBNmT0abZiRgDIPE6l5CjUZfKCPTFupvakV7KQI 7JnQYIWWO9ybZ9QzGODUWN5bbO9n0jXvvv8quY/lkCFkgVoed33EPwB13xDCoIFuJqGU /wTF3UTCs08dsBy75Ei4qY8loXIJjIjsPq3wqfw4wfZFujZ1K0OM3CyVz/j0HXxobHzt 9+TQ== X-Gm-Message-State: AOAM531+n6kPPZJNkA4vafe14NdQnCLk4GORZAIcKD4FkM4rgG/mQHJ+ 9I3cXp3DP0BzivhJUr79KpYwsw== X-Google-Smtp-Source: ABdhPJy42oWxRJfq5mYUnrIxSLkgCB9FJOxzxXPQrBxgCsogTpIGyWx0oD0qZoiS2a1nkoEESerOxQ== X-Received: by 2002:a37:9543:: with SMTP id x64mr4024415qkd.217.1626295949576; Wed, 14 Jul 2021 13:52:29 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-715c-901d-db03-e6e4.res6.spectrum.com. [2603:6081:7b01:cbda:715c:901d:db03:e6e4]) by smtp.gmail.com with ESMTPSA id 12sm1537646qkr.10.2021.07.14.13.52.28 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Jul 2021 13:52:29 -0700 (PDT) Date: Wed, 14 Jul 2021 16:52:27 -0400 From: Tom Rini To: Marek Vasut Cc: u-boot@lists.denx.de, Marek Vasut , Marcel Ziswiler , Simon Glass Subject: Re: [PATCH 2/2] board-info: Call sysinfo_detect() before sysinfo_get_str() Message-ID: <20210714205227.GV9516@bill-the-cat> References: <20210704193205.84356-1-marek.vasut+renesas@gmail.com> <20210704193205.84356-2-marek.vasut+renesas@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FGT1B4ZV98/6zpcn" Content-Disposition: inline In-Reply-To: <20210704193205.84356-2-marek.vasut+renesas@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --FGT1B4ZV98/6zpcn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 04, 2021 at 09:32:05PM +0200, Marek Vasut wrote: > The sysinfo_get_str() implementation checks whether the sysinfo was even > detected. In U-Boot proper, sysinfo_detect() is not called anywhere but > on one specific board. Call sysinfo_detect() before sysinfo_get_str() to > make sure the sysinfo is detected and sysinfo_get_str() returns valid > value instead of -EPERM. >=20 > Signed-off-by: Marek Vasut > Cc: Marcel Ziswiler > Cc: Simon Glass > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! --=20 Tom --FGT1B4ZV98/6zpcn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDvTooACgkQFHw5/5Y0 tywLmQwAogP+rh7ZXv3u4sPWwrazFJHV7SC7cUt1ZDVLniGZZam3pkifLcf6yVMY FMTcwNEfd3V60hpSS5nv+hL5WTTLi9MyU+4QavIzVoFr9cD3cSmQVp4R0C7C2pBV OEn/9V6iY0KS+IKj7blw4El4ORWFV4MadQGqN6a0SG8ncctNUDtaXfjdLYtvxO4d mIPdisTT7wwk9gPhIbOOaRMNIcC2a3rEVzmUN3P2HAOm/jL3gV51bCnjlIr2ps8b S+zwNZtobTXtrT082stfW/Cu+ifMPJ979ZkTWHsxe4ITDIAYMmeBT5LA7nCKmqge EpS+QkPwMymut2S2/aaLNcpRm+XkoGYALE3DsD1BYmtypPjnMIXl3P3nOUkthYZW Cb81YcHaj2s0l0uF5T6GMyoxg1k9jyOEHS78/2+Et5X5uvGqPNPitta68chtYN87 OSfcLdspQ55CBuyAxvh92Ftyan+RkDIE2Syllxe920GPdkvqqbKhZU/bX6DE6zV3 A8G/sUY8 =75bA -----END PGP SIGNATURE----- --FGT1B4ZV98/6zpcn--