Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8A30C1B08C for ; Wed, 14 Jul 2021 20:56:49 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 459D7613D0 for ; Wed, 14 Jul 2021 20:56:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 459D7613D0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9DE698320F; Wed, 14 Jul 2021 22:54:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="ULjycIn6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E95CE829C7; Wed, 14 Jul 2021 22:53:31 +0200 (CEST) Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0361B82003 for ; Wed, 14 Jul 2021 22:53:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x829.google.com with SMTP id c13so257911qtc.10 for ; Wed, 14 Jul 2021 13:53:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/s4Oh/r7wHHRxaLzMpbcw/wWqPfeFhrPIOvaKayQ134=; b=ULjycIn64jklSXmeal0PoxqDWVa98jVvfP5RMzsoU/sDuuUWkhmHuXoXkZCNKC/6V+ t8bnFiB6tK95kJ7HytYFx60tdj6NsEKKHzf1453YnMUyKrGrdKcloRlEehkfzjTWsE4y 7ag+aEQye6GoYDoOjjJ16SPVMwmVDnCfNcUY4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/s4Oh/r7wHHRxaLzMpbcw/wWqPfeFhrPIOvaKayQ134=; b=QH0MT0dLoLco1JpZ/CfUz+1jqNugqAqVgFScDXun9cB/ju99pOJIlRcatfHZf2QwbW hEldRB74Ymz6kK0wKVBt+X21ZfYEtnb75Sd+UfRjJwCkjS9sztHmQkAR3cqKT+WHgkQm 87xc/wn0PB+UHJ9Qrb8iJd9Vl5P5lAF/SpbUX0j6vkqD6vxcOX4SntCn8vPnIshtFCuN Obg0i2r0fTxqGbVMpRZ85FCfy1ewc1Xr9EOCeugPXiOEqs4SoVrMs536XuwPcH78/l0Q vYudBXbaBJbFhT3uOmjqh9SESw+EGYveDR8urn01sQinnM81yBNaa0ZUcixjPWHBsYpi nlTQ== X-Gm-Message-State: AOAM5337xlzL0zzk+xfngKwYbLQTr4MkaBTueVk0xpo3aVJEj0Lo3xhe XepUpJ4/7kg7xaUJpI+6v7nP6Q== X-Google-Smtp-Source: ABdhPJwTDCy3OguKcQGWoATEUIdTTWQ17M/CTlg+EXBUzmgviq7peiGn/2LWU4/uJzBoKnEdDstlWw== X-Received: by 2002:a05:622a:449:: with SMTP id o9mr10990609qtx.272.1626296006841; Wed, 14 Jul 2021 13:53:26 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-715c-901d-db03-e6e4.res6.spectrum.com. [2603:6081:7b01:cbda:715c:901d:db03:e6e4]) by smtp.gmail.com with ESMTPSA id d7sm1222091qth.70.2021.07.14.13.53.25 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Jul 2021 13:53:26 -0700 (PDT) Date: Wed, 14 Jul 2021 16:53:24 -0400 From: Tom Rini To: Stephan Gerhold Cc: u-boot@lists.denx.de, Jaehoon Chung , Joe Hershberger , Marek Vasut , Linus Walleij Subject: Re: [PATCH v2 2/3] phy: Add driver for ST-Ericsson AB8500 USB PHY Message-ID: <20210714205324.GH9516@bill-the-cat> References: <20210708183350.26592-1-stephan@gerhold.net> <20210708183350.26592-3-stephan@gerhold.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pw1f2VgzK59oupgo" Content-Disposition: inline In-Reply-To: <20210708183350.26592-3-stephan@gerhold.net> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --pw1f2VgzK59oupgo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 08, 2021 at 08:33:49PM +0200, Stephan Gerhold wrote: > The AB8500 PMIC contains an USB PHY that needs to be set up in > device or host mode to make USB work properly. Add a simple driver > for the generic PHY uclass that allows enabling it. >=20 > The if (CONFIG_IS_ENABLED(USB_MUSB_HOST)) might be a bit strange. > The USB PHY must be configured in either host or device mode and > somehow the USB PHY driver must be made aware of the mode. >=20 > Actually, the MUSB driver used together with this PHY does not > support dynamic selection of host/device mode in U-Boot at the moment. > Therefore, one very simple approach that works fine is to select > the mode to configure at compile time. When the MUSB driver is > configured in host mode the PHY is configured in host mode, and > similarly when the MUSB driver is configured in device/gadget mode. >=20 > Reviewed-by: Linus Walleij > Signed-off-by: Stephan Gerhold > Reviewed-by: Jaehoon Chung Applied to u-boot/master, thanks! --=20 Tom --pw1f2VgzK59oupgo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDvTsQACgkQFHw5/5Y0 tyxSYwv/dxwu7l2uIohLCDTAL3XWNAX9QF+/64+2mDcVDumdhSfGLXXDeVpSE09T a9tcZil0y3QrLjlm4sRDz9uEUgepSBZvlZTVQpXFYKIssizDGeQa1kYv2nnBBmxk TFtDLepniSXeMpE9l4Y2JUeWqIa6F67fd78MJZIHzQJdUaOuhreB9oA9HgzUJs+g XPOZXTyQGGuZLlRADYwU7YhXsM40IBXssGm18+U+x8b82bojhLtK6Fu80hKL47Jf gqOFxADY/JVIvdhwXiSS692KihW8pcbnjaOxR67dMUMa4hhVOcQEWyb5rM48TsRo 4Ty0O6mYZ4xvNzF1kilq1B8IMZafZPrTU2rPt6YroSdnKvygbNiKJC0NgmNXOjem WqtRf+sZkPH8AVBxH1FS5wrLDQF8Q37oed1BMYajdZI+JB+K+BRRHsWu8C73mv2z S2F7aZQkrD9mrXDVjonLfK+8pLUTK2PLmCeH5FGF8pY/ySRS85p5mAcQoL0nrrdt jxEb8TL0 =jilD -----END PGP SIGNATURE----- --pw1f2VgzK59oupgo--