Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F41A4C12002 for ; Wed, 14 Jul 2021 21:11:48 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39C18613D6 for ; Wed, 14 Jul 2021 21:11:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39C18613D6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8DBE581FC6; Wed, 14 Jul 2021 23:11:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Ii8MEbyr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6C66E82003; Wed, 14 Jul 2021 23:11:44 +0200 (CEST) Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 79BDA81E47 for ; Wed, 14 Jul 2021 23:11:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x834.google.com with SMTP id k3so2926615qtq.7 for ; Wed, 14 Jul 2021 14:11:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NKj/TWjVdWlngFwZYaao8u8QNUclkIwun57P59crk9U=; b=Ii8MEbyrqv42vfEAkz2uKNUFjHm8294n5OuT2YG2IxJAVQzK2pw+eoNAfn00937bpQ uaB3fxPnjm98nUsUBbw6PmxaO7TEaPqZVKqp3/gmHkMVwgqwgDSox+EJ0BAbC44EdoLM ywvAvpzLan4qDdaKQi7zqIaeu0tUBIUKaycnM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NKj/TWjVdWlngFwZYaao8u8QNUclkIwun57P59crk9U=; b=Lf6Urdob+zhnyNXHzcTA5LNpCkhpcDYNf6birSze8dsaONRIwwSQeURe+1iMssU4n5 zUG8zxwgNtk8mdx+xzb1DPqFRsEP7XTWAHAze/Dxge9iTyR8Gm//vGKhNSX9m7Hd/pJa jedt+nWgfN778M8xW637kBHEcYFF/vUzw9C2iZ4jOLbmt4Ffn/ktvPviES//xhgxoPf8 gW3JbaFWkrRrL9lEvvtx4u4Jjk45QS78Uzh1M0fATocjS+TLoFZsrm8OwfsueUY3x9sF gd3Eki/4L/JuWDSajocwh+xhsF6NUsYEyyJJo3oiYvokaYsswMLB9Upr05xwjj43GcbL w7Ng== X-Gm-Message-State: AOAM531ANx/3mscRvn/qvps5jO3CW1GacqWmAVD3KcSI4U4WJ0VpqrIV kxyopEX5vCjxCItmv+P12yo8VA== X-Google-Smtp-Source: ABdhPJzAmfx8eqb5dfID5fXfG/dCuifiOGpZfeY/z1Ftnn92giBu9cAFFQq6DEtO8AReihiOC9X5Jg== X-Received: by 2002:ac8:5d47:: with SMTP id g7mr20882qtx.351.1626297100402; Wed, 14 Jul 2021 14:11:40 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-715c-901d-db03-e6e4.res6.spectrum.com. [2603:6081:7b01:cbda:715c:901d:db03:e6e4]) by smtp.gmail.com with ESMTPSA id d200sm1605689qke.95.2021.07.14.14.11.39 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Jul 2021 14:11:39 -0700 (PDT) Date: Wed, 14 Jul 2021 17:11:38 -0400 From: Tom Rini To: Alexandru Gagniuc Cc: u-boot@lists.denx.de, sjg@chromium.org Subject: Re: [PATCH v2] tools: Use a single target-independent config to enable OpenSSL Message-ID: <20210714211138.GA25256@bill-the-cat> References: <20210706150326.2800576-1-mr.nuke.me@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2oS5YaxWCcQjTEyO" Content-Disposition: inline In-Reply-To: <20210706150326.2800576-1-mr.nuke.me@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --2oS5YaxWCcQjTEyO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 06, 2021 at 10:03:26AM -0500, Alexandru Gagniuc wrote: > Host tool features, such as mkimage's ability to sign FIT images were > enabled or disabled based on the target configuration. However, this > misses the point of a target-agnostic host tool. >=20 > A target's ability to verify FIT signatures is independent of > mkimage's ability to create those signatures. In fact, u-boot's build > system doesn't sign images. The target code can be successfully built > without relying on any ability to sign such code. >=20 > Conversely, mkimage's ability to sign images does not require that > those images will only work on targets which support FIT verification. > Linking mkimage cryptographic features to target support for FIT > verification is misguided. >=20 > Without loss of generality, we can say that host features are and > should be independent of target features. >=20 > While we prefer that a host tool always supports the same feature set, > we recognize the following > - some users prefer to build u-boot without a dependency on OpenSSL. > - some distros prefer to ship mkimage without linking to OpenSSL >=20 > To allow these use cases, introduce a host-only Kconfig which is used > to select or deselect libcrypto support. Some mkimage features or some > host tools might not be available, but this shouldn't affect the > u-boot build. >=20 > I also considered setting the default of this config based on > FIT_SIGNATURE. While it would preserve the old behaviour it's also > contrary to the goals of this change. I decided to enable it by > default, so that the default build yields the most feature-complete > mkimage. >=20 > Signed-off-by: Alexandru Gagniuc This doesn't apply cleanly right now, and while I thought I had fixed that up correctly, building rpi_3_32b for example in the CI contains fails very loudly/badly with this change. Please rebase, thanks! --=20 Tom --2oS5YaxWCcQjTEyO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDvUwAACgkQFHw5/5Y0 tyxMEQv/dmhhDXFX/gSVicWzBIlh8bD3LhQaVoQFELhaSIv6u2uzAc03Lufo23sL TxMBeLQWk/6/znOqIkFQsUUC+b/8LnbKwBPYsMwfPya7yAqaSVzTEynN0sGmTuux V5u3TLoYJEOOouYOz15FdY1QA3ECfM1chBwEotuIYYntwqCaDpqsD+y5kMw2DxrX z5xtU7hZndVab/bazxbXqWbgM4TCWwR97c8wtttKyTIF5AUuuC7VmPXR1/Wo9N+D NOIxt4mniN8TIy10Ye1j7AlaK4q+lfIrCga2yuLJrTPAjYX5M2DdH/WRQPr5CQfL rjDgK8DBYodBmRSAJj00/kkN55/GmZKt0lu9HGJR4L/yhwxp6vkJWdwct1p9rT/4 IDB2GvWDdQHMBagSTaqIDh6G/1fSgQ5j+ZTMPFNEuoO4+Nd4dNWiT1IJA0P7espC wGLn8cUMUtAQ/GZt69ovwFQtMS2CLxUog2sirhLXK3Ny8yoqCFiABTpIG9E6odfD LMcqOmcA =CxeR -----END PGP SIGNATURE----- --2oS5YaxWCcQjTEyO--