Content-Type: multipart/mixed; boundary="===============6466886273097304791==" MIME-Version: 1.0 From: ramesh.thomas at intel.com Subject: [Accel-config] [PATCH v4 3/3] accel-config: Reset cmd_status during device init Date: Wed, 14 Jul 2021 20:52:19 -0400 Message-ID: <20210715005219.1090056-4-ramesh.thomas@intel.com> In-Reply-To: 20210715005219.1090056-1-ramesh.thomas@intel.com To: accel-config@lists.01.org List-ID: --===============6466886273097304791== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Ramesh Thomas Initialize cmd_status at device init to avoid getting stale value during error checks. Signed-off-by: Ramesh Thomas --- accfg/lib/libaccfg.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/accfg/lib/libaccfg.c b/accfg/lib/libaccfg.c index 5df19a7..f21cab5 100644 --- a/accfg/lib/libaccfg.c +++ b/accfg/lib/libaccfg.c @@ -154,6 +154,23 @@ static inline bool is_mdev_registered(struct accfg_dev= ice *device) return device->mdev_path && !access(device->mdev_path, R_OK); } = +static int accfg_set_param(struct accfg_ctx *ctx, int dfd, char *name, + void *buf, int len) +{ + int fd =3D openat(dfd, name, O_RDWR); + int n; + + if (fd =3D=3D -1) + return -errno; + + n =3D write(fd, buf, len); + close(fd); + if (n !=3D len) + return -errno; + + return 0; +} + static long accfg_get_param_long(struct accfg_ctx *ctx, int dfd, char *nam= e) { int fd =3D openat(dfd, name, O_RDONLY); @@ -589,6 +606,14 @@ static void *add_device(void *parent, int id, const ch= ar *ctl_base, return NULL; } = + rc =3D accfg_set_param(ctx, dfd, "cmd_status", "1", 1); + /* older drivers don't support writing to cmd_status */ + if (rc && rc !=3D -EACCES) { + err(ctx, "Failed resetting cmd status %d\n", rc); + close(dfd); + goto err_device; + } + device =3D calloc(1, sizeof(*device)); if (!device) { err(ctx, "allocation of device failed\n"); -- = 2.26.3 --===============6466886273097304791==--