Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51918C12002 for ; Thu, 15 Jul 2021 01:28:16 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3604613CC for ; Thu, 15 Jul 2021 01:28:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3604613CC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CA87282B64; Thu, 15 Jul 2021 03:28:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="UMqJp0TB"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0F1D682BC7; Thu, 15 Jul 2021 03:27:53 +0200 (CEST) Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F1624829C4 for ; Thu, 15 Jul 2021 03:27:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x730.google.com with SMTP id q190so3651828qkd.2 for ; Wed, 14 Jul 2021 18:27:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=SUnrx20HGKaLFL61XnHUIvpbQBDhNPPYgThDcvsDT7A=; b=UMqJp0TBzKkFwQjK7dM6vUccyRRL5KrX2H/wEcl+/SgixzdFQADTZGwzWb7IgJ/jUF mRbxunzwgU4cHNq0TdVM50hW8azIfwqAIst/OWcKC/yNu0nbMSVT3XVAUtqz8/BIW8xr XiX0g///pyoQCN+bGpWQevKd/7qVNbdbOpuSM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=SUnrx20HGKaLFL61XnHUIvpbQBDhNPPYgThDcvsDT7A=; b=mXXyoDWwswx1eyZ/XOAWVlvYE69jfql9Hnm/HSq8I4d/hKNmoS3vz23jut0CtwKS/P bpPjD8b4TEIKbdXe5jLNV6AAo1Ytz5t9O9jkGJjBBYD0n7ip5Pn1PNeJWJVhNOkTV6ws wohHQq6izFYGGryGxOyGa3l2b5MPtriGEoaVEgBH1blx1EJTe1Em1KpB7zyJxYI8rofu mJVJ8W14H/ARq3TkVg5jHh5uLvJ3p0AIVAXM9eh4J3v7zHPvYo23dWrahBU3gm+hvJ0z PIWHIVjeA/v6gcQJ0sphU4tSfx5B1l21ws8fizlxPkc+nJiNPnxBJltitigxAMtos77k pdrg== X-Gm-Message-State: AOAM533YVbYnFbZKddFhzc7I+olexWDS0wq6SyYdQVAOPOLqovbNjYA7 HC82qRi4clMQN9HsfCpZydXE0g== X-Google-Smtp-Source: ABdhPJzfS8jgfiq571iwt6jKIRHDo0NT4n072f1g+rzmvi9ShIJ8iz4g/GA5cKCpSwgqRClZoc6fpA== X-Received: by 2002:a37:e15:: with SMTP id 21mr986473qko.184.1626312466704; Wed, 14 Jul 2021 18:27:46 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-715c-901d-db03-e6e4.res6.spectrum.com. [2603:6081:7b01:cbda:715c:901d:db03:e6e4]) by smtp.gmail.com with ESMTPSA id x28sm1616631qtm.71.2021.07.14.18.27.45 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Jul 2021 18:27:46 -0700 (PDT) Date: Wed, 14 Jul 2021 21:27:44 -0400 From: Tom Rini To: liu.ming50@gmail.com Cc: u-boot@lists.denx.de, sergio.prado@toradex.com, max.krummenacher@toradex.com Subject: Re: [[PATCH] tools: image-host: fix wrong return value Message-ID: <20210715012744.GM9516@bill-the-cat> References: <20210531070451.6561-1-liu.ming50@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sUS2DQCY3UwqyCIP" Content-Disposition: inline In-Reply-To: <20210531070451.6561-1-liu.ming50@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --sUS2DQCY3UwqyCIP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 31, 2021 at 09:04:51AM +0200, liu.ming50@gmail.com wrote: > From: Ming Liu >=20 > The return value '-ENOSPC' of fit_set_timestamp function does not match > the caller fit_image_write_sig's expection which is '-FDT_ERR_NOSPACE'. >=20 > Fix it by not calling fit_set_timestamp, but call fdt_setprop instead. >=20 > This fixes a following mkimage error: > | Can't write signature for 'signature@1' signature node in > | 'conf@imx6ull-colibri-wifi-eval-v3.dtb' conf node: > | mkimage Can't add hashes to FIT blob: -1 >=20 > Signed-off-by: Ming Liu > Tested-by: Igor Opaniuk Applied to u-boot/master, thanks! --=20 Tom --sUS2DQCY3UwqyCIP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDvjxAACgkQFHw5/5Y0 tyyzYAv/aZvvmuyV3/ZMZbNAH/R/DKmkSW/rLECwY/GX2tQScNI1Vz1fqXqugTXa wMHM8Z4+mp4rvjHMdMtHMJSPv86E2RWgOpu+CauYJM2yXS+KLlW2PpmJ1rN0xseE XX34QKJEJ/bbMUfj/zKJoDx4YVBLO4vwudi8hXG6Ipt1gngZ7kPFbqp8sQSwt/Js 5tkA/LYgx71bUffFYLphJUYViOFLCDDAgC12ct93xTmme/ZG0GBSXpngtgORC9uE dq7O+MWGw+14RyokxIj/KZI9JqUjSgkFjRE+2pPuf45n1J2gLRbWqTYiREOhzmXk Ovpm9PtGU+2D8//4K//Ywvew5ivm1cLIQjWdFP9OeYIuHuZ3zhQTraV8hag8cc+G XfYZXEZMFfB4q774FHt0i3Ze9nnKhfXcjGWQv57yrTtj5Pv0Ilitp/4yOAO5tKvo JGuaZpNvgi+9dCdoLPehSCZWix7I/eulcE+9lHhT289Sv5v3AAoD/jP4aB3tmAz0 PHH8BIZp =lsge -----END PGP SIGNATURE----- --sUS2DQCY3UwqyCIP--