Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F700C07E96 for ; Thu, 15 Jul 2021 07:24:59 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F6326128B for ; Thu, 15 Jul 2021 07:24:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F6326128B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0605A805E7; Thu, 15 Jul 2021 09:24:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="rgK6gW/g"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3819180612; Thu, 15 Jul 2021 09:24:54 +0200 (CEST) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C2DC68022F for ; Thu, 15 Jul 2021 09:24:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jorge.ramirez.ortiz@gmail.com Received: by mail-wm1-x335.google.com with SMTP id u5-20020a7bc0450000b02901480e40338bso4658033wmc.1 for ; Thu, 15 Jul 2021 00:24:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2cMSFtIEEkDT12aYl31Pr00W/9hM2PCPH/Mt293u6/k=; b=rgK6gW/gdTTmflfOdb6JgvpcKuyJ/K67y02r/juV/iNn3XNfpIrJ6xYKAOsWPaGbCR HcLZIMk/ZvCf4r+aM7XohugpSr8d2OjT3FAIsWL90OD+UKi9RJQjAEL5NSLeBipJMceN 5g61rjSGw9BsXLt7YRqn/N61hhWDPQG4xIO9Si16C8H9E+bqVo3f9sGm+FKLXkeYNnET dc64Y8+mMAwvv/rJBLt9VBgM2snKRdgsrn3i59ju3QpBs825LdmEf+vVZGsJ2Xm4QeEj ma7xFitC/7J/a6CYWVAKm5HcSoyehQXGvEtLv77zHbP+ud/depyzQP+4gGKU6c+bOklh fa7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2cMSFtIEEkDT12aYl31Pr00W/9hM2PCPH/Mt293u6/k=; b=jjZMyWP/0euNtzwXalqwBHX/qWwgfA1siIkqlAVAC0thuXFh0kK3gaWc8mCSS1rt3u ePnW9ZOS9bM/SLBzQ6YijdiZ9xs+ecx3yzkYBxJBV/GUoPGUNjPs5HVa4jP944IHwhML mIytgHsxzlcFRml1iEhDv5GlicF2qX2J86oaQt7TwC/GtBYYvyt8FzHS+Tw69quTQSIi co6pW6m5ugBoM85IZ3UaigUNJfqqs44MWpF5+VIEabXnKj0EnTnt49SnGk8zjNW4jRtu 9SKM6zOZR1NoMu49SUbQnmzq9lPdpEp6pVHsgwg8BDIPkw03qXkYakpQue1qN51cAF4b OvqQ== X-Gm-Message-State: AOAM532J/mdcSVYAytDI6DQ7rMOaofI1OxcpHL0ZGU98Rm8WX0KnZFSo C6IRKHOvojgyNVRenuDx3j4= X-Google-Smtp-Source: ABdhPJwAcIiCJH9E4EsBzdDzohqKgtzMfZGP3mBkJy4uH66nDPOuIfISs4v3xa2CFg3nh6EtmSFGfg== X-Received: by 2002:a05:600c:649:: with SMTP id p9mr9057260wmm.151.1626333890296; Thu, 15 Jul 2021 00:24:50 -0700 (PDT) Received: from trex (138.red-79-146-80.dynamicip.rima-tde.net. [79.146.80.138]) by smtp.gmail.com with ESMTPSA id u18sm4055540wmj.15.2021.07.15.00.24.49 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 15 Jul 2021 00:24:49 -0700 (PDT) From: "Jorge Ramirez-Ortiz, Gmail" X-Google-Original-From: "Jorge Ramirez-Ortiz, Gmail" Date: Thu, 15 Jul 2021 09:24:48 +0200 To: "Jorge Ramirez-Ortiz, Gmail" Cc: Ramon Fried , Stephan Gerhold , U-Boot Mailing List , Nicolas Dechesne , Tom Rini Subject: Re: [PATCH] arm: mach-snapdragon: pinctrl: Place pin_name in .data section Message-ID: <20210715072448.GA16304@trex> References: <20210705121847.48432-1-stephan@gerhold.net> <20210715071509.GA15301@trex> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210715071509.GA15301@trex> User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 15/07/21, Jorge Ramirez-Ortiz, Gmail wrote: > On 06/07/21, Ramon Fried wrote: > > On Mon, Jul 5, 2021 at 3:19 PM Stephan Gerhold wrote: > > > > > > According to arch/arm/lib/crt0_64.S, the BSS section is "UNAVAILABLE" > > > and uninitialized before relocation. Also, it overlaps with the > > > appended DTB before relocation, so writing data into a variable > > > in the BSS section might corrupt the appended DTB. > > > > > > Unfortunately, pinctrl-apq8016.c and pinctrl-apq8096.c do place the > > > "pin_name" variable in the BSS section (since it's uninitialized). > > > It's also used before relocation, when setting up the pinctrl for > > > the serial driver. > > > > > > On DB410c this causes "GPIO_5" to be written into some part of an > > > appended DTB, e.g.: > > > > > > 80111820: edfe0dd0 9f100000 38000000 c00e0000 ...........8.... > > > 80111830: 28000000 11000000 10000000 00000000 ...(............ > > > 80111840: 4f495047 8800355f 00000000 00000000 GPIO_5.......... > > > 80111850: 00000000 00000000 01000000 00000000 ................ > > > 80111860: 03000000 04000000 00000000 02000000 ................ > > > 80111870: 03000000 04000000 0f000000 02000000 ................ > > > 80111880: 03000000 2d000000 1b000000 6c617551 .......-....Qual > > > 80111890: 6d6d6f63 63655420 6c6f6e68 6569676f comm Technologie > > > > > > Depending on the part of the DTB that is corrupted this might not > > > cause any problems, but it can also result in strange reboots > > > without any serial output. > > > > > > Fortunately, in practice this does not cause issues on DB410c yet > > > because board_fdt_blob_setup() in dragonboard410c.c currently > > > overrides the appended DTB with the one passed by the previous > > > bootloader (LK) (which does not get corrupted). > > > > > > DB820c does not have board_fdt_blob_setup() so I would expect it to > > > be affected by this problem. Perhaps everyone was just fortunate to > > > not compile an U-Boot configuration where the pin_name corrupts an > > > important part of the DTB. > > I'll try to confirm during the week. > > After Ramon's pinctrl changes db820c did indeed break - was able to > test a few months back- but we didnt have a board to test back then > (and nobody complained) > > will come back to you on this but from what you are saying, this is > probably the fix we needed for db820c yep, all good. just tested it. thanks for the fix! U-Boot 2021.07-00467-gc11f5abce8 (Jul 15 2021 - 09:20:22 +0200) Qualcomm-DragonBoard 820C DRAM: 3 GiB PSCI: v1.0 MMC: sdhci@74a4900: 0 Loading Environment from EXT4... MMC: no card present In: serial@75b0000 Out: serial@75b0000 Err: serial@75b0000 Net: Net Initialization Skipped No ethernet found. Hit any key to stop autoboot: 0 MMC: no card present dragonboard820c => dragonboard820c => bdinfo boot_params = 0x0000000000000000 DRAM bank = 0x0000000000000000 -> start = 0x0000000080000000 -> size = 0x0000000060000000 DRAM bank = 0x0000000000000001 -> start = 0x0000000100000000 -> size = 0x000000005ea4ffff flashstart = 0x0000000000000000 flashsize = 0x0000000000000000 flashoffset = 0x0000000000000000 baudrate = 115200 bps relocaddr = 0x000000013ff70000 reloc off = 0x00000000bfef0000 Build = 64-bit current eth = unknown ethaddr = (not set) IP addr = fdt_blob = 0x000000013f7673c0 new_fdt = 0x000000013f7673c0 fdt_size = 0x0000000000000a20 lmb_dump_all: memory.cnt = 0x2 memory[0] [0x80000000-0xdfffffff], 0x60000000 bytes flags: 0 memory[1] [0x100000000-0x15ea4fffe], 0x5ea4ffff bytes flags: 0 reserved.cnt = 0x1 reserved[0] [0x86300000-0x864fffff], 0x00200000 bytes flags: 4 arch_number = 0x0000000000000000 TLB addr = 0x000000013fff0000 irq_sp = 0x000000013f7673b0 sp start = 0x000000013f7673b0 Early malloc usage: 5d8 / 2000 > > > > > > > > Make sure "pin_name" is explicitly placed in the .data section > > > instead of .bss to fix this. > > > > > > Cc: Ramon Fried > > > Signed-off-by: Stephan Gerhold > > > --- > > > > > > arch/arm/mach-snapdragon/pinctrl-apq8016.c | 3 +-- > > > arch/arm/mach-snapdragon/pinctrl-apq8096.c | 2 +- > > > 2 files changed, 2 insertions(+), 3 deletions(-) > > > > > > diff --git a/arch/arm/mach-snapdragon/pinctrl-apq8016.c b/arch/arm/mach-snapdragon/pinctrl-apq8016.c > > > index 1042b564c3..70c0be0bca 100644 > > > --- a/arch/arm/mach-snapdragon/pinctrl-apq8016.c > > > +++ b/arch/arm/mach-snapdragon/pinctrl-apq8016.c > > > @@ -10,7 +10,7 @@ > > > #include > > > > > > #define MAX_PIN_NAME_LEN 32 > > > -static char pin_name[MAX_PIN_NAME_LEN]; > > > +static char pin_name[MAX_PIN_NAME_LEN] __section(".data"); > > > static const char * const msm_pinctrl_pins[] = { > > > "SDC1_CLK", > > > "SDC1_CMD", > > > @@ -59,4 +59,3 @@ struct msm_pinctrl_data apq8016_data = { > > > .get_function_mux = apq8016_get_function_mux, > > > .get_pin_name = apq8016_get_pin_name, > > > }; > > > - > > > diff --git a/arch/arm/mach-snapdragon/pinctrl-apq8096.c b/arch/arm/mach-snapdragon/pinctrl-apq8096.c > > > index 20a71c319b..45462f01c2 100644 > > > --- a/arch/arm/mach-snapdragon/pinctrl-apq8096.c > > > +++ b/arch/arm/mach-snapdragon/pinctrl-apq8096.c > > > @@ -10,7 +10,7 @@ > > > #include > > > > > > #define MAX_PIN_NAME_LEN 32 > > > -static char pin_name[MAX_PIN_NAME_LEN]; > > > +static char pin_name[MAX_PIN_NAME_LEN] __section(".data"); > > > static const char * const msm_pinctrl_pins[] = { > > > "SDC1_CLK", > > > "SDC1_CMD", > > > -- > > > 2.32.0 > > > > > Reviewed-by: Ramon Fried