Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A3D9C07E95 for ; Fri, 16 Jul 2021 15:54:45 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A16BA608FE for ; Fri, 16 Jul 2021 15:54:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A16BA608FE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EE6A2831C7; Fri, 16 Jul 2021 17:53:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="K2g6fg3P"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4065482F2F; Fri, 16 Jul 2021 17:52:57 +0200 (CEST) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5591082F3A for ; Fri, 16 Jul 2021 17:52:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82d.google.com with SMTP id z12so7422490qtj.3 for ; Fri, 16 Jul 2021 08:52:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/gft79CiMLfiaW2sARWnvhbjU7OhcwkXQYSM1Jtdi5k=; b=K2g6fg3PnA1gSUPh7UJPasYyiI/SUraEcbCcH9SBu7y/cx3eql1YkhnHMsXEGTu0WK skg4uf4npKv3ai1Xwaqqc1TcJda8hz5vYZdB00g4vkjGbuJsFpHcQLBnd944KYuMwaEh U3mkZGIjCcnw1V/GoJhxbm/q4bMV3nMcz4Gkg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/gft79CiMLfiaW2sARWnvhbjU7OhcwkXQYSM1Jtdi5k=; b=Dk9B5CUHehVuwj59GBwqOpszINAR2B7907+S1Pd/tOPDau7Zs0Ze45eayd6n17dAxg bvHwgGd3muHp7KHYFIUhKf1eqDo7egvNYNm5Hxt4rLs1WKyxy7md4Gp+pAIeSo5aHQl7 bJiMgQ7o8it+VayV0P5UFeYBRK9K1IV3l+1sdiIYHcf6SfXlQQhIk7euzNC8tE6qtSy9 vTVH4kL6x6sGrpyaoXETMidafckjVdvYOmHwbUJEETHRlDM+qIBwDymBOcSC08ghE9yl apxiC9oLl84OL7l5iZAXVOTa8e++6t5KQr3havW71ZJQk/dilr7C4D9tX+qS+dve6iUZ LLgw== X-Gm-Message-State: AOAM530bJ2OZ9SvvlMkD+lp4DY7Ttwdp3wlYgTrEn7q4HMfAEs3LLp54 Ylt2dSy8ZfB/3Ph+leBIw1r/WA== X-Google-Smtp-Source: ABdhPJxah4vLxaTK0xHgvQQ6FxuXAIOLk/MAEYRVBK0SGWndYwgkPw5fJYvmV13JHdkeSpivK0etaA== X-Received: by 2002:ac8:7199:: with SMTP id w25mr9976743qto.1.1626450763195; Fri, 16 Jul 2021 08:52:43 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-a8ce-b25c-3933-5c80.res6.spectrum.com. [2603:6081:7b01:cbda:a8ce:b25c:3933:5c80]) by smtp.gmail.com with ESMTPSA id b188sm4027113qkf.133.2021.07.16.08.52.42 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 16 Jul 2021 08:52:42 -0700 (PDT) Date: Fri, 16 Jul 2021 11:52:40 -0400 From: Tom Rini To: Stephan Gerhold Cc: u-boot@lists.denx.de, Simon Glass Subject: Re: [PATCH] image: android: Automatically detect more compression types Message-ID: <20210716155240.GY9379@bill-the-cat> References: <20210701183316.19252-1-stephan@gerhold.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Zzd9Wh/bp6DhMAqJ" Content-Disposition: inline In-Reply-To: <20210701183316.19252-1-stephan@gerhold.net> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --Zzd9Wh/bp6DhMAqJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 01, 2021 at 08:33:16PM +0200, Stephan Gerhold wrote: > At the moment android_image_get_kcomp() can automatically detect > LZ4 compressed kernels and the compression specified in uImages. > However, especially on ARM64 Linux is often compressed with GZIP. > Attempting to boot an Android image with a GZIP compressed kernel > image currently results in a very strange crash, e.g. >=20 > Starting kernel ... > "Synchronous Abort" handler, esr 0x02000000 > ... > Code: 5555d555 55555d55 555f5555 5d555d55 (00088b1f) >=20 > Note the 1f8b, which are the "magic" bytes for GZIP images. >=20 > U-Boot already has the image_decomp_type() function that checks for > the magic bytes of bzip2, gzip, lzma and lzo. It's easy to make use > of it here to increase the chance that we do the right thing and the > user does not become confused with strange crashes. >=20 > This allows booting Android boot images that contain GZIP-compressed > kernel images. >=20 > Signed-off-by: Stephan Gerhold Applied to u-boot/master, thanks! --=20 Tom --Zzd9Wh/bp6DhMAqJ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmDxq0gACgkQFHw5/5Y0 tyw1YgwAhOIiUU/5+3gZojrO2pIZcEEAQL97r32+R2XxojLeKZTN2QOqMnrOeYFF 3ELsLlStumfih4A42t3bszNTg+rOlSSlkQ0KNGCrhvSxCzIK5DqCLNIwIAL0Ypv8 loR8W0mEqwq/zZjhX/1MU2Bl6NMU3dONhgAkB0UUvvRFm4MLlAy/vcOJl3a80cwN BVRBeQNB/lUaqISzAOa5jMsYxLGuexTdS/VWkc/UlL4ehu+WYfhLC9nJuxU9fPQI HTmV21HIPTLTgQY8fhG8wTX1+p1Yyn2wUKfobrpixnwBNv5+qfuW7roAkp/bIhnN MfT3oO+dMoPmbMdFXfCduL/fEusX0/fnObmG+dT8jxG4RWJQ1UtRzyVUpONc5wva 8jZCEgO1XyZKD/RvDHeeKE4VJ3XfWRyUjaRdzvO4bsJwyDGKS7ECnDVcKZRwBEg9 imhm+C3rtLAy7GyWWn3bfU7CETuie4XZ85pl4d9kf3Qma4lhv6zQsWRYHHMVmHte C1rHVdgc =JZkd -----END PGP SIGNATURE----- --Zzd9Wh/bp6DhMAqJ--