Content-Type: multipart/mixed; boundary="===============9164656906828704822==" MIME-Version: 1.0 From: Pavel Machek To: kbuild-all@lists.01.org Subject: Re: [PATCH 1/2] swap led_brightness from enum to typedef Date: Mon, 19 Jul 2021 14:05:23 +0200 Message-ID: <20210719120523.GA20484@duo.ucw.cz> In-Reply-To: List-Id: --===============9164656906828704822== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi! > >>> vim +18 include/media/v4l2-flash-led-class.h > >>> > >>> 14 > >>> 15 struct led_classdev_flash; > >>> 16 struct led_classdev; > >>> 17 struct v4l2_flash; > >>> > 18 led_brightness; > >>> 19 > >>> > >>> --- > = > > = > > Another patch was sent into the list to correct this error. > = > Hopefully Pavel (LED subsystem maintainer) will comment soon-ish. > = > My comments: > = > a. This patch would be the right thing to do if your large patch had alre= ady been > applied (merged) somewhere, but AFAIK it hasn't been. So: > = > b. IMO you should resend your entire patch set with this fix included. > Send it as "v2" (version 2) and explain the changes in it since your > original patch (which was v1). This v2 explanation should be below the > "---" line in the patch. (See Documentation/process/submitting-patches.rst > for more info -- or ask for more info/help.) I still remember the old patch, so b. is not strictly neccessary here. > c. For your follow-up patch to include/media/v4l2-flash-led-class.h, whic= h was: > = > -led_brightness; > +typedef u8 led_brightness; > = > I would just add this to include/media/v4l2-flash-led-class.h: > = > #include > = > That way, in a few years, when the type of led_brightness changes again, > someone won't have to remember to search for other typedefs of it and > update them also. Or maybe they will do that after a bug happens and > someone notices it. > = > (Note that I am just trying to help. Pavel has more of a final > say-so about this.) And your comments are reasonable. Best regards, Pavel -- = http://www.livejournal.com/~pavelmachek --===============9164656906828704822== Content-Type: application/pgp-signature MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KCmlGMEVBQkVDQUIwV0lRUlBmUE83cjBlQWhr MDEwdjB3NS9CcWxkdjY4Z1VDWVBWcWd3QUtDUkF3NS9CcWxkdjYKOHNxY0FKMGZFZ0FOcXFmVmxL aHRXYWt2VWVuTHVkY1Y1QUNnbiszK0JLVkhJR0tUeHordHdXbXZrZzN3M2VFPQo9dnB0dwotLS0t LUVORCBQR1AgU0lHTkFUVVJFLS0tLS0K --===============9164656906828704822==--