Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2090FC6377A for ; Thu, 22 Jul 2021 03:07:25 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 843CD60FF3; Thu, 22 Jul 2021 03:07:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 843CD60FF3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sina.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1m6P3R-0000Ko-SK; Thu, 22 Jul 2021 03:07:21 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6P3Q-0000Ki-5i for linux-f2fs-devel@lists.sourceforge.net; Thu, 22 Jul 2021 03:07:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zzWKWr417ADLzTxzCbqR+qEH/SJBiViVF5QAEhka6QA=; b=fdeQCYhqqbMsWJB3qPJohbF939 ZoGSUJMVFc5W7COPPRcnaTwbhhqME6T+MTXc7TR3bLem6t/TkwWwNrXHxEhRf3ZVO65EuCAVowdRK fPQT7yxYQiioN51JCXiyqN9kzy3G8ItIKmHbEifDBK/Z+Ag0n3K3zIg00eR89x5eweVI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zzWKWr417ADLzTxzCbqR+qEH/SJBiViVF5QAEhka6QA=; b=jRZ5dtIABeK+H9bz5L6TDupNMR 9wCNEE8WYUe6UWXUOq8hoY66OnwmmdnTOyNCD++sgUy7gnwIJ358w4xF+j5EkodvPOAg5cMlNfzKv WH/0CJTifXUudTWLrMcQeO7f24zGID7G9DmMhefFd4DGuszM/Z0AyjBzN4080DhS/REI=; Received: from r3-19.sinamail.sina.com.cn ([202.108.3.19]) by sfi-mx-1.v28.lw.sourceforge.com with smtp (Exim 4.92.3) id 1m6P3I-00GM03-OU for linux-f2fs-devel@lists.sourceforge.net; Thu, 22 Jul 2021 03:07:20 +0000 Received: from unknown (HELO localhost.localdomain)([1.24.238.81]) by sina.com (172.16.97.35) with ESMTP id 60F8E0D700017D62; Thu, 22 Jul 2021 11:07:05 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 74043515073402 From: Hillf Danton To: Jaegeuk Kim Date: Thu, 22 Jul 2021 11:06:57 +0800 Message-Id: <20210722030657.1155-1-hdanton@sina.com> In-Reply-To: <20210722014149.525166-1-jaegeuk@kernel.org> References: <20210722014149.525166-1-jaegeuk@kernel.org> MIME-Version: 1.0 X-Headers-End: 1m6P3I-00GM03-OU Subject: Re: [f2fs-dev] [PATCH] f2fs: use rwlock instead of rwsem for journal X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Wed, 21 Jul 2021 18:41:49 -0700 Jaegeuk Kim wrote: > >This tries to fix priority inversion in the below condition resulting in >long checkpoint delay. If you are right and the patch makes real sense, feel free to specify a bit more on the priority inversion you are trying to fix, and how the fix helps shorten the checkpoint delay. And test data is welcome. > >f2fs_get_node_info() > - nat_tree_lock > -> sleep in journal_rwsem > checkpoint > - waiting for nat_tree_lock _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel