Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAF04C63797 for ; Thu, 22 Jul 2021 17:30:26 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E432E611C1 for ; Thu, 22 Jul 2021 17:30:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E432E611C1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9C722829F9; Thu, 22 Jul 2021 19:30:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="cio7Fgmf"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B9C0682A01; Thu, 22 Jul 2021 19:30:21 +0200 (CEST) Received: from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com [IPv6:2607:f8b0:4864:20::f2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9996C8297D for ; Thu, 22 Jul 2021 19:30:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2f.google.com with SMTP id w6so80704qvh.3 for ; Thu, 22 Jul 2021 10:30:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OkR3g+M/WLK3FpJwaFNE9RMEG0WY3nChzooDA1/84xU=; b=cio7FgmfNPcFKHIUh2K5FOGoCy0TMgLM5BlaepFC10uZVVPwjpd50ezW2+EmnmV+Vl Bwg1U6/Up+ftTCZ2sZtksGMYYzXj9tjz1C8kbnWK6DLqGU6KxS6ihDftXvMD1xlCoVvz XNM/mIBfGqbAGg9IaBXn5XcarZ1lsy8zGNMY0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OkR3g+M/WLK3FpJwaFNE9RMEG0WY3nChzooDA1/84xU=; b=gAJeHgihaJU//O60tgCFUQ7kj9XnVXubM1nqy3hNHjwezqV6ut1SyRerSidlO9DbQz lSSWOg5vX8h6ROHyERvexu277yi0ejMbxwMgBbTInBVS9bsRIe4lyGtnzanSjQKxu/Aa NDBfbmAH2v5FUz7Jw9sFMFG3bSY2xqdNdx4KXuQW792nTUlDZ1wZ3mcYqbz2h2QVnJcn Q2bjZO7ZML5UT8tHye6ydMgSyr3lCqFlvsdhelfCiElFHI1hfu1cll0wa/0N+zZJEdmL VNMdigyPiaNfauoJi4GzvRZ93Jp61NhYgJsxRlDBFG/sBsJSUqbR0m3qsLaahx9EwLMf 9g5Q== X-Gm-Message-State: AOAM531LB3NoM9+9UpVhCRfJvtZpOfxhetR7AXhXeQ4fcnlr0B335y+E mXZoA/E/aJmCkbzVg3hPpkO+jQ== X-Google-Smtp-Source: ABdhPJzdwxTPYlxQarNBfAR49Jg6EAspEzw+WCpIu9PkC2NKeNCZdwHdeerCvE2hbeILKviS+yjOKg== X-Received: by 2002:ad4:5386:: with SMTP id i6mr993142qvv.2.1626975017339; Thu, 22 Jul 2021 10:30:17 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-5560-078f-fb66-41c1.res6.spectrum.com. [2603:6081:7b01:cbda:5560:78f:fb66:41c1]) by smtp.gmail.com with ESMTPSA id h10sm12863440qka.83.2021.07.22.10.30.13 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 22 Jul 2021 10:30:13 -0700 (PDT) Date: Thu, 22 Jul 2021 13:30:11 -0400 From: Tom Rini To: Michal Simek Cc: Peter Robinson , u-boot@lists.denx.de, T Karthik Reddy , Ashok Reddy Soma , Pratyush Yadav Subject: Re: [PATCH] Revert "spi: spi-uclass: Add support to manually relocate spi memory ops" Message-ID: <20210722173011.GC9379@bill-the-cat> References: <20210722152529.1407976-1-pbrobinson@gmail.com> <0e9e0b0d-e363-379b-d63b-e4a3c73213d1@xilinx.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="YW2MF9I5J49Ey/EG" Content-Disposition: inline In-Reply-To: <0e9e0b0d-e363-379b-d63b-e4a3c73213d1@xilinx.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --YW2MF9I5J49Ey/EG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 22, 2021 at 06:04:40PM +0200, Michal Simek wrote: >=20 >=20 > On 7/22/21 5:25 PM, Peter Robinson wrote: > > This reverts commit 346df7d4fa62afc578d820b3a18815eec765074f. > >=20 > > This patch broke booting Rockchip systems from U-Boot residing on SPI > > flash, for at least the Pinebook Pro and Rockpro64, and also confirmed > > with the not yet upstream Helios64. > >=20 > > Signed-off-by: Peter Robinson > > Cc: T Karthik Reddy > > Cc: Ashok Reddy Soma > > Cc: Michal Simek > > Cc: Pratyush Yadav > > --- > > drivers/spi/spi-uclass.c | 11 ----------- > > 1 file changed, 11 deletions(-) > >=20 > > diff --git a/drivers/spi/spi-uclass.c b/drivers/spi/spi-uclass.c > > index d867b27806..ec7f4652b3 100644 > > --- a/drivers/spi/spi-uclass.c > > +++ b/drivers/spi/spi-uclass.c > > @@ -11,7 +11,6 @@ > > #include > > #include > > #include > > -#include > > #include > > #include > > #include > > @@ -200,16 +199,6 @@ static int spi_post_probe(struct udevice *bus) > > ops->set_mode +=3D gd->reloc_off; > > if (ops->cs_info) > > ops->cs_info +=3D gd->reloc_off; > > - if (ops->mem_ops) { > > - struct spi_controller_mem_ops *mem_ops =3D > > - (struct spi_controller_mem_ops *)ops->mem_ops; > > - if (mem_ops->adjust_op_size) > > - mem_ops->adjust_op_size +=3D gd->reloc_off; > > - if (mem_ops->supports_op) > > - mem_ops->supports_op +=3D gd->reloc_off; > > - if (mem_ops->exec_op) > > - mem_ops->exec_op +=3D gd->reloc_off; > > - } > > reloc_done++; > > } > > #endif > >=20 >=20 > This is protected by CONFIG_NEEDS_MANUAL_RELOC which is only enable for > m68k and microblaze. I expect rockchip is arm and you should never have > this code in your binary. That's why please double check it. Yes, this really doesn't make sense. Try also just removing spi-mem.h =66rom the file and see if that causes things to work again. If so, time to dig in to that header file to figure out what could be going wrong. --=20 Tom --YW2MF9I5J49Ey/EG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmD5qyMACgkQFHw5/5Y0 tyxthAv9HqFtohGx3O6oAkbVvhOoQQvU9eMX7Ze+BN6ykq9LvyWLScwEF1mIMqwO Zie/JJLtNTPP17Gh/TtVBUs86uI129YtAXepJhptlayf5jSJOwzizsozmeljAAHl 8MV//uXbOc22xxQKGD5u272FuQpmZ14oWqV1vaHOqENr6Zd1SFVFDS8ZE4LkS7dF +R/LpL4gEbA8c+cx9HICy/pck00gE14vXa8KtldVW9CHA0yCNBL4w8ELo0SNwSQZ uC0JnB2Rfjdcdt/Ehq/TtjZoLlpMO+0cvsqOuuNINsiGDmgO1kuo7fCmiGgad4TT Wea8QCkULdJ3eMEKSeRp7Ix1N0N8gWTtkKs+zNSaUlaCRnFtlo0skiULNkmgEfC0 InGXugmNBT42SCTWzVM2XdMvYKVvHT+ym4BUHPsOkKUXpZJXWEHPiAI6pUuk5mJ+ Z3uzncLTmUFJwrR6xFYclvi1V/Isw4/XQQ0q1Cx3QhQDPRmLJQyO61etPtXFcLsK QV95Z3hk =VxZz -----END PGP SIGNATURE----- --YW2MF9I5J49Ey/EG--